From patchwork Thu Sep 7 00:30:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 111845 Delivered-To: patches@linaro.org Received: by 10.140.94.239 with SMTP id g102csp54645qge; Wed, 6 Sep 2017 17:31:14 -0700 (PDT) X-Received: by 10.84.248.13 with SMTP id p13mr968753pll.447.1504744274537; Wed, 06 Sep 2017 17:31:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504744274; cv=none; d=google.com; s=arc-20160816; b=FXA1N7XDmxtcgSwLo2/sBEn7c07zeiUsOxeRpSvRmdumBisOpBQXQUw8Of0y8CWLA8 K64liIFPx4MQdsHnf401u8L/BNc8vBvuGeC7TDYz3hMhKTRr+Zh3mVx+bJirKKuFMsp6 /p8G/N9/4HWtIaHkd2PiuNfqvva6HxrAtuC+Yl+pTzlQiUrO6rsW1nQsynpbPL9S2wIc FgHLVUAl8ahbnsuU6VZ5eflLhMgb4pWEt4i4u1cFeRusabiV314DBwUb1l9P6xHJkuGv PNmfjgtVdhtk8ZI32mjD/fVTaTaExFRHCYvcjctCqEtWoUqO8lTlPvUsvEdpzXnDtHVl Je7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=M3WxAtVNlo56ELffA0RgMLbcU0FcXpzP/gl3tIwdcNI=; b=1JI1zr7z/ztQioPK3tBDsgQz1pawhQT35HLXGNabqos4k1DXcngcJH5Fv/ZAXhMRAq 22DEHpW8+LbmYa4DGjTbOjZxEgwJV0nhhWoZSlfsWer1+5X2u5uROihE3PWLE2ep+Mj2 JqdT9UdB0oy0fCWfeV8uwpy3p/rEvZIu9ArdFxJ65efaXgvtokwiQGSC2fShjDDIjeKB GF2MhJ+RNNAM68ex9z/pYskoSguCBCNZb104aD9AGDEI/dqRbwFYr3XPfFokRHGnLhDm so8HbS7703hMGZYiyWS1o3lI+840ePla8CloqjZhNjvEBE69aZh1k6jOrA14N485VQws Mmdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Dg9jdPNN; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id r16sor545580pfk.115.2017.09.06.17.31.14 for (Google Transport Security); Wed, 06 Sep 2017 17:31:14 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Dg9jdPNN; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=M3WxAtVNlo56ELffA0RgMLbcU0FcXpzP/gl3tIwdcNI=; b=Dg9jdPNNLcjbtoEnWfAoxgL34E2k4g+yzq6V3hHjzTiQIUiomdfG18nCFTGHW26GFx GezJ2d9vOK5tTuZuJsYw4MDnyOsk4uJVVCypwveTnjF7fqBD+VH3gdPpVxLwA1CzNyJx 8/2mxWvGVI5NtWPcZ0qksSyZZQSqlmp8JpUpE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=M3WxAtVNlo56ELffA0RgMLbcU0FcXpzP/gl3tIwdcNI=; b=lBRyKQFZ7jug8hLqAc7zpB4UHgRKAnum+Si/lgwpniTHLwulgraFkwlqDx4gAMqgDd Y+UbQOjXS1JxaNubP/AWx/kR/kYYSk44HqL7EwsW/WIHkMyK+z6Lbgkf3vg3zTlDq4U1 iOhYa8KZOMJbkm+Flg1SQagyQdlblkp2N+KeelGp7d1uAfDvfpWM+TOoToV2iZU0+S3h 59sIfAAWj0N4a5FVBBd8+0Bxw6MwOlTqtV/dXdbHiL0ZKOJv/cjo5KiYBw7npjWLaGY6 qlFHhQL9C3mr7/Gh/7wdlsBDr3WOOkT0xrbV65qDT/q8+d+nDDeKMRqfpZSfaevN4hnv EBMA== X-Gm-Message-State: AHPjjUjKu1Cc22rtFu9d3I+gHBt1DsXIf+HRJDreo7iY4NsmzakkED7O 6q2gVnArTSEeSZIQLjI= X-Google-Smtp-Source: ADKCNb6Z7sjLMwk5TQ7maPpgJ8HAgUuAwYYk0uJp+wFrzS2tTOmRxYaz7u93Xskg+lfY5tlMqdbIlw== X-Received: by 10.98.17.216 with SMTP id 85mr961586pfr.206.1504744274229; Wed, 06 Sep 2017 17:31:14 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([2601:1c2:1002:83f0:4e72:b9ff:fe99:466a]) by smtp.gmail.com with ESMTPSA id o19sm987378pgn.76.2017.09.06.17.31.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 06 Sep 2017 17:31:13 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Wei Xu , Guodong Xu , Amit Pundir , YongQin Liu , John Youn , Minas Harutyunyan , Douglas Anderson , Chen Yu , Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: [RESEND][PATCH 3/3] usb: dwc2: Fix UDC state tracking Date: Wed, 6 Sep 2017 17:30:55 -0700 Message-Id: <1504744255-25281-4-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1504744255-25281-1-git-send-email-john.stultz@linaro.org> References: <1504744255-25281-1-git-send-email-john.stultz@linaro.org> It has been noticed that the dwc2 udc state reporting doesn't seem to work (at least on HiKey boards). Where after the initial setup, the sysfs /sys/class/udc/f72c0000.usb/state file would report "configured" no matter the state of the OTG port. This patch adds a call so that we report to the UDC layer when the gadget device is disconnected. Cc: Wei Xu Cc: Guodong Xu Cc: Amit Pundir Cc: YongQin Liu Cc: John Youn Cc: Minas Harutyunyan Cc: Douglas Anderson Cc: Chen Yu Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Reported-by: Amit Pundir Signed-off-by: John Stultz --- drivers/usb/dwc2/gadget.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.7.4 diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 7fd0e38..603c216 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -3202,6 +3202,8 @@ void dwc2_hsotg_disconnect(struct dwc2_hsotg *hsotg) call_gadget(hsotg, disconnect); hsotg->lx_state = DWC2_L3; + + usb_gadget_set_state(&hsotg->gadget, USB_STATE_NOTATTACHED); } /**