From patchwork Mon Sep 4 11:41:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 111548 Delivered-To: patch@linaro.org Received: by 10.37.128.210 with SMTP id c18csp4118685ybm; Mon, 4 Sep 2017 04:41:54 -0700 (PDT) X-Google-Smtp-Source: ADKCNb5S9DfX4+SY4mcsSdlF15aSOdJM0Qp/K58CJXsSMdAAuXdOXLZishI6FCh2al37MWsy1Mn2 X-Received: by 10.99.95.145 with SMTP id t139mr132957pgb.153.1504525313926; Mon, 04 Sep 2017 04:41:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504525313; cv=none; d=google.com; s=arc-20160816; b=o/+9ZHvl0B0SRMk+jvGNzcvKzmLMexlBW2oCFnqjt/Iv3iP8SxGLbdxVKwQnb56wS5 hn+vTXY2vranid6rJRrmAfIWR4i5zA1gdcLA/Hx+mGSIteQHfjNnQF7FnUcmDFqHpSzC J4KyY+xRLviQQg+jszRVEo4EnqXwOjI9k/xjFSpBGJV+WwAI70mM/16qL/73qYosEMna JkGwjSWuvrJWTnfyYxGA4uMQSR4lEAE+5pnWx8D0zWJ945xVE1ZAu7kD+bw1b2nNzJaK IKNqZMFrtlP6ljteCPtY3vUxHf4aFZ9NNJp+NQzO8ZXkSXXYI3ZRVli9ZOAUA3RHMFg5 Ilqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=Iv9SXD4xj4CVKg7h6NkyDeoKJgah4pYGuHAr1Ux8LOA=; b=zY8mSIfdNHsRHpZ2JV2HW3KZbBm0TetTB61dVSzMAi/IKUKT//fuI9dNaPs5Kq5FnJ R4rQCNdbqqjGdBT4DzUP6rlWEQnVpf/C+yDqZArkjPr0KdW47qDhtKVwGiS49VcEklwX P5ss9P7icyJQyoEhrjgPwwe8IMaECDH/L6GS2qVrEazf0bRusNYt2wGsIwFsnUDQNqe8 ddCppsoHSA3o/md3WL5L0q3+11hv1vYuLxP9SqsBtRBfb2nngjvMgT3ZAJOfOqVPCRZG A8Af78pde4SLd+Nk3lq/uDBucmz16ONjIWnS/uHfOD7nkvRLwyP0Vo6Kcl4oDNAHBIyz dg4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=tjbZMKqS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g11si5328683plm.262.2017.09.04.04.41.53; Mon, 04 Sep 2017 04:41:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=tjbZMKqS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753607AbdIDLlt (ORCPT + 26 others); Mon, 4 Sep 2017 07:41:49 -0400 Received: from conuserg-10.nifty.com ([210.131.2.77]:42936 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753485AbdIDLlp (ORCPT ); Mon, 4 Sep 2017 07:41:45 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-10.nifty.com with ESMTP id v84BfT4s006520; Mon, 4 Sep 2017 20:41:31 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com v84BfT4s006520 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1504525291; bh=Iv9SXD4xj4CVKg7h6NkyDeoKJgah4pYGuHAr1Ux8LOA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tjbZMKqS8dWJGGzX8comhx/d4WkVC/hL4h2pD6eu0mZeJVuc2d6NTTcR++nm7tQ4B whi07HljRZJ3jndqih43WeKMayZfJaG32hu2enTP6FyXMzpmmxMaJ8QJWR4JjexAaF qcKiFP4HNzbBsnkD6sAWb33C+uuRueDkNLaRt+W2OWHyimvwC8YQBCqKhgf4bXaaR+ iX4/rcE2PJ1ZXFd01ODnxEcFhogcWf1l29U3eEG2LARmQMU4yywMDDFh1XLKGAmmmO En72sYSzEHSHTNdlrZypBMlQAT5TCKizPVmyxqGCAZo9iRIK8dDAT/4oPLpr2/Ci6j LclgOSNJ9AUUA== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Srinivas Kandagatla Cc: Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH 2/3] nvmem: remove inline in drivers/nvmem/core.c Date: Mon, 4 Sep 2017 20:41:15 +0900 Message-Id: <1504525276-11507-3-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1504525276-11507-1-git-send-email-yamada.masahiro@socionext.com> References: <1504525276-11507-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These two functions are defined in .c file, but called just once (at least for now). So, the compiler will fold them into their callers even without the "inline" markers. However, this kind of optimization should not be done by hand. It is compiler's judge after all. Signed-off-by: Masahiro Yamada --- drivers/nvmem/core.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) -- 2.7.4 diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index ebd673c..8d915da 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -946,8 +946,7 @@ void nvmem_cell_put(struct nvmem_cell *cell) } EXPORT_SYMBOL_GPL(nvmem_cell_put); -static inline void nvmem_shift_read_buffer_in_place(struct nvmem_cell *cell, - void *buf) +static void nvmem_shift_read_buffer_in_place(struct nvmem_cell *cell, void *buf) { u8 *p, *b; int i, bit_offset = cell->bit_offset; @@ -1028,8 +1027,8 @@ void *nvmem_cell_read(struct nvmem_cell *cell, size_t *len) } EXPORT_SYMBOL_GPL(nvmem_cell_read); -static inline void *nvmem_cell_prepare_write_buffer(struct nvmem_cell *cell, - u8 *_buf, int len) +static void *nvmem_cell_prepare_write_buffer(struct nvmem_cell *cell, + u8 *_buf, int len) { struct nvmem_device *nvmem = cell->nvmem; int i, rc, nbits, bit_offset = cell->bit_offset;