| Message ID | 1503999271-15712-9-git-send-email-daniel.lezcano@linaro.org |
|---|---|
| State | Accepted |
| Commit | ebbe266509d8a5453f51f77277da65d870125b72 |
| Headers | show |
| Series | None | expand |
I would prefer to use the wording “for a” instead of “on” in the commit subject. > The bcm2835_timer_init() function emits an error message in case of a memory > allocation failure. This is pointless as the mm core already do that. Does this commit message contain a typo? Would a wording like “… does that already.” be more appropriate here? Regards, Markus
On 29/08/2017 13:21, SF Markus Elfring wrote: > I would prefer to use the wording “for a” instead of “on” in the commit subject. > > >> The bcm2835_timer_init() function emits an error message in case of a memory >> allocation failure. This is pointless as the mm core already do that. > > Does this commit message contain a typo? > Would a wording like “… does that already.” be more appropriate here? Yep. Fixed. Thanks. -- Daniel -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
>> Would a wording like “… does that already.” be more appropriate here? > > Yep. Fixed. Thanks for this adjustment. https://git.linaro.org/people/daniel.lezcano/linux.git/commit/?h=clockevents/4.14&id=fd388bc07c2ca854f28f405bb65470647499dcaa Do you disagree to my suggestion to amend also the commit subject? Regards, Markus
On 29/08/2017 15:12, SF Markus Elfring wrote: >>> Would a wording like “… does that already.” be more appropriate here? >> >> Yep. Fixed. > > Thanks for this adjustment. > https://git.linaro.org/people/daniel.lezcano/linux.git/commit/?h=clockevents/4.14&id=fd388bc07c2ca854f28f405bb65470647499dcaa > > Do you disagree to my suggestion to amend also the commit subject? Just wanted to keep it short. -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
>> https://git.linaro.org/people/daniel.lezcano/linux.git/commit/?h=clockevents/4.14&id=fd388bc07c2ca854f28f405bb65470647499dcaa >> >> Do you disagree to my suggestion to amend also the commit subject? > > Just wanted to keep it short. I propose to reconsider the preposition which should be used in the title. Regards, Markus
On 29/08/2017 15:20, SF Markus Elfring wrote: >>> https://git.linaro.org/people/daniel.lezcano/linux.git/commit/?h=clockevents/4.14&id=fd388bc07c2ca854f28f405bb65470647499dcaa >>> >>> Do you disagree to my suggestion to amend also the commit subject? >> >> Just wanted to keep it short. > > I propose to reconsider the preposition which should be used in the title. Done. -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
diff --git a/drivers/clocksource/bcm2835_timer.c b/drivers/clocksource/bcm2835_timer.c index 82828d3..39e489a 100644 --- a/drivers/clocksource/bcm2835_timer.c +++ b/drivers/clocksource/bcm2835_timer.c @@ -114,7 +114,6 @@ static int __init bcm2835_timer_init(struct device_node *node) timer = kzalloc(sizeof(*timer), GFP_KERNEL); if (!timer) { - pr_err("Can't allocate timer struct\n"); ret = -ENOMEM; goto err_iounmap; }