From patchwork Thu Aug 24 14:18:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gilad Ben-Yossef X-Patchwork-Id: 110918 Delivered-To: patch@linaro.org Received: by 10.37.128.210 with SMTP id c18csp8560966ybm; Thu, 24 Aug 2017 07:20:34 -0700 (PDT) X-Received: by 10.99.113.25 with SMTP id m25mr6603861pgc.432.1503584434578; Thu, 24 Aug 2017 07:20:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1503584434; cv=none; d=google.com; s=arc-20160816; b=Eps5swt7Z8lkSGKW9MGabLDIYlX61SEf85jovsDf+LQupnF1skBlkSuhSatHQDkzxR xgU+XnhatcvYsSLKxk4IwfhDPQb3hVQO75gMhhGQMmaOSZwJzfaWuAYCjqBb48e574HN Vh9DMKzCO5jIKSSt4wjOWHIBtgDFg15yIsPXF1yV25Ff5ggvUiFzz4lhN3JTM+WFigig NPcIzcItYge2v1I0xAfFWDc3Bam8ZTccEdJHZIAyzGecqg+hWqTxveeN7kad7voVJueX CxPYco7enDJGnlAXzsOE49EH81Wq2xRupJnJl9XghQLwEqfNFQK7RS8d2PRWiEXu4UBq tUkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=IWQxhc9f+ZEDcXLqo69EmeKTP3a7hAl6VOEf3gYUOes=; b=T9Z134+JxDk5TFni5N6eZ6XDFPL83VAyEn89e/OuuQlLYhJq/tm4OenKw1B7IXtFAz U9E2yT4VMIq8kjsPTINmhwu9BQHB6LY811Ehfm8olCb1TgxoY2wUtk4anoW+ytX5Mwq7 Z06rd+D8JoNWBOQpp7OOUPJzZ/ANTBAqIgPDHFSmAgM6z/YRzLO9BoGSs4Nms0s8Ouya zi0yABdEaocXzPTYSAkvr4BdEvlxBgh06RQnqM+eB8PRky2aWEZ3+OLs1JUpXXP9bZh3 J6B13KcaALeNGGtLd62JtS951wn1YOvxWQNAi+Ib1rzSjmLE7lwfcN5zk4CA1qQcwXat 2rIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v31si668579pgn.240.2017.08.24.07.20.34; Thu, 24 Aug 2017 07:20:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753414AbdHXOUd (ORCPT + 26 others); Thu, 24 Aug 2017 10:20:33 -0400 Received: from foss.arm.com ([217.140.101.70]:41818 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752681AbdHXOU3 (ORCPT ); Thu, 24 Aug 2017 10:20:29 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 129B416BA; Thu, 24 Aug 2017 07:20:29 -0700 (PDT) Received: from gby.kfn.arm.com (unknown [10.45.48.132]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 315D63F540; Thu, 24 Aug 2017 07:20:19 -0700 (PDT) From: Gilad Ben-Yossef To: Herbert Xu , "David S. Miller" , Jonathan Corbet , David Howells , Tom Lendacky , Gary Hook , Boris Brezillon , Arnaud Ebalard , Matthias Brugger , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Shaohua Li , Steve French , "Theodore Y. Ts'o" , Jaegeuk Kim , Mimi Zohar , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-raid@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fscrypt@vger.kernel.org, linux-ima-devel@lists.sourceforge.net, linux-ima-user@lists.sourceforge.net, linux-security-module@vger.kernel.org Cc: Ofir Drang , Eric Biggers , Jonathan Cameron Subject: [PATCH v7 05/19] crypto: introduce crypto wait for async op Date: Thu, 24 Aug 2017 17:18:52 +0300 Message-Id: <1503584350-7831-6-git-send-email-gilad@benyossef.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1503584350-7831-1-git-send-email-gilad@benyossef.com> References: <1503584350-7831-1-git-send-email-gilad@benyossef.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Invoking a possibly async. crypto op and waiting for completion while correctly handling backlog processing is a common task in the crypto API implementation and outside users of it. This patch adds a generic implementation for doing so in preparation for using it across the board instead of hand rolled versions. Signed-off-by: Gilad Ben-Yossef CC: Eric Biggers CC: Jonathan Cameron --- crypto/api.c | 13 +++++++++++++ include/linux/crypto.h | 40 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 53 insertions(+) -- 2.1.4 diff --git a/crypto/api.c b/crypto/api.c index 941cd4c..2a2479d 100644 --- a/crypto/api.c +++ b/crypto/api.c @@ -24,6 +24,7 @@ #include #include #include +#include #include "internal.h" LIST_HEAD(crypto_alg_list); @@ -595,5 +596,17 @@ int crypto_has_alg(const char *name, u32 type, u32 mask) } EXPORT_SYMBOL_GPL(crypto_has_alg); +void crypto_req_done(struct crypto_async_request *req, int err) +{ + struct crypto_wait *wait = req->data; + + if (err == -EINPROGRESS) + return; + + wait->err = err; + complete(&wait->completion); +} +EXPORT_SYMBOL_GPL(crypto_req_done); + MODULE_DESCRIPTION("Cryptographic core API"); MODULE_LICENSE("GPL"); diff --git a/include/linux/crypto.h b/include/linux/crypto.h index 84da997..78508ca 100644 --- a/include/linux/crypto.h +++ b/include/linux/crypto.h @@ -24,6 +24,7 @@ #include #include #include +#include /* * Autoloaded crypto modules should only use a prefixed name to avoid allowing @@ -468,6 +469,45 @@ struct crypto_alg { } CRYPTO_MINALIGN_ATTR; /* + * A helper struct for waiting for completion of async crypto ops + */ +struct crypto_wait { + struct completion completion; + int err; +}; + +/* + * Macro for declaring a crypto op async wait object on stack + */ +#define DECLARE_CRYPTO_WAIT(_wait) \ + struct crypto_wait _wait = { \ + COMPLETION_INITIALIZER_ONSTACK((_wait).completion), 0 } + +/* + * Async ops completion helper functioons + */ +void crypto_req_done(struct crypto_async_request *req, int err); + +static inline int crypto_wait_req(int err, struct crypto_wait *wait) +{ + switch (err) { + case -EINPROGRESS: + case -EBUSY: + wait_for_completion(&wait->completion); + reinit_completion(&wait->completion); + err = wait->err; + break; + }; + + return err; +} + +static inline void crypto_init_wait(struct crypto_wait *wait) +{ + init_completion(&wait->completion); +} + +/* * Algorithm registration interface. */ int crypto_register_alg(struct crypto_alg *alg);