From patchwork Thu Aug 17 19:03:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 110343 Delivered-To: patches@linaro.org Received: by 10.182.109.195 with SMTP id hu3csp2577084obb; Thu, 17 Aug 2017 12:03:24 -0700 (PDT) X-Received: by 10.84.229.136 with SMTP id c8mr7154551plk.351.1502996603969; Thu, 17 Aug 2017 12:03:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502996603; cv=none; d=google.com; s=arc-20160816; b=cpAlHzpnhjTJA+URDTPvGTuvStUwnogIExfk79mJLwqolvoh2XBeeHAG/adbO6l3Zm Mt75/HlxKVKeQ7Q7+MFq2MiuWvIheKiYPPvg5W3ukDsMe62Ct86Zxn4GJ17ARzJqt0GX MJCLv6RIWDmgFC6kc5KuhzRD+iQx+G7GyJDWUDEEKnTcVZlQisLphM/OylTJh58biqNW xkAraz2Xu1EvOVX3hphU6V1vptkbOLHhbMpDRgHFsxDAL942LFrIk1lJVnxw0RvPoVK3 kRB+8AX4LR1y5ICnJsibOLDI1XusOfyxkTtletvKXyQnEPys3A4UVO08hInRNS1FPFaU 2ALg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=MOYhtf8xm7G+kwlTTcgfr6EYFQuSq3W+p/U+sLVvR8I=; b=sy1qIb1TTu8iirEmXcozKksJEXjHqU5IyC4eETXlSaae1p2tmDNqWTEc1sbEQiWPYz yuHmX+C3D+/+hI0pCtq129JKPeTrze/7NVd2MVco3Xqhoi/flJ/szuN4j93ft5aKx3xM LCCmak61m76w+Ck6mX+H+4CPAykMIrZg8PIKyrEEM3grF80o0F+hH8e9AgjD7tveIoG4 Yfx3UxzpwePdgW99KYgriAeIKz74pPtbSNS4REiPKTVeVwFlymNeyoRK0cu3RDt2rB3F x6W+jtssNUwpTZG09Ps0QREU5UStrOXiFrPpzl/YSFbQo3hlqSAwrrzQhWcNCoJZBRXX Mehg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F0wGwkxx; spf=pass (google.com: domain of john.stultz@linaro.org designates 2607:f8b0:400e:c05::236 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-pg0-x236.google.com (mail-pg0-x236.google.com. [2607:f8b0:400e:c05::236]) by mx.google.com with ESMTPS id p22si2640658pli.1022.2017.08.17.12.03.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Aug 2017 12:03:23 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 2607:f8b0:400e:c05::236 as permitted sender) client-ip=2607:f8b0:400e:c05::236; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F0wGwkxx; spf=pass (google.com: domain of john.stultz@linaro.org designates 2607:f8b0:400e:c05::236 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: by mail-pg0-x236.google.com with SMTP id i12so48663995pgr.3 for ; Thu, 17 Aug 2017 12:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MOYhtf8xm7G+kwlTTcgfr6EYFQuSq3W+p/U+sLVvR8I=; b=F0wGwkxxsiXvTpb1RO/uX6ZRTYeaM/3eTaKdW0iAUIyIBBWGzJC3Sx7sYz+eKbRgim o7+nTStcesuE4Re+pbFHr2K5x96Rbi0VpBfzUXQtky3h3RL7PEK8EFo88WRS1c53cyIY gC/caz4IrO5ofL7JlL5ipu9MuPvkyJnER9WU0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=MOYhtf8xm7G+kwlTTcgfr6EYFQuSq3W+p/U+sLVvR8I=; b=RL8/SDeoIEkKeNPMKHkoY16szANOawJ7Z2Eo7RoKDW7q6VZxhWa0i/QkkfCrZKh84g 7OVRTtNFEfB6xzuJa87qavwjlZGvvkACJXWLX7AO1gvt2vN9go+lpzpzCVZCuROzE0JM cEBVtGqglAolFRPbAB4xwNEq6gIu/OJq0NTswT1ALh9ZRryb4ixuad+NGJU7VwKW4N7h 0uCaoHzf1bfJixJ4HI5/qHeJf4B3n2n4LdDTaGnQH8NrXdOcKhjM2BT2y1C0ZlM1N1kH Cl8psnZgC7akclLURiAsXfhDrXywyuJeijtzuBH4KbxcF9R3rTK6XTAxAoAtP316OTiT ofXA== X-Gm-Message-State: AHYfb5hcQglONTENyC8EMNI/nnb4Ydu8rfZqvqIe3wUgrbOfFjz2TAzM XYzfVuqHfJzLceghh7c= X-Received: by 10.99.4.9 with SMTP id 9mr3002473pge.70.1502996603671; Thu, 17 Aug 2017 12:03:23 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([2601:1c2:1002:83f0:4e72:b9ff:fe99:466a]) by smtp.gmail.com with ESMTPSA id r86sm9337806pfi.161.2017.08.17.12.03.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 Aug 2017 12:03:22 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Wei Xu , Guodong Xu , Amit Pundir , YongQin Liu , John Youn , Minas Harutyunyan , Douglas Anderson , Chen Yu , Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: [PATCH 2/3] usb: dwc2: Fix UDC state tracking Date: Thu, 17 Aug 2017 12:03:14 -0700 Message-Id: <1502996595-15316-2-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1502996595-15316-1-git-send-email-john.stultz@linaro.org> References: <1502996595-15316-1-git-send-email-john.stultz@linaro.org> It has been noticed that the dwc2 udc state reporting doesn't seem to work (at least on HiKey boards). Where after the initial setup, the sysfs /sys/class/udc/f72c0000.usb/state file would report "configured" no matter the state of the OTG port. This patch adds a call so that we report to the UDC layer when the gadget device is disconnected. Cc: Wei Xu Cc: Guodong Xu Cc: Amit Pundir Cc: YongQin Liu Cc: John Youn Cc: Minas Harutyunyan Cc: Douglas Anderson Cc: Chen Yu Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Reported-by: Amit Pundir Signed-off-by: John Stultz --- drivers/usb/dwc2/gadget.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.7.4 diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index c4066cd..e6f2cd8 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -3202,6 +3202,8 @@ void dwc2_hsotg_disconnect(struct dwc2_hsotg *hsotg) call_gadget(hsotg, disconnect); hsotg->lx_state = DWC2_L3; + + usb_gadget_set_state(&hsotg->gadget, USB_STATE_NOTATTACHED); } /**