From patchwork Thu Aug 10 16:09:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 109824 Delivered-To: patch@linaro.org Received: by 10.182.109.195 with SMTP id hu3csp2564023obb; Thu, 10 Aug 2017 08:46:21 -0700 (PDT) X-Received: by 10.84.231.200 with SMTP id g8mr13705547pln.21.1502379981839; Thu, 10 Aug 2017 08:46:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502379981; cv=none; d=google.com; s=arc-20160816; b=kDi8ooNfB4Ysd9GkA9rezFSty5dwUUftCUX6vcawjSgFCfJVS6mobko/Aihj+fJ9c/ DUmkrMrug6uZqopq3N7J3Rhvvm3k/cyNZeSuPOXzHwMjkv9PXJyuXr5d4aNQ5gA8/Z4Q HntINSLVYD01Kq4huukD6WBs4j7Z2CZFp0B8FaVf57U0qmWMBN4UZdMcCth6QIBe9wIV 9fXzQ9BQXJnXmrToXGgRR6eI5D/h/3G3hdy4decVVZU4GpC02ImHBmITJeMsPyYVKcCR dddoLAOhVXA/2FekjNbY1enGaEt9R4S6+hXMS414lQ43dezke36fGH3uw6Rx0HL8d4CG wytQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=zpzjLHt2zX0/z6jYv9nPiE5qedQgLTn27cNx7gdLSUk=; b=lyOYXtvAqqeCxWBV3WoW91xyM3p51bGvkb6GfMmQaePUoLG5twBp7+vRO5iV34CECV 7A7X17EJTXdBcrfO2d9lv5Xh6FereFkyi9a1BIzvvqxBAnYx4w9RzR07qY2Oc0+NWZNH LqwnwF5e3Mul25xi2hZS7A37OIRtgupuJK71PowCT/SUi8kev++twn+eBq+rhWW6YSKo QOfhxbcp8Y28HEwA3YELx8p0Os3fGSqMDoY+Z/ikFvnnM78nFkbRbmhsHEbtQrgxvxA3 FXOOEQy+nr6AFJFOMZu2lJNgAoU3HGNw6WOjTazXdkrfDQsyk1snoHmbW536r/2hSel6 vNXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u140si4082417pgb.966.2017.08.10.08.46.21; Thu, 10 Aug 2017 08:46:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753266AbdHJPqT (ORCPT + 25 others); Thu, 10 Aug 2017 11:46:19 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3495 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752944AbdHJPmy (ORCPT ); Thu, 10 Aug 2017 11:42:54 -0400 Received: from 172.30.72.58 (EHLO DGGEMS402-HUB.china.huawei.com) ([172.30.72.58]) by dggrg04-dlp.huawei.com (MOS 4.4.6-GA FastPath queued) with ESMTP id DEV99176; Thu, 10 Aug 2017 23:42:51 +0800 (CST) Received: from localhost.localdomain (10.67.212.75) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.301.0; Thu, 10 Aug 2017 23:42:40 +0800 From: John Garry To: , CC: , , , , John Garry Subject: [PATCH 17/19] scsi: hisi_sas: remove phy_down_v3_hw() res variable Date: Fri, 11 Aug 2017 00:09:42 +0800 Message-ID: <1502381384-219889-18-git-send-email-john.garry@huawei.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1502381384-219889-1-git-send-email-john.garry@huawei.com> References: <1502381384-219889-1-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.67.212.75] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.598C7EFB.00C4, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 30298d4c6d8c44798f7b513410563a3a Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Variable res only holds value 0, so remove it. This cleans up a coccicheck warning. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 1.9.1 diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c index 8e4bfad..3620a3e 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c @@ -1200,7 +1200,6 @@ static int phy_up_v3_hw(int phy_no, struct hisi_hba *hisi_hba) static int phy_down_v3_hw(int phy_no, struct hisi_hba *hisi_hba) { - int res = 0; u32 phy_state, sl_ctrl, txid_auto; struct device *dev = hisi_hba->dev; @@ -1221,7 +1220,7 @@ static int phy_down_v3_hw(int phy_no, struct hisi_hba *hisi_hba) hisi_sas_phy_write32(hisi_hba, phy_no, CHL_INT0, CHL_INT0_NOT_RDY_MSK); hisi_sas_phy_write32(hisi_hba, phy_no, PHYCTRL_NOT_RDY_MSK, 0); - return res; + return 0; } static void phy_bcast_v3_hw(int phy_no, struct hisi_hba *hisi_hba)