From patchwork Mon Jun 12 15:55:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 103645 Delivered-To: patch@linaro.org Received: by 10.140.91.77 with SMTP id y71csp260250qgd; Mon, 12 Jun 2017 08:57:36 -0700 (PDT) X-Received: by 10.99.127.73 with SMTP id p9mr59071669pgn.169.1497283056660; Mon, 12 Jun 2017 08:57:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1497283056; cv=none; d=google.com; s=arc-20160816; b=csFyoffbydl+38cOj3hnMNrV3g7s7LKNCVlB/n3BDSImtmdrBUlZCR6HQWd4Z/BCyE T8MlmL8lrPu0IsvEH+fLuCX9/k/RSBjeNbI7DRKz79QUSCYI7u/h00aC6mxssHpgiKhg 7zZDXMHXJ0nXS9p6ZMe8XHZxiSACDVkbCCju6o51mefFRj+/BaRDRTSC21bseBa7SYa+ YQrHcQWPZgdZhUppGjQrTjbn0ZjcIF2RMhfEW0D+G+fjrNFAr7hGDcLjzpMcqkyPjW/T ipQySptESEC88aUyG+MlwGg0GGNv5DRexotn6bWaGKfAGmXUr0wd+NRb2Abds2Q5H31t Y/4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=FYtyRDTgFKMz4tbFcH1cEAomeE2isqJ67tqDqam/FCE=; b=03D4JzQR4DON3I+cyRHJsuDIb/Ogc6qWdd7iAyDzIa0Ceg3CPaef5fstEtZyyXJXPO pLTQ2ZOc8IwbpbYfEBNGb3L7XGiN7zpqI3W8DWFZ+1ULh/aqawGzZeoW211ycJsv8hxa 8R3UbNFRogN7E3dYzRLNNjwTjjVwXRdFKG3LUQvPh/5yycCBncjsh9/n3uFxBhGzFzWy 3yUyWVL/zpPPMY2aJlPsdTowgG/3ff0izLBXnqVOFlskoylckPgeLCthdUU1bmjYAqSP oLXhXtPs3eHeODosxrTup/CXjzeeJAqrW6AXB4iVxUOaeit5JELuLhSeLPTH+BmfBkID W5Ag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i5si7263583plk.458.2017.06.12.08.57.36; Mon, 12 Jun 2017 08:57:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753157AbdFLP5N (ORCPT + 25 others); Mon, 12 Jun 2017 11:57:13 -0400 Received: from mail-wr0-f182.google.com ([209.85.128.182]:36078 "EHLO mail-wr0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752365AbdFLP5K (ORCPT ); Mon, 12 Jun 2017 11:57:10 -0400 Received: by mail-wr0-f182.google.com with SMTP id v111so102465297wrc.3 for ; Mon, 12 Jun 2017 08:57:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FYtyRDTgFKMz4tbFcH1cEAomeE2isqJ67tqDqam/FCE=; b=L+gF9gAma3PRVziluRE2GNcVTKJvZA2jEFz1a7bv9lXcBcZPzD9R6Y76QVGCNLZEmP 6XeNlu8vq8LhRa7JojdwX2i4bGaj2S1pKNqEKkv5mJXQlhC2oEm5Uot8anJxLbF5zZDe T8MpGo0Ks0tQxOQT6HQQRrZ92POifuwAckpq8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FYtyRDTgFKMz4tbFcH1cEAomeE2isqJ67tqDqam/FCE=; b=IhjR7aFVsuPPfkRuNSmiSkBLcAyiwN5xo3LaDOHcZBcAM3gtpIOk3EX+d6cRbqNsHt geel4FEp/o7FRnbcuZPrG6SiuFFpWv5JAFstgIKdrFqI2B7/YQfU96QMxrDV3EamYaM8 ByYqai2ylzceCnz3hp00kEbGNodKERrokZARssqTZ4sbtKvsVmiB+YH8Q77zaiVmR6yT DR311XaqYDELjSwrq28kdJhB6D34Q5yd6VsEheC80n+bdzVbMTmCXOVEiLKrYM7XQ2ZV pTsmIzowFBN6DFkZQsekmRe5lKsQChoTyJkm22N8c/qYyfnPr0/9527/8SOK8rwz2nPB 4ByQ== X-Gm-Message-State: AODbwcA8oJIaOwltGqTQodX9BNp2E48fZX2O783Qh1+bo2m8T26Ws5uQ zHG4pAQBNsfb2Ze8Y4vMXA== X-Received: by 10.223.129.183 with SMTP id 52mr7473962wra.71.1497283029065; Mon, 12 Jun 2017 08:57:09 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:879a:6cd0:289a:9b8c:a41f:e1d5]) by smtp.gmail.com with ESMTPSA id q77sm153978wmb.4.2017.06.12.08.57.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 12 Jun 2017 08:57:08 -0700 (PDT) From: Daniel Lezcano To: rjw@rjwysocki.net Cc: linux-pm@vger.kernel.org, Christophe Jaillet , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 1/2] cpuidle: dt: Add missing 'of_node_put()' Date: Mon, 12 Jun 2017 17:55:09 +0200 Message-Id: <1497282910-19085-1-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <20170612155441.GE2261@mai> References: <20170612155441.GE2261@mai> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe Jaillet 'of_node_put()' should be called on pointer returned by 'of_parse_phandle()' when done. In this function this is done in all path except this 'continue', so add it. Fixes: 97735da074fd ("drivers: cpuidle: Add status property to ARM idle states") Signed-off-by: Christophe JAILLET Signed-off-by: Daniel Lezcano --- drivers/cpuidle/dt_idle_states.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.7.4 Acked-by: Lorenzo Pieralisi diff --git a/drivers/cpuidle/dt_idle_states.c b/drivers/cpuidle/dt_idle_states.c index ffca4fc..ae8eb03 100644 --- a/drivers/cpuidle/dt_idle_states.c +++ b/drivers/cpuidle/dt_idle_states.c @@ -180,8 +180,10 @@ int dt_init_idle_driver(struct cpuidle_driver *drv, if (!state_node) break; - if (!of_device_is_available(state_node)) + if (!of_device_is_available(state_node)) { + of_node_put(state_node); continue; + } if (!idle_state_valid(state_node, i, cpumask)) { pr_warn("%s idle state not valid, bailing out\n",