From patchwork Wed Mar 22 11:02:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Quadros X-Patchwork-Id: 95709 Delivered-To: patch@linaro.org Received: by 10.140.89.233 with SMTP id v96csp175366qgd; Wed, 22 Mar 2017 04:06:35 -0700 (PDT) X-Received: by 10.84.232.78 with SMTP id f14mr17450832pln.7.1490180795557; Wed, 22 Mar 2017 04:06:35 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t62si1392976pgc.233.2017.03.22.04.06.35; Wed, 22 Mar 2017 04:06:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759307AbdCVLGb (ORCPT + 14 others); Wed, 22 Mar 2017 07:06:31 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:22668 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758831AbdCVLGX (ORCPT ); Wed, 22 Mar 2017 07:06:23 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by lelnx194.ext.ti.com (8.15.1/8.15.1) with ESMTP id v2MB2Nnd027566; Wed, 22 Mar 2017 06:02:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1490180543; bh=RPQXjZj6w/Dub3xUFuQmiYhET44WvW1uMMt4tmfqZpw=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=Xwa/rZ1MGpsYbyY64eFJNastv/7x9ZDUp6wJYVQkHnEOGBLWzXYIqzs1a+QRp8vIa u7A5CBYVgifufqnOI8NcM2x5DGweFHxaJW6la0kQDcDpDRDfltdkmAqC5Q+d5nyBnq HuV/T/NZZqveqKF50WQ8Lz0rdgldJlHVr4qjAYHM= Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id v2MB2N4e013863; Wed, 22 Mar 2017 06:02:23 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.3.294.0; Wed, 22 Mar 2017 06:02:22 -0500 Received: from lta0400828d.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id v2MB2HlT015824; Wed, 22 Mar 2017 06:02:20 -0500 From: Roger Quadros To: CC: , , , , , , Roger Quadros , "stable # v4 . 9+" Subject: [PATCH v2 1/2] net: phy: Fix PHY AN done state machine for interrupt driven PHYs Date: Wed, 22 Mar 2017 13:02:03 +0200 Message-ID: <1490180524-28675-2-git-send-email-rogerq@ti.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1490180524-28675-1-git-send-email-rogerq@ti.com> References: <1490180524-28675-1-git-send-email-rogerq@ti.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org he ethernet link on an interrupt driven PHY was not coming up if the ethernet cable was plugged before the ethernet interface was brought up. The PHY state machine seems to be stuck from RUNNING to AN state with no new interrupts from the PHY. So it doesn't know when the PHY Auto-negotiation has been completed and doesn't transition to RUNNING state with ANEG done thus netif_carrier_on() is never called. NOTE: genphy_config_aneg() will not restart PHY Auto-negotiation of advertisement parameters didn't change. Fix this by scheduling the PHY state machine in phy_start_aneg(). Fixes: 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not polling.") Cc: stable # v4.9+ Signed-off-by: Roger Quadros --- drivers/net/phy/phy.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.7.4 diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 1be69d8..49dedf8 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -630,6 +630,10 @@ int phy_start_aneg(struct phy_device *phydev) out_unlock: mutex_unlock(&phydev->lock); + if (!err && phy_interrupt_is_valid(phydev)) + queue_delayed_work(system_power_efficient_wq, + &phydev->state_queue, HZ); + return err; } EXPORT_SYMBOL(phy_start_aneg);