From patchwork Fri Mar 17 15:02:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 95425 Delivered-To: patch@linaro.org Received: by 10.140.89.134 with SMTP id v6csp346276qgd; Fri, 17 Mar 2017 08:04:45 -0700 (PDT) X-Received: by 10.84.212.8 with SMTP id d8mr20840531pli.152.1489763084997; Fri, 17 Mar 2017 08:04:44 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c194si6340542pfc.14.2017.03.17.08.04.44; Fri, 17 Mar 2017 08:04:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751221AbdCQPE0 (ORCPT + 12 others); Fri, 17 Mar 2017 11:04:26 -0400 Received: from mail-pg0-f47.google.com ([74.125.83.47]:36604 "EHLO mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751094AbdCQPEX (ORCPT ); Fri, 17 Mar 2017 11:04:23 -0400 Received: by mail-pg0-f47.google.com with SMTP id g2so42838205pge.3 for ; Fri, 17 Mar 2017 08:04:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=L+0TWqNd/lwJxEk+l6nkmFJFJZ+3J5TKXp7w41BiOVg=; b=RTuPa3264K/31JEfYr/aGClXC461MBHAAfdHA+r9EIuLSIfAexjcMxdzAbbD8NxHgC se29GJ4CvkSnu4T6IeWDFLhcazlgIkPiAgLmByHb4lulan5+ISRdQm7lbk6T9syRJaEV 2rTSMyTbcYqW2L9+idWtbwMy01OSzB6wwhn2g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=L+0TWqNd/lwJxEk+l6nkmFJFJZ+3J5TKXp7w41BiOVg=; b=UMPNQlPsvWN1oAdAXRZJ/iBZeJqSy9G5wJFK81MANlLBb6ikTicwYjVv87AEjaM8xa 7IH7mh3OfD6H5rmBOWhin5wqRobB8Bh4+rg9gpiCl9j0ZgYSz5wXibJ2AtycyDsNnilh tEILpWc1nQkC99oynRWMqk2nvnEuL45KuS8xK7bOtcH+CIZrbXoAh1hNV9lR3xhdVRW5 7lqFXuJ6rh6mntW2wliaE4vOSOsCArQu42LOmJTK9m8r0kfAnCBRYGs8EKmulNAiswVx Bofl0x3LSfL2W0+pLPYMPqoctsLqk6NcG/gjTUAOCCXYMaYPqjsImdvCpnPypp+DOvc1 vR3Q== X-Gm-Message-State: AFeK/H1nNkIAY/zepAR/b4hbmDequnsSqS2eF6ina7SzLF/JPESSa+doABa0qC9lEPszG9A1 X-Received: by 10.99.98.2 with SMTP id w2mr16381218pgb.103.1489763039421; Fri, 17 Mar 2017 08:03:59 -0700 (PDT) Received: from localhost.localdomain ([103.230.219.215]) by smtp.gmail.com with ESMTPSA id f125sm17482582pfc.4.2017.03.17.08.03.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Mar 2017 08:03:58 -0700 (PDT) From: Leo Yan To: Rob Herring , Mark Rutland , Wei Xu , Catalin Marinas , Will Deacon , Andy Gross , David Brown , Michael Turquette , Stephen Boyd , Mathieu Poirier , Leo Yan , Guodong Xu , John Stultz , Greg Kroah-Hartman , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, mike.leach@linaro.org, Suzuki.Poulose@arm.com, sudeep.holla@arm.com Cc: Suzuki K Poulose Subject: [PATCH v4 2/7] coresight: of_get_coresight_platform_data: Add missing of_node_put Date: Fri, 17 Mar 2017 23:02:18 +0800 Message-Id: <1489762943-25849-3-git-send-email-leo.yan@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1489762943-25849-1-git-send-email-leo.yan@linaro.org> References: <1489762943-25849-1-git-send-email-leo.yan@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Suzuki K Poulose The of_get_coresight_platform_data iterates over the possible CPU nodes to find a given cpu phandle. However it does not drop the reference to the node pointer returned by the of_get_coresight_platform_data. [Leo: minor tweaks for of_get_coresight_platform_data] Cc: Leo Yan Cc: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtracing/coresight/of_coresight.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) -- 2.7.4 diff --git a/drivers/hwtracing/coresight/of_coresight.c b/drivers/hwtracing/coresight/of_coresight.c index 629e031..917ca39 100644 --- a/drivers/hwtracing/coresight/of_coresight.c +++ b/drivers/hwtracing/coresight/of_coresight.c @@ -108,7 +108,8 @@ struct coresight_platform_data *of_get_coresight_platform_data( struct coresight_platform_data *pdata; struct of_endpoint endpoint, rendpoint; struct device *rdev; - struct device_node *dn; + bool found; + struct device_node *dn, *np; struct device_node *ep = NULL; struct device_node *rparent = NULL; struct device_node *rport = NULL; @@ -175,17 +176,19 @@ struct coresight_platform_data *of_get_coresight_platform_data( } while (ep); } - /* Affinity defaults to CPU0 */ - pdata->cpu = 0; dn = of_parse_phandle(node, "cpu", 0); - for (cpu = 0; dn && cpu < nr_cpu_ids; cpu++) { - if (dn == of_get_cpu_node(cpu, NULL)) { - pdata->cpu = cpu; + for_each_possible_cpu(cpu) { + np = of_get_cpu_node(cpu, NULL); + found = (dn == np); + of_node_put(np); + if (found) break; - } } of_node_put(dn); + /* Affinity to CPU0 if no cpu nodes are found */ + pdata->cpu = found ? cpu : 0; + return pdata; } EXPORT_SYMBOL_GPL(of_get_coresight_platform_data);