From patchwork Tue Feb 14 04:05:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 93916 Delivered-To: patches@linaro.org Received: by 10.140.20.99 with SMTP id 90csp1388099qgi; Mon, 13 Feb 2017 20:05:46 -0800 (PST) X-Received: by 10.107.190.196 with SMTP id o187mr24764741iof.95.1487045146757; Mon, 13 Feb 2017 20:05:46 -0800 (PST) Return-Path: Received: from mail-it0-x236.google.com (mail-it0-x236.google.com. [2607:f8b0:4001:c0b::236]) by mx.google.com with ESMTPS id b196si12860264ioa.42.2017.02.13.20.05.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Feb 2017 20:05:46 -0800 (PST) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 2607:f8b0:4001:c0b::236 as permitted sender) client-ip=2607:f8b0:4001:c0b::236; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: domain of john.stultz@linaro.org designates 2607:f8b0:4001:c0b::236 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: by mail-it0-x236.google.com with SMTP id 203so17724207ith.0 for ; Mon, 13 Feb 2017 20:05:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=1VXW6zcNHWh99azOLrjO8C2urhvu7g5aya0fVljFJgk=; b=MyizbWWITVOoeo91Vq7WV1mFZezsBGLW2oZOZoQwi4r0cvZt+6MK6dVbEpP5CMcPYk pxDMCwG5W9pjfN8qOUw/J6THoHAz/ZCP+jaY5NNQgSO0Ofka9yx7kupuWfOBTw2tZ0nL qDAMjX6BI6C9/Hbj2bQVBJDx/dqgV9WQTXQWo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1VXW6zcNHWh99azOLrjO8C2urhvu7g5aya0fVljFJgk=; b=LZrkcpzbFPvCjqptgecD8QGSt0d06Hnxk0h0SmOAFuNc/H5wRIBAgioYxTxVMxZofk LLLSFBcuI/xasQOXynQKerB2b13HA8yus6p64Ab9nWY9+fDl+ISvSAg4gOcCrShTQqk1 V7o8Ljvv63LiDxUl7RASTYG8CzVCAiCHjIUxGBx4q4xaj+jyVtkIbjx4SdXlsR2TVZu7 Xkbae1/8LlFUsNOeCw6MfoBvDV2vJPCicsvk6lfMTqs96DxrcqD3DTznicK/cxLXYfqc g4/KkBVkge7TRiNTE91Ex5ZtCnN6F7ifClzc4ov6T7SJtuFqqqqC4hVns4Cx5zJsK5sH 99YA== X-Gm-Message-State: AMke39lMZuCy5BWJVVHrwXSk1JRkrqJ55HtgawPG6qLsT15Ee+D1Fknloh+CQCabnALN7pOvj0g= X-Received: by 10.99.55.91 with SMTP id g27mr30545517pgn.65.1487045146470; Mon, 13 Feb 2017 20:05:46 -0800 (PST) Return-Path: Received: from localhost.localdomain ([2601:1c2:1002:83f0:4e72:b9ff:fe99:466a]) by smtp.gmail.com with ESMTPSA id p25sm23509422pfd.0.2017.02.13.20.05.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 13 Feb 2017 20:05:45 -0800 (PST) From: John Stultz To: lkml Cc: John Stultz , Jarkko Nikula , Andy Shevchenko , Mika Westerberg , Wolfram Sang , linux-i2c@vger.kernel.org Subject: [PATCH v2] i2c: designwear: Fix clk warning on suspend/resume Date: Mon, 13 Feb 2017 20:05:42 -0800 Message-Id: <1487045142-1434-1-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 2.7.4 On my HiKey board, I'm seeing clk warnings on suspend/resume, which seem to be caused by runtime pm suspending the device, then the same suspend hook being called again on suspend time. This patch fixes this by setting the SYSTEM_SLEEP_PM_OPS to using pm_runtime_force_suspend and pm_runtime_force_resume. Cc: Jarkko Nikula Cc: Andy Shevchenko Cc: Mika Westerberg Cc: Wolfram Sang Cc: linux-i2c@vger.kernel.org Suggested-by: Jarkko Nikula Signed-off-by: John Stultz --- v2: Switch to suggested fix by Jarkko. drivers/i2c/busses/i2c-designware-platdrv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c index 6ce4313..09f27ec 100644 --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -362,7 +362,7 @@ static int dw_i2c_plat_resume(struct device *dev) static const struct dev_pm_ops dw_i2c_dev_pm_ops = { .prepare = dw_i2c_plat_prepare, .complete = dw_i2c_plat_complete, - SET_SYSTEM_SLEEP_PM_OPS(dw_i2c_plat_suspend, dw_i2c_plat_resume) + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume) SET_RUNTIME_PM_OPS(dw_i2c_plat_suspend, dw_i2c_plat_resume, NULL) };