From patchwork Fri Feb 3 09:54:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 93154 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp515449qgi; Fri, 3 Feb 2017 01:55:09 -0800 (PST) X-Received: by 10.99.140.77 with SMTP id q13mr16609878pgn.179.1486115709012; Fri, 03 Feb 2017 01:55:09 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1si25061752plm.58.2017.02.03.01.55.08; Fri, 03 Feb 2017 01:55:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753181AbdBCJyx (ORCPT + 25 others); Fri, 3 Feb 2017 04:54:53 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35936 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753038AbdBCJyu (ORCPT ); Fri, 3 Feb 2017 04:54:50 -0500 Received: by mail-wm0-f53.google.com with SMTP id c85so20218227wmi.1 for ; Fri, 03 Feb 2017 01:54:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fxGR1YG5KpKkqh3+63hx/c4j58cqgelrl1xhilCE+Bc=; b=MzoiFVRjvVvNmiC9y62EytGbecxeAj2N8/3xkth42FdxddZ5zv66h24XRcmsLCSbWW vfDgmVkw+CLOQNklRdmD6+IMW6mBupC18FjPo9+/oEP/k4bqJWGWl9GXTcXj+krhCXRE VZUtx3bzw1A6FVpOaLgN/WAd4spu5HAQ8LH+Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fxGR1YG5KpKkqh3+63hx/c4j58cqgelrl1xhilCE+Bc=; b=T0MeS0jLonr65l1y1MhqEaDSftxeGyQK4ziUIkcFKK0n+tpqJLb3wRpJpxYHLadYJq IgdZluhsKkdnbq0o60vMflqQhTmkcwdqyJ2cofy6qkfDFvlK4/buXH+J/z/8+sVfH6Sx slyXnLWdscLq94iLHFmqZk17+BR0J6wrz9w/75xod5lFZpfjbyFeFNxSHuVq0ZUtyKDb +uqq1wz0VFz+2mng6Z8LvjzHZkrPureDkKiYICa/dvlYa5HyJ2MDZv01Yk40zSfOwSVN vCUxFWJsLfnxDQPI/5gGRRN3shuuWfsswo/YKx8+lI/YCLt4rxlRLbd1u4ldtpU3tB5P 3UtA== X-Gm-Message-State: AMke39nwNXyIO98Q00vic5bm4xY3rrelLwAEryBT2imobEVHHmXw7Gq8A4ah+w6+a4FmKDtb X-Received: by 10.28.20.209 with SMTP id 200mr619358wmu.64.1486115679238; Fri, 03 Feb 2017 01:54:39 -0800 (PST) Received: from localhost.localdomain ([105.130.17.13]) by smtp.gmail.com with ESMTPSA id l67sm2144562wmf.1.2017.02.03.01.54.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 03 Feb 2017 01:54:38 -0800 (PST) From: Ard Biesheuvel To: linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, jeyu@redhat.com, rusty@rustcorp.com.au, mmarek@suse.com, mpe@ellerman.id.au Cc: torvalds@linux-foundation.org, arnd@arndb.de, viro@zeniv.linux.org.uk, linux-arm-kernel@lists.infradead.org, Ard Biesheuvel Subject: [PATCH v5 3/3] module: unify absolute krctab definitions for 32-bit and 64-bit Date: Fri, 3 Feb 2017 09:54:07 +0000 Message-Id: <1486115647-27680-4-git-send-email-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1486115647-27680-1-git-send-email-ard.biesheuvel@linaro.org> References: <1486115647-27680-1-git-send-email-ard.biesheuvel@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The previous patch introduced a separate inline asm version of the krcrctab declaration template for use with 64-bit architectures, which cannot refer to ELF symbols using 32-bit quantities. This declaration should be equivalent to the C one for 32-bit architectures, but this needs to be checked first, so unify them in a separate patch. Signed-off-by: Ard Biesheuvel --- ... which can simply be dropped if it turns out to break anything. include/linux/export.h | 7 ------- 1 file changed, 7 deletions(-) -- 2.7.4 diff --git a/include/linux/export.h b/include/linux/export.h index 7473fba6a60c..1a1dfdb2a5c6 100644 --- a/include/linux/export.h +++ b/include/linux/export.h @@ -49,13 +49,6 @@ extern struct module __this_module; " .weak " VMLINUX_SYMBOL_STR(__crc_##sym) " \n" \ " .long " VMLINUX_SYMBOL_STR(__crc_##sym) " - . \n" \ " .previous \n"); -#elif !defined(CONFIG_64BIT) -#define __CRC_SYMBOL(sym, sec) \ - extern __visible void *__crc_##sym __attribute__((weak)); \ - static const unsigned long __kcrctab_##sym \ - __used \ - __attribute__((section("___kcrctab" sec "+" #sym), used)) \ - = (unsigned long) &__crc_##sym; #else #define __CRC_SYMBOL(sym, sec) \ asm(" .section \"___kcrctab" sec "+" #sym "\", \"a\" \n" \