From patchwork Wed Feb 1 08:27:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 93005 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp2309519qgi; Wed, 1 Feb 2017 00:28:34 -0800 (PST) X-Received: by 10.84.132.1 with SMTP id 1mr2602437ple.44.1485937714303; Wed, 01 Feb 2017 00:28:34 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u64si13728200pgc.340.2017.02.01.00.28.33; Wed, 01 Feb 2017 00:28:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751597AbdBAI2c (ORCPT + 25 others); Wed, 1 Feb 2017 03:28:32 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:63818 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbdBAI2b (ORCPT ); Wed, 1 Feb 2017 03:28:31 -0500 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by fllnx209.ext.ti.com (8.15.1/8.15.1) with ESMTP id v118Rv1b015102; Wed, 1 Feb 2017 02:27:57 -0600 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id v118RqGG013757; Wed, 1 Feb 2017 02:27:52 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.3.294.0; Wed, 1 Feb 2017 02:27:52 -0600 Received: from a0393678ub.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id v118RkKp012506; Wed, 1 Feb 2017 02:27:48 -0600 From: Kishon Vijay Abraham I To: CC: , , Stephen Boyd Subject: [PATCH] phy: qcom-usb-hs: Add depends on EXTCON Date: Wed, 1 Feb 2017 13:57:44 +0530 Message-ID: <1485937664-25545-1-git-send-email-kishon@ti.com> X-Mailer: git-send-email 1.7.9.5 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org commit e2427b09ba929c2b9 (phy: Add support for Qualcomm's USB HS phy") while using extcon API's in qcom-usb-hs failed to add 'depends on EXTCON' resulting in the following compile errors if EXTCON is not enabled. drivers/built-in.o: In function `qcom_usb_hs_phy_power_off': phy-qcom-usb-hs.c:(.text+0x1089): undefined reference to `extcon_unregister_notifier' drivers/built-in.o: In function `qcom_usb_hs_phy_probe': phy-qcom-usb-hs.c:(.text+0x11b5): undefined reference to `extcon_get_edev_by_phandle' drivers/built-in.o: In function `qcom_usb_hs_phy_power_on': phy-qcom-usb-hs.c:(.text+0x128e): undefined reference to `extcon_get_state' phy-qcom-usb-hs.c:(.text+0x12a9): undefined reference to `extcon_register_notifier' Fix it here. Fixes: 9994a33865f4 e2427b09ba929c2b9 (phy: Add support for Qualcomm's USB HS phy") Cc: Stephen Boyd Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 1.7.9.5 diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index bb5cf6f..c11aba6 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -440,6 +440,7 @@ config PHY_QCOM_UFS config PHY_QCOM_USB_HS tristate "Qualcomm USB HS PHY module" + depends on EXTCON depends on USB_ULPI_BUS select GENERIC_PHY help