From patchwork Wed Jan 4 17:30:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 89889 Delivered-To: patch@linaro.org Received: by 10.182.224.138 with SMTP id rc10csp323570obc; Wed, 4 Jan 2017 09:56:13 -0800 (PST) X-Received: by 10.84.241.8 with SMTP id a8mr142707839pll.74.1483552573589; Wed, 04 Jan 2017 09:56:13 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y40si73205249pla.127.2017.01.04.09.56.13; Wed, 04 Jan 2017 09:56:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761441AbdADR4G (ORCPT + 25 others); Wed, 4 Jan 2017 12:56:06 -0500 Received: from foss.arm.com ([217.140.101.70]:55384 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761405AbdADR4B (ORCPT ); Wed, 4 Jan 2017 12:56:01 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0053315B2; Wed, 4 Jan 2017 09:30:20 -0800 (PST) Received: from e107155-lin.cambridge.arm.com (unknown [10.1.210.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id F3D393F242; Wed, 4 Jan 2017 09:30:18 -0800 (PST) From: Sudeep Holla To: linux-kernel@vger.kernel.org Cc: Sudeep Holla , Peter Zijlstra , Ingo Molnar , Jiri Olsa , Stephane Eranian Subject: [PATCH v3] tools: perf: fix linker error when libelf config is disabled Date: Wed, 4 Jan 2017 17:30:02 +0000 Message-Id: <1483551002-26501-1-git-send-email-sudeep.holla@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1483545363-11393-1-git-send-email-sudeep.holla@arm.com> References: <1483545363-11393-1-git-send-email-sudeep.holla@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When libelf is disabled in the configuration, we get the following linker error: LINK libperf-jvmti.so ld: cannot find -lelf Makefile.perf:515: recipe for target 'libperf-jvmti.so' failed Jiri pointed out that both librt and libelf are not really required. So this patch fixes the linker error by getting rid of unwanted libraries in the linker stage. Fixes: 209045adc2bb ("perf tools: add JVMTI agent library") Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Jiri Olsa Cc: Stephane Eranian Signed-off-by: Sudeep Holla --- tools/perf/Makefile.perf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) v2->v3: - Corrected the original commit under "Fixes:" tag that introduced the libraries initially v1->v2: - Dropped libelf and librt as they are not required -- 2.7.4 diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index 8fc24824705e..9e4a7ea84637 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf @@ -512,7 +512,7 @@ $(LIBJVMTI_IN): FORCE $(Q)$(MAKE) -f $(srctree)/tools/build/Makefile.build dir=jvmti obj=jvmti $(OUTPUT)$(LIBJVMTI): $(LIBJVMTI_IN) - $(QUIET_LINK)$(CC) -shared -Wl,-soname -Wl,$(LIBJVMTI) -o $@ $< -lelf -lrt + $(QUIET_LINK)$(CC) -shared -Wl,-soname -Wl,$(LIBJVMTI) -o $@ $< endif $(patsubst perf-%,%.o,$(PROGRAMS)): $(wildcard */*.h)