From patchwork Tue Dec 13 07:09:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 87796 Delivered-To: patches@linaro.org Received: by 10.140.20.101 with SMTP id 92csp2060685qgi; Mon, 12 Dec 2016 23:09:57 -0800 (PST) X-Received: by 10.84.160.204 with SMTP id v12mr151932438plg.122.1481612997049; Mon, 12 Dec 2016 23:09:57 -0800 (PST) Return-Path: Received: from mail-pg0-x233.google.com (mail-pg0-x233.google.com. [2607:f8b0:400e:c05::233]) by mx.google.com with ESMTPS id 59si47056532pld.76.2016.12.12.23.09.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Dec 2016 23:09:57 -0800 (PST) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 2607:f8b0:400e:c05::233 as permitted sender) client-ip=2607:f8b0:400e:c05::233; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: domain of john.stultz@linaro.org designates 2607:f8b0:400e:c05::233 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by mail-pg0-x233.google.com with SMTP id x23so44735532pgx.1 for ; Mon, 12 Dec 2016 23:09:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Tq3CIlnGytS1CRKp2YXWDX8/et8dr5a9uhMEu9BuA20=; b=J3r9KLZ7n3mkaizVOHqP/ycnqhWeSDuIGc+iEzB9lNwPK002w7sm8pUdEzErEq0ToZ e7/8PCBHe9UVnjDonc2/6BHCJnfgPCREglCucovYxspuUsFXH3Cp3QWD/skgYqz38YRF KadMb2dwmP9R/CtMP1ydDZKpBDgaTOUoMuFL4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Tq3CIlnGytS1CRKp2YXWDX8/et8dr5a9uhMEu9BuA20=; b=Z0XVBxehzG7LVnnRHPPF351sUs6gCCNU20R1NTtzbi82gLYlStOTNQHbtXY5xn92JJ M0KHxZjxhAmEsssZTWILDBvOYilPrk69BFAQ5APPFxyC5VXdDhDK6n/FopmnAyh4IHdC F8AmSS9Fczp9WMgbVCiBP1PQiY9Hov2IOM6PFWzWUMrTVi5VXV+ROgU15RLe8muk1i0c BjyAC9kO5tCSWGV5Y/l6wgRRy8/td7zezyBcHMrsXovidgTIOPqmIJPGt2hLwrEuVwWh 0Wckdm9gFU9bPoWKqyyPY2P7g+hPqPbwsyK8AbKd5RCLfxLZtgpvCgJhT7eRLHYE8+G+ T3+g== X-Gm-Message-State: AKaTC01mvoVoN8/EqXyuvryZNbgXyKBKp8frs6Ug5FMw6HsWFfTSzu61cudzg7fnb3lFt5VD+7w= X-Received: by 10.99.176.14 with SMTP id h14mr174612703pgf.22.1481612996733; Mon, 12 Dec 2016 23:09:56 -0800 (PST) Return-Path: Received: from localhost.localdomain ([2601:1c2:1002:83f0:4e72:b9ff:fe99:466a]) by smtp.gmail.com with ESMTPSA id 13sm79190204pfz.30.2016.12.12.23.09.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 12 Dec 2016 23:09:56 -0800 (PST) From: John Stultz To: lkml Cc: Chen Yu , Wei Xu , Guodong Xu , Amit Pundir , Rob Herring , John Youn , Douglas Anderson , Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, John Stultz Subject: [RFC][PATCH 3/5] usb: dwc2: Force port resume on switching to device mode Date: Mon, 12 Dec 2016 23:09:48 -0800 Message-Id: <1481612990-23409-4-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1481612990-23409-1-git-send-email-john.stultz@linaro.org> References: <1481612990-23409-1-git-send-email-john.stultz@linaro.org> From: Chen Yu We've seen failures when switching between host and gadget mode, which was diagnosed as being caused due to the bus being auto-suspended when we switched. So this patch forces a port resume when switching to device mode if the bus is suspended. Cc: Wei Xu Cc: Guodong Xu Cc: Amit Pundir Cc: Rob Herring Cc: John Youn Cc: Douglas Anderson Cc: Chen Yu Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Signed-off-by: Chen Yu Signed-off-by: John Stultz --- drivers/usb/dwc2/hcd.c | 7 +++++++ 1 file changed, 7 insertions(+) -- 2.7.4 diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c index a3f34dd..24db997 100644 --- a/drivers/usb/dwc2/hcd.c +++ b/drivers/usb/dwc2/hcd.c @@ -54,6 +54,8 @@ #include "core.h" #include "hcd.h" +static void dwc2_port_resume(struct dwc2_hsotg *hsotg); + /* * ========================================================================= * Host Core Layer Functions @@ -3204,6 +3206,11 @@ static void dwc2_conn_id_status_change(struct work_struct *work) if (gotgctl & GOTGCTL_CONID_B) { /* Wait for switch to device mode */ dev_dbg(hsotg->dev, "connId B\n"); + if (hsotg->bus_suspended) { + dev_info(hsotg->dev, + "Do port resume before switching to device mode\n"); + dwc2_port_resume(hsotg); + } while (!dwc2_is_device_mode(hsotg)) { dev_info(hsotg->dev, "Waiting for Peripheral Mode, Mode=%s\n",