From patchwork Tue Nov 29 05:04:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 84493 Delivered-To: patches@linaro.org Received: by 10.140.20.101 with SMTP id 92csp1452314qgi; Mon, 28 Nov 2016 21:04:56 -0800 (PST) X-Received: by 10.98.19.137 with SMTP id 9mr12890207pft.150.1480395896197; Mon, 28 Nov 2016 21:04:56 -0800 (PST) Return-Path: Received: from mail-pf0-x235.google.com (mail-pf0-x235.google.com. [2607:f8b0:400e:c00::235]) by mx.google.com with ESMTPS id b82si58322407pfe.235.2016.11.28.21.04.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Nov 2016 21:04:56 -0800 (PST) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 2607:f8b0:400e:c00::235 as permitted sender) client-ip=2607:f8b0:400e:c00::235; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: domain of john.stultz@linaro.org designates 2607:f8b0:400e:c00::235 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by mail-pf0-x235.google.com with SMTP id 189so29443925pfz.3 for ; Mon, 28 Nov 2016 21:04:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=M38/EaiJWocAtTAGjLHd4fzwjBaU0J3nwZHbNTqsBrs=; b=RQqPIrvnLncKNoaoRYD0T6Omrbm5t2ngu9GVKYJ577bqDIL4Ux6wmKCY4b035eh1QS yggq6MyR3JUnDctsrcbfOVAzR9v2ystSKaX3rb9EGvAJ/ih5R6WLxzeqDtoTO3QNYke1 2EEsmwzrKu0dGZzid67X/Cun6vd+0jV4IB+eI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=M38/EaiJWocAtTAGjLHd4fzwjBaU0J3nwZHbNTqsBrs=; b=dJpOv80LdPQ2VJ/KPU+Ll8kDaqvvvixBK7z6EhXqYxYyz2XnQmC8BIW//Qim70/Xvg bwviZX+mXE/LVs/p5IKycn2CINWXPuMFyYJp+To12aA8iWAOGEks7oK2IivDiOXzsZoQ igj29NzNmPSYM3msaeaekpymkr0iQ7upDEfm4Tqlh3JT/qDYAQwZ4uKggswwxkV+nR4B Uw/5j9O2P/63YWygKv8Ag/znynZH8OKoT0ie7zj6i123a/fHx6zJmJNGG9Y+HUYhyMIW 1z+iuxebV6hlFuKHU/eQBscMcqelFLgD/iHLEn7w06MjeRG4n6Vf4y9pMFmeDhfNf+qq mchA== X-Gm-Message-State: AKaTC01VcGrsB4SImhWJ1u0PkVPaFwB3ru2Br4Eobcxpvu+Wnw2bYu0NYZOeCIPInPNubYhhXaY= X-Received: by 10.98.41.3 with SMTP id p3mr26288265pfp.22.1480395895907; Mon, 28 Nov 2016 21:04:55 -0800 (PST) Return-Path: Received: from localhost.localdomain ([2601:1c2:1002:83f0:4e72:b9ff:fe99:466a]) by smtp.gmail.com with ESMTPSA id b29sm73191498pgn.48.2016.11.28.21.04.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 28 Nov 2016 21:04:54 -0800 (PST) From: John Stultz To: lkml Cc: John Stultz , David Airlie , Archit Taneja , Wolfram Sang , Lars-Peter Clausen , Laurent Pinchart , dri-devel@lists.freedesktop.org Subject: [RFC][PATCH 4/5 v2] drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be reused internally Date: Mon, 28 Nov 2016 21:04:43 -0800 Message-Id: <1480395884-5471-5-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1480395884-5471-1-git-send-email-john.stultz@linaro.org> References: <1480395884-5471-1-git-send-email-john.stultz@linaro.org> In chasing down issues with EDID probing, I found some duplicated but incomplete logic used to power the chip on and off. This patch refactors the adv7511_power_on/off functions, so they can be used for internal needs. Cc: David Airlie Cc: Archit Taneja Cc: Wolfram Sang Cc: Lars-Peter Clausen Cc: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org Signed-off-by: John Stultz --- v2: Split into two patches to make change more clear drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) -- 2.7.4 diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index 9f8dffd..1948968 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -325,7 +325,7 @@ static void adv7511_set_link_config(struct adv7511 *adv7511, adv7511->rgb = config->input_colorspace == HDMI_COLORSPACE_RGB; } -static void adv7511_power_on(struct adv7511 *adv7511) +static void __adv7511_power_on(struct adv7511 *adv7511) { adv7511->current_edid_segment = -1; @@ -359,24 +359,30 @@ static void adv7511_power_on(struct adv7511 *adv7511) * Most of the registers are reset during power down or when HPD is low. */ regcache_sync(adv7511->regmap); +} +static void adv7511_power_on(struct adv7511 *adv7511) +{ + __adv7511_power_on(adv7511); if (adv7511->type == ADV7533) adv7533_dsi_power_on(adv7511); - adv7511->powered = true; } -static void adv7511_power_off(struct adv7511 *adv7511) +static void __adv7511_power_off(struct adv7511 *adv7511) { /* TODO: setup additional power down modes */ regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER, ADV7511_POWER_POWER_DOWN, ADV7511_POWER_POWER_DOWN); regcache_mark_dirty(adv7511->regmap); +} +static void adv7511_power_off(struct adv7511 *adv7511) +{ + __adv7511_power_off(adv7511); if (adv7511->type == ADV7533) adv7533_dsi_power_off(adv7511); - adv7511->powered = false; }