From patchwork Sat Nov 26 18:05:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 84272 Delivered-To: patch@linaro.org Received: by 10.140.20.101 with SMTP id 92csp541632qgi; Sat, 26 Nov 2016 10:08:44 -0800 (PST) X-Received: by 10.84.133.129 with SMTP id f1mr30450773plf.64.1480183724444; Sat, 26 Nov 2016 10:08:44 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 133si49340547pgh.252.2016.11.26.10.08.44; Sat, 26 Nov 2016 10:08:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753312AbcKZSIk (ORCPT + 25 others); Sat, 26 Nov 2016 13:08:40 -0500 Received: from conuserg-11.nifty.com ([210.131.2.78]:47890 "EHLO conuserg-11.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753109AbcKZSIK (ORCPT ); Sat, 26 Nov 2016 13:08:10 -0500 Received: from grover.sesame (FL1-111-169-71-157.osk.mesh.ad.jp [111.169.71.157]) (authenticated) by conuserg-11.nifty.com with ESMTP id uAQI6Ueh018512; Sun, 27 Nov 2016 03:06:42 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com uAQI6Ueh018512 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1480183602; bh=y3L8a9BHg+doASOuySx/rZWhYIAkZryEHoq9UzpfNys=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ok/3U3vHl7Nhtodfr8fhkIJe7Pf2k3N71hZOXvUmVj/Reeab54v7PGlEu+URlvaX5 d/GAqAN+XVlV4uHnrG4SBhPIk6HM/bvfz63b1ttmTWtElhvLNw3UZ/XNmjBoON4E7n 6nkNRbu/WlqpAUkgslFJT+PyUkBJfPBS44PPunnQ1ihxBAYdTyBdTM3adPg7rVN1Bs dA+R7swf4m2YjWgl6sX15f+HBKbAeTZYicsBHvp4uCSbJM6rRXY+p+olrRibCPXm2P WH+Pw5W4xinMlE4VePRDzKUqMU936JrhZ4RH3kBS7SS1LSG5YsQeCLIK33RjdfaTAl DT/i3XlbAFEPQ== X-Nifty-SrcIP: [111.169.71.157] From: Masahiro Yamada To: linux-mtd@lists.infradead.org Cc: Masahiro Yamada , linux-kernel@vger.kernel.org, Boris Brezillon , Marek Vasut , Brian Norris , Richard Weinberger , David Woodhouse , Cyrille Pitchen Subject: [PATCH 11/39] mtd: nand: denali: increment ecc_stats.failed by one per error Date: Sun, 27 Nov 2016 03:05:57 +0900 Message-Id: <1480183585-592-12-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1480183585-592-1-git-send-email-yamada.masahiro@socionext.com> References: <1480183585-592-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the addressed page is not erased, the two calls of is_erase() will both return false, then mtd->ecc_stats.failed will be incremented by two. Rather, increment it by one because the whole page including OOB area is transferred in one transaction. Signed-off-by: Masahiro Yamada --- drivers/mtd/nand/denali.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.7.4 diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c index ab59371..ae9a8d2 100644 --- a/drivers/mtd/nand/denali.c +++ b/drivers/mtd/nand/denali.c @@ -1157,9 +1157,8 @@ static int denali_read_page(struct mtd_info *mtd, struct nand_chip *chip, read_oob_data(mtd, chip->oob_poi, denali->page); /* check ECC failures that may have occurred on erased pages */ - if (!is_erased(buf, mtd->writesize)) - mtd->ecc_stats.failed++; - if (!is_erased(chip->oob_poi, mtd->oobsize)) + if (!is_erased(buf, mtd->writesize) || + !is_erased(chip->oob_poi, mtd->oobsize)) mtd->ecc_stats.failed++; } return max_bitflips;