From patchwork Mon Nov 21 06:08:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Binoy Jayan X-Patchwork-Id: 83177 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp1324878qge; Sun, 20 Nov 2016 22:09:39 -0800 (PST) X-Received: by 10.13.225.132 with SMTP id k126mr11885790ywe.40.1479708579837; Sun, 20 Nov 2016 22:09:39 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d60si4308884ybi.179.2016.11.20.22.09.39; Sun, 20 Nov 2016 22:09:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753429AbcKUGJ0 (ORCPT + 26 others); Mon, 21 Nov 2016 01:09:26 -0500 Received: from mail-pf0-f169.google.com ([209.85.192.169]:33328 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753336AbcKUGJY (ORCPT ); Mon, 21 Nov 2016 01:09:24 -0500 Received: by mail-pf0-f169.google.com with SMTP id d2so62632321pfd.0 for ; Sun, 20 Nov 2016 22:09:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=uLjuINtHgICLO9259r45vW1Rqw6zXT1FFBSm0l7MMQc=; b=kUhaOIp529Xr966lTJ9SRNQ5j2jfi2DwLCzZAzaDckstDLTn+xZpnS7lYWLRhEWvl8 ASUObMd9+UCfsEPrcDDkJUMU8HyuKaBvlVUVEQfdxa9vuFmyLgspYIGgOEhyOMVlYLvq r+zUNvpqgAW5fu4MQcH3PM3272tuZGhYc6u1o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=uLjuINtHgICLO9259r45vW1Rqw6zXT1FFBSm0l7MMQc=; b=gDEqHybiBpMz1SvAq0V4Fm/dfhMFbGtzU+4yKSZzyE0/hWaCOmB+TvCLDCCS59q3KW UWIRO4OM0E4WGqyuchdR0sR7LzJkSbLidFFQJkMOGH+9AqfK6h8Fj0/j3SR41BuNEtGi 0T22zGpBVzy0oxTcAZ4EZTPK13ZCIKPuujpwCCroNrtOfKvu5Je7HncOcP7sBNA8ST84 PQiNf+xCJKJjAbJwK2Exq9hfvn6EtR5LMm0Qg8WEaYAcQaq1RyGgxqgZrHd478I37/T2 YSeVBDbWp9jRQ/p0G/0kpOyCfGWfeqjLoiMRr+4KwqfD8ELJWuzUiR3EDjBgAOW06XJS tktA== X-Gm-Message-State: AKaTC03/5cIRMMgaOJWatRvi1l7/mWexGUqxVz92EMkERP4bRzj2e6fFOJ/1bmwjHp61fAY+ X-Received: by 10.98.23.88 with SMTP id 85mr15803506pfx.21.1479708563298; Sun, 20 Nov 2016 22:09:23 -0800 (PST) Received: from blr-ubuntu-59.ap.qualcomm.com ([202.46.23.61]) by smtp.gmail.com with ESMTPSA id 74sm16068432pge.2.2016.11.20.22.09.16 (version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 20 Nov 2016 22:09:22 -0800 (PST) From: Binoy Jayan To: Doug Ledford , Sean Hefty , Sagi Grimberg , Hal Rosenstock , Leon Romanovsky , Sagi Grimberg , Bart Van Assche , Nicholas Bellinger , Jenny Derzhavetz , Ira Weiny , Steve Wise , Mark Bloch , Tatyana E Nikolova , Matan Barak , Lijun Ou , "Wei Hu(Xavier)" Cc: Faisal Latif , Mustafa Ismail , Mark Brown , Arnd Bergmann , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, target-devel@vger.kernel.org, Binoy Jayan Subject: [PATCH v5 6/9] IB/hns: Replace counting semaphore event_sem with wait_event Date: Mon, 21 Nov 2016 11:38:13 +0530 Message-Id: <1479708496-9828-7-git-send-email-binoy.jayan@linaro.org> X-Mailer: git-send-email 1.8.2.1 In-Reply-To: <1479708496-9828-1-git-send-email-binoy.jayan@linaro.org> References: <1479708496-9828-1-git-send-email-binoy.jayan@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Counting semaphores are going away in the future, so replace the semaphore mthca_cmd::event_sem with a conditional wait_event. Signed-off-by: Binoy Jayan --- drivers/infiniband/hw/hns/hns_roce_cmd.c | 46 ++++++++++++++++++++--------- drivers/infiniband/hw/hns/hns_roce_device.h | 2 +- 2 files changed, 33 insertions(+), 15 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project diff --git a/drivers/infiniband/hw/hns/hns_roce_cmd.c b/drivers/infiniband/hw/hns/hns_roce_cmd.c index 51a0675..12ef3d8 100644 --- a/drivers/infiniband/hw/hns/hns_roce_cmd.c +++ b/drivers/infiniband/hw/hns/hns_roce_cmd.c @@ -189,6 +189,34 @@ void hns_roce_cmd_event(struct hns_roce_dev *hr_dev, u16 token, u8 status, complete(&context->done); } +static inline struct hns_roce_cmd_context * +hns_roce_try_get_context(struct hns_roce_cmdq *cmd) +{ + struct hns_roce_cmd_context *context = NULL; + + spin_lock(&cmd->context_lock); + + if (cmd->free_head < 0) + goto out; + + context = &cmd->context[cmd->free_head]; + context->token += cmd->token_mask + 1; + cmd->free_head = context->next; +out: + spin_unlock(&cmd->context_lock); + return context; +} + +/* wait for and acquire a free context */ +static inline struct hns_roce_cmd_context * +hns_roce_get_free_context(struct hns_roce_cmdq *cmd) +{ + struct hns_roce_cmd_context *context; + + wait_event(cmd->wq, (context = hns_roce_try_get_context(cmd))); + return context; +} + /* this should be called with "use_events" */ static int __hns_roce_cmd_mbox_wait(struct hns_roce_dev *hr_dev, u64 in_param, u64 out_param, unsigned long in_modifier, @@ -200,13 +228,7 @@ static int __hns_roce_cmd_mbox_wait(struct hns_roce_dev *hr_dev, u64 in_param, struct hns_roce_cmd_context *context; int ret = 0; - spin_lock(&cmd->context_lock); - WARN_ON(cmd->free_head < 0); - context = &cmd->context[cmd->free_head]; - context->token += cmd->token_mask + 1; - cmd->free_head = context->next; - spin_unlock(&cmd->context_lock); - + context = hns_roce_get_free_context(cmd); init_completion(&context->done); ret = hns_roce_cmd_mbox_post_hw(hr_dev, in_param, out_param, @@ -238,6 +260,7 @@ static int __hns_roce_cmd_mbox_wait(struct hns_roce_dev *hr_dev, u64 in_param, context->next = cmd->free_head; cmd->free_head = context - cmd->context; spin_unlock(&cmd->context_lock); + wake_up(&cmd->wq); return ret; } @@ -248,10 +271,8 @@ static int hns_roce_cmd_mbox_wait(struct hns_roce_dev *hr_dev, u64 in_param, { int ret = 0; - down(&hr_dev->cmd.event_sem); ret = __hns_roce_cmd_mbox_wait(hr_dev, in_param, out_param, in_modifier, op_modifier, op, timeout); - up(&hr_dev->cmd.event_sem); return ret; } @@ -313,7 +334,7 @@ int hns_roce_cmd_use_events(struct hns_roce_dev *hr_dev) hr_cmd->context[hr_cmd->max_cmds - 1].next = -1; hr_cmd->free_head = 0; - sema_init(&hr_cmd->event_sem, hr_cmd->max_cmds); + init_waitqueue_head(&hr_cmd->wq); spin_lock_init(&hr_cmd->context_lock); hr_cmd->token_mask = CMD_TOKEN_MASK; @@ -325,12 +346,9 @@ int hns_roce_cmd_use_events(struct hns_roce_dev *hr_dev) void hns_roce_cmd_use_polling(struct hns_roce_dev *hr_dev) { struct hns_roce_cmdq *hr_cmd = &hr_dev->cmd; - int i; hr_cmd->use_events = 0; - - for (i = 0; i < hr_cmd->max_cmds; ++i) - down(&hr_cmd->event_sem); + hr_cmd->free_head = -1; kfree(hr_cmd->context); } diff --git a/drivers/infiniband/hw/hns/hns_roce_device.h b/drivers/infiniband/hw/hns/hns_roce_device.h index 2afe075..ac95f52 100644 --- a/drivers/infiniband/hw/hns/hns_roce_device.h +++ b/drivers/infiniband/hw/hns/hns_roce_device.h @@ -364,7 +364,7 @@ struct hns_roce_cmdq { * Event mode: cmd register mutex protection, * ensure to not exceed max_cmds and user use limit region */ - struct semaphore event_sem; + wait_queue_head_t wq; int max_cmds; spinlock_t context_lock; int free_head;