From patchwork Wed Nov 16 16:39:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 82561 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp252721qge; Wed, 16 Nov 2016 08:39:52 -0800 (PST) X-Received: by 10.99.133.200 with SMTP id u191mr10161184pgd.28.1479314392913; Wed, 16 Nov 2016 08:39:52 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l65si32566941pge.112.2016.11.16.08.39.52; Wed, 16 Nov 2016 08:39:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752278AbcKPQjj (ORCPT + 26 others); Wed, 16 Nov 2016 11:39:39 -0500 Received: from foss.arm.com ([217.140.101.70]:58486 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752605AbcKPQjf (ORCPT ); Wed, 16 Nov 2016 11:39:35 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 962221597; Wed, 16 Nov 2016 08:39:34 -0800 (PST) Received: from e107155-lin.cambridge.arm.com (unknown [10.1.210.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 91C073F218; Wed, 16 Nov 2016 08:39:33 -0800 (PST) From: Sudeep Holla To: linuxppc-dev@lists.ozlabs.org Cc: Sudeep Holla , linux-kernel@vger.kernel.org, Scott Wood , Yangbo Lu , Arnd Bergmann Subject: [PATCH 2/2] soc: fsl: fix section mismatch build warnings Date: Wed, 16 Nov 2016 16:39:27 +0000 Message-Id: <1479314367-9169-2-git-send-email-sudeep.holla@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1479314367-9169-1-git-send-email-sudeep.holla@arm.com> References: <1479314367-9169-1-git-send-email-sudeep.holla@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get the following warning with the driver is compiled in: WARNING: modpost: Found 1 section mismatch(es). To see full details build your kernel with: 'make CONFIG_DEBUG_SECTION_MISMATCH=y' With CONFIG_DEBUG_SECTION_MISMATCH enabled, the details are reported: WARNING: vmlinux.o(.text+0x55d014): Section mismatch in reference from the function fsl_guts_probe() to the function .init.text:of_flat_dt_get_machine_name() The function fsl_guts_probe() references the function __init of_flat_dt_get_machine_name(). This is often because fsl_guts_probe lacks a __init annotation or the annotation of of_flat_dt_get_machine_name is wrong. This patch stashes the machine name during fsl_guts_init initcall to fix the above warnings. Cc: Scott Wood Cc: Yangbo Lu Cc: Arnd Bergmann Signed-off-by: Sudeep Holla --- drivers/soc/fsl/guts.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 Acked-by: Arnd Bergmann diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c index 885409d84eb2..5513a2b3448f 100644 --- a/drivers/soc/fsl/guts.c +++ b/drivers/soc/fsl/guts.c @@ -31,6 +31,7 @@ struct fsl_soc_die_attr { static struct guts *guts; static struct soc_device_attribute soc_dev_attr; static struct soc_device *soc_dev; +static const char *machine; /* SoC die attribute definition for QorIQ platform */ @@ -135,7 +136,6 @@ static int fsl_guts_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct resource *res; const struct fsl_soc_die_attr *soc_die; - const char *machine; u32 svr; /* Initialize guts */ @@ -151,7 +151,6 @@ static int fsl_guts_probe(struct platform_device *pdev) return PTR_ERR(guts->regs); /* Register soc device */ - machine = of_flat_dt_get_machine_name(); if (machine) soc_dev_attr.machine = devm_kstrdup(dev, machine, GFP_KERNEL); @@ -223,6 +222,7 @@ static struct platform_driver fsl_guts_driver = { static int __init fsl_guts_init(void) { + machine = of_flat_dt_get_machine_name(); return platform_driver_register(&fsl_guts_driver); } core_initcall(fsl_guts_init);