From patchwork Tue Oct 25 12:01:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Binoy Jayan X-Patchwork-Id: 79161 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp3072553qge; Tue, 25 Oct 2016 05:03:30 -0700 (PDT) X-Received: by 10.36.51.143 with SMTP id k137mr1405215itk.46.1477397010849; Tue, 25 Oct 2016 05:03:30 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z135si20358772pgz.214.2016.10.25.05.03.30; Tue, 25 Oct 2016 05:03:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758928AbcJYMDY (ORCPT + 27 others); Tue, 25 Oct 2016 08:03:24 -0400 Received: from mail-pf0-f177.google.com ([209.85.192.177]:34002 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758848AbcJYMCX (ORCPT ); Tue, 25 Oct 2016 08:02:23 -0400 Received: by mail-pf0-f177.google.com with SMTP id n85so2146031pfi.1 for ; Tue, 25 Oct 2016 05:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kX9fy6nztZSkwUDm3NFMtb7nSI5ui5OmCHQyRHXaKuk=; b=ea8r2xRxcxUDpDz6RocDGyvvBFIotX9LyI/5sUwgz6172EYa2E9brp3MbaYhE0uA8B DixQ0R/ovBK6zwDpno9hxlIxlUdD35Y3f4RFxXjgrOdSmjjN6GqL1Yiw7KsCZTDAYQQV IubYhctFLtd4c6pF3dRs5WOVFo1WTjoS8O75Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kX9fy6nztZSkwUDm3NFMtb7nSI5ui5OmCHQyRHXaKuk=; b=YrSj6kDVtunHwnRbPPxVpi26VIyGihvohk7BZpbYB4Yvn2HADDNRk8XYpCCs0aNEsA XS1nk0249M4xPy4RB44lR18cAkBbOi5dqVQMCAVwS50KwcI8EzTtoLU42adNbn4Ztf9y Py3BXFbPAj3rJzhF7LmM7UqpNEj5HKLTfksQvTvrrzzEi3gpJuTxvLixGlBNIP1SjVGS YNROweC8pXKbsn0t4XykEi4tZlZWsMgJEoXcHRGnaDxgxpTVyqp+u8juzRCXJzxf+0Z+ Aj2QqctC1vDvKsepXE7toCeut68WW1LwH9HUB/n1XJ5X69o0fJmhUXCZYgOndQO0OLDF aFjQ== X-Gm-Message-State: ABUngvdHtwK77uTzMt+L3Bgnw7PRSZ04ACuDfAh/haISgdXjSlRbhLsUfrbeM84AX1cknJUi X-Received: by 10.98.16.203 with SMTP id 72mr38993395pfq.57.1477396943161; Tue, 25 Oct 2016 05:02:23 -0700 (PDT) Received: from blr-ubuntu-59.ap.qualcomm.com ([202.46.23.61]) by smtp.gmail.com with ESMTPSA id ij5sm33051828pab.2.2016.10.25.05.02.20 (version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 25 Oct 2016 05:02:22 -0700 (PDT) From: Binoy Jayan To: Doug Ledford , Sean Hefty , Hal Rosenstock Cc: Arnd Bergmann , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Binoy Jayan Subject: [PATCH v2 5/8] IB/isert: Replace semaphore sem with completion Date: Tue, 25 Oct 2016 17:31:56 +0530 Message-Id: <1477396919-27669-6-git-send-email-binoy.jayan@linaro.org> X-Mailer: git-send-email 1.8.2.1 In-Reply-To: <1477396919-27669-1-git-send-email-binoy.jayan@linaro.org> References: <1477396919-27669-1-git-send-email-binoy.jayan@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The semaphore 'sem' in isert_device is used as completion, so convert it to struct completion. Semaphores are going away in the future. Signed-off-by: Binoy Jayan --- drivers/infiniband/ulp/isert/ib_isert.c | 6 +++--- drivers/infiniband/ulp/isert/ib_isert.h | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c index 6dd43f6..de80f56 100644 --- a/drivers/infiniband/ulp/isert/ib_isert.c +++ b/drivers/infiniband/ulp/isert/ib_isert.c @@ -619,7 +619,7 @@ mutex_unlock(&isert_np->mutex); isert_info("np %p: Allow accept_np to continue\n", isert_np); - up(&isert_np->sem); + complete(&isert_np->comp); } static void @@ -2311,7 +2311,7 @@ struct rdma_cm_id * isert_err("Unable to allocate struct isert_np\n"); return -ENOMEM; } - sema_init(&isert_np->sem, 0); + init_completion(&isert_np->comp); mutex_init(&isert_np->mutex); INIT_LIST_HEAD(&isert_np->accepted); INIT_LIST_HEAD(&isert_np->pending); @@ -2427,7 +2427,7 @@ struct rdma_cm_id * int ret; accept_wait: - ret = down_interruptible(&isert_np->sem); + ret = wait_for_completion_interruptible(&isert_np->comp); if (ret) return -ENODEV; diff --git a/drivers/infiniband/ulp/isert/ib_isert.h b/drivers/infiniband/ulp/isert/ib_isert.h index c02ada5..a1277c0 100644 --- a/drivers/infiniband/ulp/isert/ib_isert.h +++ b/drivers/infiniband/ulp/isert/ib_isert.h @@ -3,6 +3,7 @@ #include #include #include +#include #include #include @@ -190,7 +191,7 @@ struct isert_device { struct isert_np { struct iscsi_np *np; - struct semaphore sem; + struct completion comp; struct rdma_cm_id *cm_id; struct mutex mutex; struct list_head accepted;