From patchwork Tue Oct 25 12:01:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Binoy Jayan X-Patchwork-Id: 79155 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp3072102qge; Tue, 25 Oct 2016 05:02:49 -0700 (PDT) X-Received: by 10.99.125.68 with SMTP id m4mr2063702pgn.58.1477396969071; Tue, 25 Oct 2016 05:02:49 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u71si14105402pgd.117.2016.10.25.05.02.48; Tue, 25 Oct 2016 05:02:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758801AbcJYMCU (ORCPT + 27 others); Tue, 25 Oct 2016 08:02:20 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:35705 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758762AbcJYMCO (ORCPT ); Tue, 25 Oct 2016 08:02:14 -0400 Received: by mail-pf0-f178.google.com with SMTP id s8so118642530pfj.2 for ; Tue, 25 Oct 2016 05:02:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Jeu6Jnqyl08TQPobweVY36uuvACe4t8cliSLt1dX6Is=; b=P+WGqDIIqXGqQBdQqS3uiTWCb/ux4BnkgTNe+1tr1S8x2nd0X1Re1TkBQZMK3A5B7b jwI4+s348/TDyZHJt0JmMdLiFbhHpS6LxYtZx5CtXRLBXMk5+ahz55BTpeX7MoWLhXgU A56FJ5ayCd3A8fVlx13lFs8Y2pdlHhoSGOL6U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Jeu6Jnqyl08TQPobweVY36uuvACe4t8cliSLt1dX6Is=; b=ltDNPUGPnR27fKgsbcyLYb9oEywCC3kKcQoqGlJC5geOriDioFhfzKPGSYzEDxgnky VY2iRae79/ibP4POnmmy8l/oQuzfBuAE1Y9EepQrLK6YPlVVn+/AHF30O/Ihaaj637xU 0LPCRbbVsK9WndBtxxb/aDZJRRt+4FZjAXYd0q8wnnRAUWxH9Z5MzcksOzzMlYeKYKce RzMkH56XWLjDyRRxCUbKC+MMDkwn4oavOe9q1d/jsoOqcwBVj4cAeUqOPbD3/d6gD8XN Qd2lXmJ86i6OWllOoYa3mRxoZBoV+GM2POPXTfePvSfsQ2tmG0MBYrl2kVvxRhLCm1a0 72cQ== X-Gm-Message-State: ABUngvdLkny1wDQXGU+/hHrdTT2MFABOgshEjKDD/ziTWGTafAhQPUMdUURP4Juqdd7ejs2D X-Received: by 10.99.178.6 with SMTP id x6mr21683586pge.139.1477396933733; Tue, 25 Oct 2016 05:02:13 -0700 (PDT) Received: from blr-ubuntu-59.ap.qualcomm.com ([202.46.23.61]) by smtp.gmail.com with ESMTPSA id ij5sm33051828pab.2.2016.10.25.05.02.10 (version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 25 Oct 2016 05:02:13 -0700 (PDT) From: Binoy Jayan To: Doug Ledford , Sean Hefty , Hal Rosenstock Cc: Arnd Bergmann , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Binoy Jayan Subject: [PATCH v2 2/8] IB/core: Replace semaphore sm_sem with completion Date: Tue, 25 Oct 2016 17:31:53 +0530 Message-Id: <1477396919-27669-3-git-send-email-binoy.jayan@linaro.org> X-Mailer: git-send-email 1.8.2.1 In-Reply-To: <1477396919-27669-1-git-send-email-binoy.jayan@linaro.org> References: <1477396919-27669-1-git-send-email-binoy.jayan@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The semaphore 'sm_sem' is used as completion, so convert it to struct completion. Semaphores are going away in the future. The initial status of the completion variable is marked as completed by a call to the function 'complete' immediately following the initialization. Signed-off-by: Binoy Jayan --- drivers/infiniband/core/user_mad.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project diff --git a/drivers/infiniband/core/user_mad.c b/drivers/infiniband/core/user_mad.c index 415a318..df070cc 100644 --- a/drivers/infiniband/core/user_mad.c +++ b/drivers/infiniband/core/user_mad.c @@ -47,6 +47,7 @@ #include #include #include +#include #include #include @@ -87,7 +88,7 @@ struct ib_umad_port { struct cdev sm_cdev; struct device *sm_dev; - struct semaphore sm_sem; + struct completion sm_comp; struct mutex file_mutex; struct list_head file_list; @@ -1030,12 +1031,12 @@ static int ib_umad_sm_open(struct inode *inode, struct file *filp) port = container_of(inode->i_cdev, struct ib_umad_port, sm_cdev); if (filp->f_flags & O_NONBLOCK) { - if (down_trylock(&port->sm_sem)) { + if (!try_wait_for_completion(&port->sm_comp)) { ret = -EAGAIN; goto fail; } } else { - if (down_interruptible(&port->sm_sem)) { + if (wait_for_completion_interruptible(&port->sm_comp)) { ret = -ERESTARTSYS; goto fail; } @@ -1060,7 +1061,7 @@ static int ib_umad_sm_open(struct inode *inode, struct file *filp) ib_modify_port(port->ib_dev, port->port_num, 0, &props); err_up_sem: - up(&port->sm_sem); + complete(&port->sm_comp); fail: return ret; @@ -1079,7 +1080,7 @@ static int ib_umad_sm_close(struct inode *inode, struct file *filp) ret = ib_modify_port(port->ib_dev, port->port_num, 0, &props); mutex_unlock(&port->file_mutex); - up(&port->sm_sem); + complete(&port->sm_comp); kobject_put(&port->umad_dev->kobj); @@ -1177,7 +1178,8 @@ static int ib_umad_init_port(struct ib_device *device, int port_num, port->ib_dev = device; port->port_num = port_num; - sema_init(&port->sm_sem, 1); + init_completion(&port->sm_comp); + complete(&port->sm_comp); mutex_init(&port->file_mutex); INIT_LIST_HEAD(&port->file_list);