From patchwork Thu Oct 20 09:36:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Binoy Jayan X-Patchwork-Id: 78466 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp684109qge; Thu, 20 Oct 2016 02:36:44 -0700 (PDT) X-Received: by 10.99.123.1 with SMTP id w1mr6700878pgc.155.1476956204255; Thu, 20 Oct 2016 02:36:44 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r76si44239132pfd.247.2016.10.20.02.36.42; Thu, 20 Oct 2016 02:36:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758521AbcJTJgj (ORCPT + 27 others); Thu, 20 Oct 2016 05:36:39 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:35846 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754940AbcJTJgh (ORCPT ); Thu, 20 Oct 2016 05:36:37 -0400 Received: by mail-pf0-f178.google.com with SMTP id e6so33356858pfk.3 for ; Thu, 20 Oct 2016 02:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=QF18Gd75iN4N14DTKuladuJw1xGMI3FiQz+pOaX6uiM=; b=IDoia/bJ0aHXDnFJe4GIGoNN9+acRKQTFG/PgnY9Qo31YxYIdTJNcy5cU4dgz/hI7I X5vsqk3YJnft4OVu13M9+LH+CP/zquieE/pm3d736MW6Z32IXfHdOrzbNCgVHQ9IBTn1 fN754v3bFh1GRjBuQNp04TKQJQug1GK1K2Pks= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=QF18Gd75iN4N14DTKuladuJw1xGMI3FiQz+pOaX6uiM=; b=D69mmlzZnmfarCsznn0NNA0ab/P9uhtVzZ1MjL3zs331xB3v6MqH92Pl//zUpkANDA MiufJIYsskcyt9LruHL9aV5BzaWERTFVdzB3jq7HlqeYuxQ44joJU7g7GchDvXxGDcFZ QItTbqoa/IuGNKMRB9Rj8CgWDZ1gdka1V45vvIJRfJoCIRqdAATMuzrboVEHt8xYy6iE QarepwndOUmATtT/khFPCvqx61AOgiOBjycANlaFFuZbQJFmI8+elFjXCK3f/cqFZCiU cBd8PK6S1j31Z9NnXoPLGo5vjaY4UQ4sXQD/R0afb4SsAftBThlb7A8s9KcJ1DkzThxc 0xzw== X-Gm-Message-State: AA6/9RlF8oVaOxPGtZ/tlu/++w6D5+sl/o/lVUGQJzlLWkoDzdYyiLd/Mjfzf9V7+K92l51s X-Received: by 10.98.76.7 with SMTP id z7mr19646270pfa.143.1476956197233; Thu, 20 Oct 2016 02:36:37 -0700 (PDT) Received: from blr-ubuntu-59.ap.qualcomm.com ([202.46.23.61]) by smtp.gmail.com with ESMTPSA id t5sm40111413pfb.58.2016.10.20.02.36.34 (version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 20 Oct 2016 02:36:36 -0700 (PDT) From: Binoy Jayan To: Greg Kroah-Hartman , Aditya Shankar , Ganesh Krishna Cc: Arnd Bergmann , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Binoy Jayan Subject: [PATCH v2] staging: wilc1000: Remove unused function wilc_lock_timeout Date: Thu, 20 Oct 2016 15:06:30 +0530 Message-Id: <1476956190-7507-1-git-send-email-binoy.jayan@linaro.org> X-Mailer: git-send-email 1.8.2.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Semaphore are going away in the future, so remove the unused function wilc_lock_timeout which calls a semaphore api but has no users. Signed-off-by: Binoy Jayan Reviewed-by: Arnd Bergmann --- They following is a patch [v2] which removes semaphores from wilc1000. Its part of a bigger effort to eliminate all semaphores from the linux kernel. Arnd, Thank you for reviewing. Removed the prototype as well. drivers/staging/wilc1000/linux_wlan.c | 11 ----------- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 - 2 files changed, 12 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index 6370a5e..470d59f 100644 --- a/drivers/staging/wilc1000/linux_wlan.c +++ b/drivers/staging/wilc1000/linux_wlan.c @@ -218,17 +218,6 @@ static void deinit_irq(struct net_device *dev) } } -int wilc_lock_timeout(struct wilc *nic, void *vp, u32 timeout) -{ - /* FIXME: replace with mutex_lock or wait_for_completion */ - int error = -1; - - if (vp) - error = down_timeout(vp, - msecs_to_jiffies(timeout)); - return error; -} - void wilc_mac_indicate(struct wilc *wilc, int flag) { int status; diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.h b/drivers/staging/wilc1000/wilc_wfi_netdevice.h index ec6b167..d431673 100644 --- a/drivers/staging/wilc1000/wilc_wfi_netdevice.h +++ b/drivers/staging/wilc1000/wilc_wfi_netdevice.h @@ -225,7 +225,6 @@ struct WILC_WFI_mon_priv { void wilc_frmw_to_linux(struct wilc *wilc, u8 *buff, u32 size, u32 pkt_offset); void wilc_mac_indicate(struct wilc *wilc, int flag); -int wilc_lock_timeout(struct wilc *wilc, void *, u32 timeout); void wilc_netdev_cleanup(struct wilc *wilc); int wilc_netdev_init(struct wilc **wilc, struct device *, int io_type, int gpio, const struct wilc_hif_func *ops);