From patchwork Wed Oct 12 16:00:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Loic Pallardy X-Patchwork-Id: 77572 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp530459qge; Wed, 12 Oct 2016 09:55:21 -0700 (PDT) X-Received: by 10.98.19.208 with SMTP id 77mr3259026pft.102.1476291321101; Wed, 12 Oct 2016 09:55:21 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 2si10218359pfw.51.2016.10.12.09.55.20; Wed, 12 Oct 2016 09:55:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755925AbcJLQy7 (ORCPT + 27 others); Wed, 12 Oct 2016 12:54:59 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:46871 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755895AbcJLQyq (ORCPT ); Wed, 12 Oct 2016 12:54:46 -0400 Received: from pps.filterd (m0046037.ppops.net [127.0.0.1]) by m0046037.ppops.net (8.16.0.11/8.16.0.11) with SMTP id u9CFxPwI024454; Wed, 12 Oct 2016 18:01:16 +0200 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-.pphosted.com with ESMTP id 2615cu5d5s-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 12 Oct 2016 18:01:16 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 1454C34; Wed, 12 Oct 2016 16:01:16 +0000 (GMT) Received: from Webmail-eu.st.com (Safex1hubcas22.st.com [10.75.90.92]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id ECB5D2AB4; Wed, 12 Oct 2016 16:01:15 +0000 (GMT) Received: from localhost (10.201.23.23) by Webmail-ga.st.com (10.75.90.48) with Microsoft SMTP Server (TLS) id 14.3.279.2; Wed, 12 Oct 2016 18:01:15 +0200 From: Loic Pallardy To: , , CC: , , , Subject: [PATCH v3 11/20] remoteproc: core: Correction carveout name comparison in rproc_update_resource_table_entry Date: Wed, 12 Oct 2016 18:00:29 +0200 Message-ID: <1476288038-24909-12-git-send-email-loic.pallardy@st.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1476288038-24909-1-git-send-email-loic.pallardy@st.com> References: <1476288038-24909-1-git-send-email-loic.pallardy@st.com> MIME-Version: 1.0 X-Originating-IP: [10.201.23.23] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-10-12_09:, , signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As old and new carveout name length may be different and the two names may have a common part, name comparison must cover the complete name field. Limit strncmp to carveout name length, i.e. 32 Bytes. Signed-off-by: Loic Pallardy --- drivers/remoteproc/remoteproc_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 1.9.1 diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 4a61dc1..96692c2 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -956,8 +956,7 @@ static int rproc_update_resource_table_entry(struct rproc *rproc, tblc = rsc; newc = request->resource; - if (strncmp(newc->name, tblc->name, - sizeof(*tblc->name))) + if (strncmp(newc->name, tblc->name, 32)) break; memcpy(tblc, newc, request->size);