From patchwork Fri Sep 9 09:19:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 75859 Delivered-To: patch@linaro.org Received: by 10.140.106.11 with SMTP id d11csp244283qgf; Fri, 9 Sep 2016 02:19:52 -0700 (PDT) X-Received: by 10.66.2.168 with SMTP id 8mr4666655pav.87.1473412792219; Fri, 09 Sep 2016 02:19:52 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u84si3055527pfa.234.2016.09.09.02.19.51; Fri, 09 Sep 2016 02:19:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753567AbcIIJTl (ORCPT + 27 others); Fri, 9 Sep 2016 05:19:41 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:36442 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753541AbcIIJTh (ORCPT ); Fri, 9 Sep 2016 05:19:37 -0400 Received: by mail-wm0-f42.google.com with SMTP id b187so20477984wme.1 for ; Fri, 09 Sep 2016 02:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=4MQn8bWeRCA0eUKzxWVI6zIqvgt0SweSu2s6G+MTazE=; b=SVnR7WfFAgK+bfqi0pYdZaeD6d15MrY/mqPfGBAiNx2yCt42rugmZjoCty9keVHVyk ec0v6kWpF5QF0q1TLW2++yxRxHklGwrT/VTv7zqyZNn4JW3HMvheodLNgxCeKfCaMr6z 35dx1v+QNikRLhmVChs1F1dJPVXG6hJfk4wWAxhphH/QUNmXS0ObneSFyO48KSEHubq/ AxJJjUC+MezIQyPndnNdEdodkHExG57cq14mTshfHrFCDDk9bRIGeNfBZRn63h06QKzE jfHjurd5PErdEzaBWbQmV6L8+fm0TCM0g77pyV67CMBmXVQc7lleT7UItEP8i+jc/2+M TeNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=4MQn8bWeRCA0eUKzxWVI6zIqvgt0SweSu2s6G+MTazE=; b=AeRGsrTAwz3evMXpfFgmZIY5hxBGnWwWzXA00hSc4lb7ygNBpWPfqFuByZ0tELhTRp nrqiJdkaq9wkkQ4WaxhqoMNzvjT3Ib3FSesMVCf5ct25E1O8skbv+xwPORJ7/TlHCpLp e1fsTa7gzywmYXhhtk/dqELmOqhkz5S/HidTIWALTns08OqsQtgOaZeU/FyRsInFeIIy 8VS/Dr9tn9aIC7aGAh+HqZ3/tovKWwtX14PTVFf2ki/aONGrizxona/AJY+TVtatF7JN lGQ+0hJU5A6CmPg2s2cekTvb/AI4BGlm1X4Vuoj7r6eG6lSziz7Z4OtMAeuyMzRiL+fZ 3X7Q== X-Gm-Message-State: AE9vXwO9LbLnyw7/Jw5K/V83CiU363u1pBFouUrk38485y/jGkbOF/oS3H2VKcZ+m+AHkxXv X-Received: by 10.194.8.226 with SMTP id u2mr2364274wja.153.1473412776051; Fri, 09 Sep 2016 02:19:36 -0700 (PDT) Received: from bgdev-debian.lan (jua06-1-82-242-157-225.fbx.proxad.net. [82.242.157.225]) by smtp.gmail.com with ESMTPSA id f8sm2366737wjh.45.2016.09.09.02.19.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 09 Sep 2016 02:19:35 -0700 (PDT) From: Bartosz Golaszewski To: Linus Walleij , Alexandre Courbot , Andy Shevchenko , Vignesh R , Yong Li , Geert Uytterhoeven Cc: linux-gpio , LKML , Bartosz Golaszewski Subject: [PATCH] gpio: gpiolib: fix an incorrect use of WARN_ON() Date: Fri, 9 Sep 2016 11:19:29 +0200 Message-Id: <1473412769-17428-1-git-send-email-bgolaszewski@baylibre.com> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This breaks the build due to the format string being passed as argument. Fix it by using WARN(). Signed-off-by: Bartosz Golaszewski --- NOTE This patch applies on top of linux-gpio devel branch. drivers/gpio/gpiolib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 95effec..384ed0a 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1618,8 +1618,8 @@ int _gpiochip_irqchip_add(struct gpio_chip *gpiochip, * used to configure the interrupts, as you may end-up with * conflicting triggers. Tell the user, and reset to NONE. */ - if (WARN_ON(of_node && type != IRQ_TYPE_NONE, - "%s: Ignoring %d default trigger\n", of_node->full_name)) + if (WARN(of_node && type != IRQ_TYPE_NONE, + "%s: Ignoring default trigger\n", of_node->full_name)) type = IRQ_TYPE_NONE; gpiochip->irqchip = irqchip;