From patchwork Tue Aug 30 16:10:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 74999 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp2226484qga; Tue, 30 Aug 2016 09:10:25 -0700 (PDT) X-Received: by 10.66.148.202 with SMTP id tu10mr7646553pab.52.1472573425178; Tue, 30 Aug 2016 09:10:25 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j190si45909706pfc.151.2016.08.30.09.10.23; Tue, 30 Aug 2016 09:10:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756284AbcH3QKU (ORCPT + 27 others); Tue, 30 Aug 2016 12:10:20 -0400 Received: from mail-it0-f42.google.com ([209.85.214.42]:35321 "EHLO mail-it0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751527AbcH3QKS (ORCPT ); Tue, 30 Aug 2016 12:10:18 -0400 Received: by mail-it0-f42.google.com with SMTP id x131so173298784ite.0 for ; Tue, 30 Aug 2016 09:10:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=3xFok2g9rnFDkh7gj5+59+U4AybajIJTpLt75AhrK1A=; b=bufHypbN1X8S/09ge+p0LShReYay8nM8wTdOLLq+U7162zmQx7UdzTv0Tnx0kOyPYO CVfCyc5OsfibaeyM5ztqMJ6QF1dN9uLvRI1zCnON6GJ6IfpxcVsOorgNa/kHab5hkPlC O13wsVmD3Xt8NNxUkFri+VR6KAm/SWz2qVJXM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=3xFok2g9rnFDkh7gj5+59+U4AybajIJTpLt75AhrK1A=; b=H9noKDbASYsTXr8hLPyPGvOjPqLasu7dlCSsmFLDZEIqnENXUK2if6TopHf5759qmp i7Bp4E3BKrAbHwaMDOVPYAo16STb66dz9/IewT2XO5hX6Kv9vyzma4cmrGb7MBqR4+VR N+Pvi0ZIyQU6JjEiZpcMxyXMbbvJuDI/tzCDQMI4MezTMBaNzQZ8QakOfirlpw13Gsfq EF/TQQKBrAiuGtPR/RC+q9Yob26rPKhPbWR+r9sdeUwJBpVFDi3dVMifEiTUjwEZ99+M GW9OhARQYM/UExNfUJOaTpbzQewXelC9zcl+fA75UCUkIeM1e/N+oT4KXyJmReHfQOF0 Qb8w== X-Gm-Message-State: AE9vXwPUd730Ze9SwNjP95bvoxNmsoO4U492TZ0aGslrbVxtEPfIDT4MGsEJjoHl0sXDAu0v X-Received: by 10.36.46.4 with SMTP id i4mr26866626ita.27.1472573417717; Tue, 30 Aug 2016 09:10:17 -0700 (PDT) Received: from t430.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id f126sm3472378ith.7.2016.08.30.09.10.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 30 Aug 2016 09:10:17 -0700 (PDT) From: Mathieu Poirier To: acme@kernel.org Cc: mingo@redhat.com, peterz@infradead.org, alexander.shishkin@linux.intel.com, jolsa@kernel.org, acme@infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH V2] perf tools: adding support for address filters Date: Tue, 30 Aug 2016 10:10:15 -0600 Message-Id: <1472573415-3618-1-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch makes it possible to use the current filter framework with address filters. That way address filters for HW tracers such as CoreSight and IntelPT can be communicated to the kernel drivers. CC: Alexander Shishkin Signed-off-by: Mathieu Poirier --- Changes for V2: - Rebased to v4.8-rc4. - Revisited error path. --- tools/perf/util/parse-events.c | 30 +++++++++++++++++++++++++----- 1 file changed, 25 insertions(+), 5 deletions(-) -- 2.7.4 diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index 2eb8b1ed4cc8..1df413fbf7f8 100644 --- a/tools/perf/util/parse-events.c +++ b/tools/perf/util/parse-events.c @@ -1760,12 +1760,26 @@ foreach_evsel_in_last_glob(struct perf_evlist *evlist, static int set_filter(struct perf_evsel *evsel, const void *arg) { const char *str = arg; + bool found = false; + int nr_addr_filters = 0; + struct perf_pmu *pmu = NULL; - if (evsel == NULL || evsel->attr.type != PERF_TYPE_TRACEPOINT) { - fprintf(stderr, - "--filter option should follow a -e tracepoint option\n"); - return -1; - } + if (evsel == NULL) + goto err; + + while ((pmu = perf_pmu__scan(pmu)) != NULL) + if (pmu->type == evsel->attr.type) { + found = true; + break; + } + + if (found) + perf_pmu__scan_file(pmu, "nr_addr_filters", + "%d", &nr_addr_filters); + + + if (evsel->attr.type != PERF_TYPE_TRACEPOINT && !nr_addr_filters) + goto err; if (perf_evsel__append_filter(evsel, "&&", str) < 0) { fprintf(stderr, @@ -1774,6 +1788,12 @@ static int set_filter(struct perf_evsel *evsel, const void *arg) } return 0; + +err: + fprintf(stderr, + "--filter option should follow a -e tracepoint or HW tracer option\n"); + + return -1; } int parse_filter(const struct option *opt, const char *str,