From patchwork Fri Aug 19 01:55:41 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Muckle X-Patchwork-Id: 74208 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp81132qga; Thu, 18 Aug 2016 18:56:11 -0700 (PDT) X-Received: by 10.98.192.144 with SMTP id g16mr9682807pfk.55.1471571771665; Thu, 18 Aug 2016 18:56:11 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id fa3si5421439pab.34.2016.08.18.18.56.11; Thu, 18 Aug 2016 18:56:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754629AbcHSB4I (ORCPT + 27 others); Thu, 18 Aug 2016 21:56:08 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:36562 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754113AbcHSBzs (ORCPT ); Thu, 18 Aug 2016 21:55:48 -0400 Received: by mail-pa0-f49.google.com with SMTP id pp5so11007230pac.3 for ; Thu, 18 Aug 2016 18:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=AvhQg7xfZqCP9dFx1ZmK6SDS0+/8P2gkoIIjkexOmpY=; b=gkzRCE3kReG7EB2OqQ/Xw+FxInGISsIyw/i1VVNgzAlsKXYG5Umbys9wfBO3Caxypi oPcUc3uHXbQDg8xjWbknHTO17xwhubXC2LQ5qw8slYCSLMzD3bZd+UVrdg2p0ClaptcM DiglYmc3w190l3yoYUXPmcNNBv7RL+9AXwrnE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=AvhQg7xfZqCP9dFx1ZmK6SDS0+/8P2gkoIIjkexOmpY=; b=SN0KSnt5tCexFwRQ0hQVp99i4WXbVuAuBejqGEy5WDF9D07UQUWofnHzJO2LaltRx3 hD7ld8Aup8JQUoArQrVduL1WL+5GchXz2zNX8PI1GSlk9Y3WRVizZxKP66M5R/RQrn9x MjFk2+x5W83Yqj/iQsLrtDvhHpki7jb1UDtB9Sz9RaKSim32/nVqnqA9LDMJNZrOTifh rLpsNdJ23p5yKXk6XhNadWmwR88JsKmIUSrbi520z9gM+mCgjjMNXQpB164jGffUn+MI ppdJVEAq7RU+PV75gL45ygTjHNkJTnUgsJYghLF4OL6hOl0Plp+ODmyF954BPdwctJsR h53g== X-Gm-Message-State: AEkooush+dCI13mzxbPFs9O6YbYChTZD3RlTukypJOarRouldMS6freE2xqU2p5AoKH46Vm4 X-Received: by 10.66.52.47 with SMTP id q15mr9011255pao.67.1471571748200; Thu, 18 Aug 2016 18:55:48 -0700 (PDT) Received: from graphite.smuckle.net (cpe-76-167-105-107.san.res.rr.com. [76.167.105.107]) by smtp.gmail.com with ESMTPSA id p4sm1652921pfp.60.2016.08.18.18.55.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 18 Aug 2016 18:55:47 -0700 (PDT) From: Steve Muckle X-Google-Original-From: Steve Muckle To: Peter Zijlstra , Ingo Molnar Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, "Rafael J . Wysocki" , Vincent Guittot , Morten Rasmussen , Dietmar Eggemann , Juri Lelli , Patrick Bellasi , Steve Muckle Subject: [PATCH] sched: fix incorrect PELT values on SMT Date: Thu, 18 Aug 2016 18:55:41 -0700 Message-Id: <1471571741-19504-1-git-send-email-smuckle@linaro.org> X-Mailer: git-send-email 2.7.3 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PELT scales its util_sum and util_avg values via arch_scale_cpu_capacity(). If that function is passed the CPU's sched domain then it will reduce the scaling capacity if SD_SHARE_CPUCAPACITY is set. PELT does not pass in the sd however. The other caller of arch_scale_cpu_capacity, update_cpu_capacity(), does. This means util_sum and util_avg scale beyond the CPU capacity on SMT. On an Intel i7-3630QM for example rq->cpu_capacity_orig is 589 but util_avg scales up to 1024. Fix this by passing in the sd in __update_load_avg() as well. Signed-off-by: Steve Muckle --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.3 diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 61d485421bed..95d34b337152 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -2731,7 +2731,7 @@ __update_load_avg(u64 now, int cpu, struct sched_avg *sa, sa->last_update_time = now; scale_freq = arch_scale_freq_capacity(NULL, cpu); - scale_cpu = arch_scale_cpu_capacity(NULL, cpu); + scale_cpu = arch_scale_cpu_capacity(cpu_rq(cpu)->sd, cpu); /* delta_w is the amount already accumulated against our next period */ delta_w = sa->period_contrib;