From patchwork Mon Aug 15 10:42:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 73906 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp1378944qga; Mon, 15 Aug 2016 03:42:44 -0700 (PDT) X-Received: by 10.98.60.217 with SMTP id b86mr413738pfk.129.1471257764046; Mon, 15 Aug 2016 03:42:44 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id hm6si26125368pac.254.2016.08.15.03.42.43; Mon, 15 Aug 2016 03:42:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752984AbcHOKml (ORCPT + 27 others); Mon, 15 Aug 2016 06:42:41 -0400 Received: from foss.arm.com ([217.140.101.70]:39770 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752785AbcHOKmk (ORCPT ); Mon, 15 Aug 2016 06:42:40 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8F5B0479; Mon, 15 Aug 2016 03:44:11 -0700 (PDT) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6C2D33F32C; Mon, 15 Aug 2016 03:42:39 -0700 (PDT) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id EFC2E1AE3988; Mon, 15 Aug 2016 11:42:48 +0100 (BST) From: Will Deacon To: linux-kernel@vger.kernel.org Cc: mark.rutland@arm.com, Will Deacon , Peter Zijlstra Subject: [PATCH] perf/core: Don't pass PERF_EF_START to the PMU ->start callback Date: Mon, 15 Aug 2016 11:42:45 +0100 Message-Id: <1471257765-29662-1-git-send-email-will.deacon@arm.com> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PERF_EF_START is a flag to indicate to the PMU ->add callback that, as well as claiming the PMU resources required by the event being added, it should also start the PMU. Passing this flag to the ->start callback doesn't make sense, because ->start always tries to start the PMU. Remove it. Cc: Peter Zijlstra Signed-off-by: Will Deacon --- kernel/events/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.1.4 diff --git a/kernel/events/core.c b/kernel/events/core.c index 1903b8f3a705..b11504376af7 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -2455,7 +2455,7 @@ static int __perf_event_stop(void *info) * while restarting. */ if (sd->restart) - event->pmu->start(event, PERF_EF_START); + event->pmu->start(event, 0); return 0; }