From patchwork Thu Jul 21 07:56:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Binoy Jayan X-Patchwork-Id: 72528 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp300505qga; Thu, 21 Jul 2016 00:57:13 -0700 (PDT) X-Received: by 10.66.80.136 with SMTP id r8mr62340559pax.72.1469087832800; Thu, 21 Jul 2016 00:57:12 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id yw7si8310695pac.85.2016.07.21.00.57.12; Thu, 21 Jul 2016 00:57:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751913AbcGUH5J (ORCPT + 29 others); Thu, 21 Jul 2016 03:57:09 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:36619 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751166AbcGUH5F (ORCPT ); Thu, 21 Jul 2016 03:57:05 -0400 Received: by mail-pf0-f180.google.com with SMTP id h186so27848134pfg.3 for ; Thu, 21 Jul 2016 00:57:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=+pruHhj3CjOuPJG9WBU395upY4BCr2uXRIkMr60LLpg=; b=aFDvaGsuiv6B0hWcQ3fSz0og8TlQxh0EKJUymAvH2DDeN/VD+I6y1ZRD4h3CvpRrE4 T8+drsHG3FlRnXCH4GILqL4ykHQI0/28OLy13jKqVgoDHxeZQ5DRql7Ywv4mBkNQlwuc sbpB97ke5qSjHzaCHaX1IBnpobYUEIXsdXzI4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=+pruHhj3CjOuPJG9WBU395upY4BCr2uXRIkMr60LLpg=; b=dxcto1p/vooVuzvHu6MPaualPhnGH1GWL7LdapeaJvfSCoWImro8SNoJUUbI9ABdae KN1qpKvhxGV0HJMnDljkbndcMuq0crFM7y+iWDs81OjDKMXLbDZ5l487vWbFGCfZ25Uz s55ZRCiVK+U0lexDVPdIj9V7HDRMT2MCXCSpDZuHSnsNN/VcVbN2KlgH7WMv0AsPjpdE khBIkFwwpiIJX2sMLJpJ98iuxCDdWlukPCSy4nGaGRYyXHlibLQ8E+W5Q99a1A6BxLPM NFAIelThL3ihuxl8kcAwwp7aKSouM8fVPgaFwB5D17/97ECKhtX5jwZi5iKoOx8FBUcV gjIw== X-Gm-Message-State: ALyK8tKkequU22OlW6wenTcwhg5gL2yq7dmCosQ63HC6DiYqMm574Xs5GY+BTbYw9JekmrGk X-Received: by 10.98.112.196 with SMTP id l187mr71308605pfc.59.1469087825056; Thu, 21 Jul 2016 00:57:05 -0700 (PDT) Received: from blr-ubuntu-59.ap.qualcomm.com ([202.46.23.61]) by smtp.gmail.com with ESMTPSA id 72sm9771676pfs.51.2016.07.21.00.57.00 (version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 21 Jul 2016 00:57:04 -0700 (PDT) From: Binoy Jayan To: Greg Kroah-Hartman Cc: Johnny Kim , Austin Shin , Chris Park , Tony Cho , Glen Lee , Leo Kim , Arnd Bergmann , linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Binoy Jayan Subject: [PATCH] staging: wilc1000: txq_event: Fix coding error Date: Thu, 21 Jul 2016 13:26:56 +0530 Message-Id: <1469087816-16773-1-git-send-email-binoy.jayan@linaro.org> X-Mailer: git-send-email 1.8.2.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix incorrect usage of completion interface by replacing 'wait_for_completion' with 'complete'. This error was introduced accidentally while replacing semaphores with mutexes. Reported-by: Jiri Slaby Signed-off-by: Binoy Jayan --- drivers/staging/wilc1000/linux_wlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index 3a66255..3221511 100644 --- a/drivers/staging/wilc1000/linux_wlan.c +++ b/drivers/staging/wilc1000/linux_wlan.c @@ -648,7 +648,7 @@ void wilc1000_wlan_deinit(struct net_device *dev) mutex_unlock(&wl->hif_cs); } if (&wl->txq_event) - wait_for_completion(&wl->txq_event); + complete(&wl->txq_event); wlan_deinitialize_threads(dev); deinit_irq(dev);