From patchwork Mon Jul 18 03:31:49 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Pitre X-Patchwork-Id: 72180 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp197578qga; Sun, 17 Jul 2016 20:32:59 -0700 (PDT) X-Received: by 10.66.134.20 with SMTP id pg20mr52471810pab.98.1468812775106; Sun, 17 Jul 2016 20:32:55 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ww2si24289982pac.48.2016.07.17.20.32.54; Sun, 17 Jul 2016 20:32:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751915AbcGRDcs (ORCPT + 29 others); Sun, 17 Jul 2016 23:32:48 -0400 Received: from alt13.smtp-out.videotron.ca ([135.19.0.26]:22835 "EHLO alt12.smtp-out.videotron.ca" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751424AbcGRDcL (ORCPT ); Sun, 17 Jul 2016 23:32:11 -0400 Received: from yoda.home ([96.23.157.65]) by Videotron with SMTP id OzHsbcNQ4Hh2dOzHtbOdB4; Sun, 17 Jul 2016 23:32:10 -0400 X-Authority-Analysis: v=2.1 cv=Lv0ysipc c=1 sm=1 tr=0 a=keA3yYpnlypCNW5BNWqu+w==:117 a=keA3yYpnlypCNW5BNWqu+w==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=cAmyUtKerLwA:10 a=KKAkSRfTAAAA:8 a=CyGdA8acv9_BqvHd13oA:9 a=h-bixeDdE50t53Jr:21 a=TDkmCclVebuachYb:21 a=cvBusfyB2V15izCimMoJ:22 Received: from xanadu.home (xanadu.home [192.168.2.2]) by yoda.home (Postfix) with ESMTP id 6450F2DA05F0; Sun, 17 Jul 2016 23:32:08 -0400 (EDT) From: Nicolas Pitre To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Alexander Viro , David Howells , Greg Ungerer Subject: [PATCH v2 03/10] binfmt_flat: use generic transfer_args_to_stack() Date: Sun, 17 Jul 2016 23:31:49 -0400 Message-Id: <1468812716-30537-4-git-send-email-nicolas.pitre@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1468812716-30537-1-git-send-email-nicolas.pitre@linaro.org> References: <1468812716-30537-1-git-send-email-nicolas.pitre@linaro.org> X-CMAE-Envelope: MS4wfEXtZSx1gJEm+gyUTmrMViDlaI5btzRL3/WwLNMPIQopDtJM+HM3cfGSbtAJk42ysWX0u93CWT35s3P6O9g6W2TuSshYXm1qizCE8Cm+SKYx9YSfzInj zFUu1Qc2w1s5kqnol2Rw1MKGCOK7JY+4+jEOkwciFInGpBbkcYzr9jh1788zx6FO0Y6+bFOVhKwXBZGLQA4oAFaYgbUw8ds79ZyxhA0I6uEFfaYHw+gbWYWk eym2OGcruF0zI3FwxBv+mPMJWXLVwX0AW4tH9gD9rw3lZ6KK56qk0so/0+cVQVnSPUIc1bhex6M0PDJqytYaEA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This gets rid of the rather ugly, open coded and suboptimal copy code. Signed-off-by: Nicolas Pitre --- fs/binfmt_flat.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) -- 2.7.4 diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c index 085059d879..64feb873f0 100644 --- a/fs/binfmt_flat.c +++ b/fs/binfmt_flat.c @@ -854,10 +854,8 @@ static int load_flat_binary(struct linux_binprm * bprm) { struct lib_info libinfo; struct pt_regs *regs = current_pt_regs(); - unsigned long p = bprm->p; - unsigned long stack_len; + unsigned long sp, stack_len; unsigned long start_addr; - unsigned long *sp; int res; int i, j; @@ -892,15 +890,15 @@ static int load_flat_binary(struct linux_binprm * bprm) set_binfmt(&flat_format); - p = ((current->mm->context.end_brk + stack_len + 3) & ~3) - 4; - DBG_FLT("p=%lx\n", p); + sp = ((current->mm->context.end_brk + stack_len + 3) & ~3) - 4; + DBG_FLT("sp=%lx\n", sp); - /* copy the arg pages onto the stack, this could be more efficient :-) */ - for (i = TOP_OF_ARGS - 1; i >= bprm->p; i--) - * (char *) --p = - ((char *) page_address(bprm->page[i/PAGE_SIZE]))[i % PAGE_SIZE]; + /* copy the arg pages onto the stack */ + res = transfer_args_to_stack(bprm, &sp); + if (res) + return res; - sp = (unsigned long *) create_flat_tables(p, bprm); + sp = create_flat_tables(sp, bprm); /* Fake some return addresses to ensure the call chain will * initialise library in order for us. We are required to call @@ -912,14 +910,14 @@ static int load_flat_binary(struct linux_binprm * bprm) for (i = MAX_SHARED_LIBS-1; i>0; i--) { if (libinfo.lib_list[i].loaded) { /* Push previos first to call address */ - --sp; put_user(start_addr, sp); + --sp; put_user(start_addr, (unsigned long *)sp); start_addr = libinfo.lib_list[i].entry; } } #endif /* Stash our initial stack pointer into the mm structure */ - current->mm->start_stack = (unsigned long )sp; + current->mm->start_stack = sp; #ifdef FLAT_PLAT_INIT FLAT_PLAT_INIT(regs);