From patchwork Fri Jun 24 14:11:05 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yingjoe Chen X-Patchwork-Id: 70825 Delivered-To: patch@linaro.org Received: by 10.140.28.4 with SMTP id 4csp970123qgy; Fri, 24 Jun 2016 07:11:23 -0700 (PDT) X-Received: by 10.66.161.201 with SMTP id xu9mr7945685pab.140.1466777483007; Fri, 24 Jun 2016 07:11:23 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b10si112260pan.98.2016.06.24.07.11.22; Fri, 24 Jun 2016 07:11:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751650AbcFXOLU (ORCPT + 30 others); Fri, 24 Jun 2016 10:11:20 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:27182 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751460AbcFXOLU (ORCPT ); Fri, 24 Jun 2016 10:11:20 -0400 Received: from mtkhts09.mediatek.inc [(172.21.101.70)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1655399369; Fri, 24 Jun 2016 22:11:15 +0800 Received: from mtksdtcf02.mediatek.inc (10.21.12.142) by mtkhts09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 14.3.266.1; Fri, 24 Jun 2016 22:09:22 +0800 From: Yingjoe Chen To: Andy Whitcroft , Joe Perches CC: , , Andi Kleen , Paul Bolle , Yingjoe Chen Subject: [PATCH v4 1/2] checkpatch: testing more config for Kconfig help text Date: Fri, 24 Jun 2016 22:11:05 +0800 Message-ID: <1466777466-21306-1-git-send-email-yingjoe.chen@mediatek.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Current help text check only check a config option if it is followed by another config. Adding check for help text if the next entry is menuconfig, choice/ endchoice, comment, menu/endmenu, if/endif, source or end of file. Signed-off-by: Yingjoe Chen --- checkpatch Kconfig checking stuff again. Change in this round: In 'default n' check, don't warn if user comment on why the 'default n' is neccessary. I also change patch order. The first one extend help message check to check for all available config entries. If you think 'default n' check is not that useful, please consider just merge this one. Let me know what you think. Thanks. Change in v3: - Rebase to v4.7-rc1 Change in v2: - Change according to Joe Perches' suggestion --- scripts/checkpatch.pl | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) -- 1.9.1 diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 6750595..19b270b 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2646,6 +2646,12 @@ sub process { next if ($f =~ /^-/); last if (!$file && $f =~ /^\@\@/); + if ($f !~ /^[+\- ]/) { + # End of file + $is_end = 1; + last; + } + if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate)\s*\"/) { $is_start = 1; } elsif ($lines[$ln - 1] =~ /^\+\s*(?:---)?help(?:---)?$/) { @@ -2656,7 +2662,7 @@ sub process { $f =~ s/#.*//; $f =~ s/^\s+//; next if ($f =~ /^$/); - if ($f =~ /^\s*config\s/) { + if ($f =~ /^(?:config\s|menuconfig\s|choice\s|endchoice\s*$|comment\s|menu\s|endmenu\s*$|if\s|endif\s*$|source\s)/) { $is_end = 1; last; }