From patchwork Thu Jun 16 21:27:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 70237 Delivered-To: patch@linaro.org Received: by 10.140.28.4 with SMTP id 4csp465580qgy; Thu, 16 Jun 2016 14:31:53 -0700 (PDT) X-Received: by 10.66.101.105 with SMTP id ff9mr7474359pab.84.1466112713195; Thu, 16 Jun 2016 14:31:53 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z9si10192571pau.40.2016.06.16.14.31.52; Thu, 16 Jun 2016 14:31:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933335AbcFPV30 (ORCPT + 30 others); Thu, 16 Jun 2016 17:29:26 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:38521 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754982AbcFPV3Q (ORCPT ); Thu, 16 Jun 2016 17:29:16 -0400 Received: by mail-wm0-f53.google.com with SMTP id m124so86978544wme.1 for ; Thu, 16 Jun 2016 14:29:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DGH/MCS5ppC8xHM0SOzQqLWfgMmiT0One/n7c2w8P/Y=; b=ZA4Exuo4ODlCxhtc+2j2x0P2be5x46AkJhKloxKVzbnAaqL20gCDKIVK/cFbHtuWdO sXyfgF1acQLmLBUt1VwUj7ATv1GCXl3PfEKQUz016IEb6MBDc2QEUiNeSFrvU9vmBiLb ZF1HLmT1RMEhJ13iGE4ulcz1R+sT5TdDZ2Ie8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DGH/MCS5ppC8xHM0SOzQqLWfgMmiT0One/n7c2w8P/Y=; b=Qfm9UnxAjUialy2jSpdoh2nTF4W9m7fbAdQCgMZfsXDgYmW4jTWY1i4quz1yTbKsuM C3FyOxZxXy1V8xKRx2umQNMr+Snj0EdLufaGoNo8zp+hglaGUV8DJOBcy7AjHAYceCr3 0PEDgjcwM4bHefKVk/eNnL7TwMDJcKMOhlIudJDud3vESVwnsVx8kurx1K11V8b3FdM3 LJY1YrgSw2mwc5BkOAQdbxRq1U0cSwGBwnOPB3PTYVJfDO3eCEsT18RY0YQ6TdRN48mY i1//4JUV6AdZM9cRpjdE2HT16bNO0GuLj/OdbAGgKou5IA2aPiiJW+cyxLopCKe5e8L/ LFeg== X-Gm-Message-State: ALyK8tI7xBSLNlHPTWxNtfFwKzetFoaSyRbKohio2QFOeyEoEE6Mc/u+O1/ygKt0tb/DSRn5 X-Received: by 10.28.194.87 with SMTP id s84mr6413182wmf.59.1466112555483; Thu, 16 Jun 2016 14:29:15 -0700 (PDT) Received: from localhost.localdomain (sju31-1-78-210-255-2.fbx.proxad.net. [78.210.255.2]) by smtp.gmail.com with ESMTPSA id x128sm16705606wmf.6.2016.06.16.14.29.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 16 Jun 2016 14:29:15 -0700 (PDT) From: Daniel Lezcano To: daniel.lezcano@linaro.org, tglx@linutronix.de Cc: linux-kernel@vger.kernel.org Subject: [PATCH V2 54/63] clocksource/drivers/zevio-timer: Convert init function to return error Date: Thu, 16 Jun 2016 23:27:13 +0200 Message-Id: <1466112442-31105-55-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1466112442-31105-1-git-send-email-daniel.lezcano@linaro.org> References: <1466112442-31105-1-git-send-email-daniel.lezcano@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The init functions do not return any error. They behave as the following: - panic, thus leading to a kernel crash while another timer may work and make the system boot up correctly or - print an error and let the caller unaware if the state of the system Change that by converting the init functions to return an error conforming to the CLOCKSOURCE_OF_RET prototype. Proper error handling (rollback, errno value) will be changed later case by case, thus this change just return back an error or success in the init function. Signed-off-by: Daniel Lezcano --- drivers/clocksource/zevio-timer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 1.9.1 diff --git a/drivers/clocksource/zevio-timer.c b/drivers/clocksource/zevio-timer.c index ceaa613..cb4cf056 100644 --- a/drivers/clocksource/zevio-timer.c +++ b/drivers/clocksource/zevio-timer.c @@ -210,9 +210,9 @@ error_free: return ret; } -static void __init zevio_timer_init(struct device_node *node) +static int __init zevio_timer_init(struct device_node *node) { - BUG_ON(zevio_timer_add(node)); + return zevio_timer_add(node); } -CLOCKSOURCE_OF_DECLARE(zevio_timer, "lsi,zevio-timer", zevio_timer_init); +CLOCKSOURCE_OF_DECLARE_RET(zevio_timer, "lsi,zevio-timer", zevio_timer_init);