From patchwork Tue Jun 14 22:43:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 70061 Delivered-To: patches@linaro.org Received: by 10.140.106.246 with SMTP id e109csp2280646qgf; Tue, 14 Jun 2016 15:43:39 -0700 (PDT) X-Received: by 10.98.28.143 with SMTP id c137mr6286787pfc.131.1465944217905; Tue, 14 Jun 2016 15:43:37 -0700 (PDT) Return-Path: Received: from mail-pf0-x22b.google.com (mail-pf0-x22b.google.com. [2607:f8b0:400e:c00::22b]) by mx.google.com with ESMTPS id px10si23720178pac.209.2016.06.14.15.43.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Jun 2016 15:43:37 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 2607:f8b0:400e:c00::22b as permitted sender) client-ip=2607:f8b0:400e:c00::22b; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: domain of john.stultz@linaro.org designates 2607:f8b0:400e:c00::22b as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by mail-pf0-x22b.google.com with SMTP id y124so1801298pfy.0 for ; Tue, 14 Jun 2016 15:43:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=c/OMqVVKt5wcP31qIMyaO6HqZGB+RxVTGcZy+N9rTRY=; b=ijyoToVw8P8fDIxDKoQLtlOU0ligVRwxzH4ImBlaFkU0eBlNYUaik6UzUAsU60JP7F IKSc6TMBcLAKQJ5b9bMENtkjYH3lmtB3SezNRojAkBbxloF7ignUgHvyENXQBHDF3epd WkeLAVmCiXjr9xIeS5CqbG6rdeS6/l3TyHzGA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=c/OMqVVKt5wcP31qIMyaO6HqZGB+RxVTGcZy+N9rTRY=; b=Z+duLTDnVw7Xu3iLncAxxvJGMyFzHdMZwc8RPxbLsQgnmNv3+V29LKwLoJJ/jqPQ/G v1dZ4HYhDZPeN9RD45HzZXpEcLBuMlTuW910lzpIvn+Z3+YeITRzJRAHOwj+BKfSmcOY N03Tb7yi0OSJeCgpPdxT0qQYoTfsV+Ou92HypbGF6s2FIoCB3RgpRaAxEb/LTWwWWSdC KJzSKbfQexmg/yilGfH492yTh0XLod4mUyz8aKEK2XjYsRoVuuw+AS1alK7uww6Bn158 tK197PMlfpUUm1z39G2gEepj3/oKWtRSeSi7N+oas6UQ/nOvsqLvV294cPIsUes4hiaz 38/g== X-Gm-Message-State: ALyK8tJ9FijXE2thrOM4QYFXoQVDN4Gqd+q0I1dz1xGIKVA7v0hY/8f4q5mMshRB3Av2pJGsNOU= X-Received: by 10.98.41.133 with SMTP id p127mr68669pfp.18.1465944217593; Tue, 14 Jun 2016 15:43:37 -0700 (PDT) Return-Path: Received: from localhost.localdomain (c-73-67-244-238.hsd1.or.comcast.net. [73.67.244.238]) by smtp.gmail.com with ESMTPSA id q88sm47789676pfj.4.2016.06.14.15.43.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 14 Jun 2016 15:43:37 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Dmitry Torokhov , Rob Herring , Lee Jones , Jorge Ramirez-Ortiz , Feng Chen , Wei Xu , Guodong Xu Subject: [PATCH 2/4] mfd: hi655x-pmic: Fixup issue with un-acked interrupts Date: Tue, 14 Jun 2016 15:43:30 -0700 Message-Id: <1465944212-17079-3-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1465944212-17079-1-git-send-email-john.stultz@linaro.org> References: <1465944212-17079-1-git-send-email-john.stultz@linaro.org> While trying to get the powerkey to function, I found when pressing the key, I would get infinitely repeating interrupts. After digging around a bit, it seems we didn't set the ack_base value for the regmap irqchip logic, so nothing was acking the interrupt. This patch adds the ack_base, which seems to make things work. Cc: Dmitry Torokhov Cc: Rob Herring Cc: Lee Jones Cc: Jorge Ramirez-Ortiz Cc: Feng Chen Cc: Wei Xu Cc: Guodong Xu Acked-by: Lee Jones Signed-off-by: John Stultz --- drivers/mfd/hi655x-pmic.c | 1 + 1 file changed, 1 insertion(+) -- 1.9.1 diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c index 05ddc78..68ab370 100644 --- a/drivers/mfd/hi655x-pmic.c +++ b/drivers/mfd/hi655x-pmic.c @@ -45,6 +45,7 @@ static const struct regmap_irq_chip hi655x_irq_chip = { .num_regs = 1, .num_irqs = ARRAY_SIZE(hi655x_irqs), .status_base = HI655X_IRQ_STAT_BASE, + .ack_base = HI655X_IRQ_STAT_BASE, .mask_base = HI655X_IRQ_MASK_BASE, };