From patchwork Fri Jun 10 05:34:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 69743 Delivered-To: patches@linaro.org Received: by 10.140.106.246 with SMTP id e109csp122815qgf; Thu, 9 Jun 2016 22:34:52 -0700 (PDT) X-Received: by 10.98.31.140 with SMTP id l12mr236631pfj.51.1465536890467; Thu, 09 Jun 2016 22:34:50 -0700 (PDT) Return-Path: Received: from mail-pf0-x229.google.com (mail-pf0-x229.google.com. [2607:f8b0:400e:c00::229]) by mx.google.com with ESMTPS id y191si5990887pfg.99.2016.06.09.22.34.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Jun 2016 22:34:50 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 2607:f8b0:400e:c00::229 as permitted sender) client-ip=2607:f8b0:400e:c00::229; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: domain of john.stultz@linaro.org designates 2607:f8b0:400e:c00::229 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by mail-pf0-x229.google.com with SMTP id y124so20211513pfy.0 for ; Thu, 09 Jun 2016 22:34:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=c/OMqVVKt5wcP31qIMyaO6HqZGB+RxVTGcZy+N9rTRY=; b=UypBHUiSuAnQOHbpwZPKta4WhurgSuqpxjbg8cTmiFkDzQ2rJZRGu0dXKWPggwo283 8I/wRScGja0DwPbDrcbyNifqN5q127kqW8PecKEBg5CS47Dug8VVsBFKadjZ53yCCrZY qP9s0CarbStnYD7rBakj+UYFYZqZBmXbBlLp4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=c/OMqVVKt5wcP31qIMyaO6HqZGB+RxVTGcZy+N9rTRY=; b=QBvsgA9qtYBsI0yZ7TjGf0FmCri50wxbHBU+GBo+Q42MWAulH+yvqjESfH807grGg6 B2y3MsCuGFPv9/RfvvtXjoIB65XDIzwCXXi9xoCV4kgR62HiXU797/ib9YzG7hU00N08 3MPtSvRurSowb7XjfIA7kh0unpD0QuvTqWdZb8a6+O6IME3R/tfvZh/Z8Ca0JMaRZDOG lmE3mgjBNKd85L309pHepx5PfuLQMsXuShGSgosYB7udlxWi/H4ey1osQLFCJq7XlkIK hMdnstThV/APaok4vToF80tkrhfbpsKS5qGASyxRlX7zfeO3aiACf5UEY5dj5AcxKtOx SU0A== X-Gm-Message-State: ALyK8tIp7Y3Dn8+TyaOudU210KXgktmdrmqd+h1ISZjhEwXslOn8aowvRZvFDTUZan6vJ4xBGDI= X-Received: by 10.98.8.69 with SMTP id c66mr241042pfd.47.1465536890158; Thu, 09 Jun 2016 22:34:50 -0700 (PDT) Return-Path: Received: from localhost.localdomain (c-73-67-244-238.hsd1.or.comcast.net. [73.67.244.238]) by smtp.gmail.com with ESMTPSA id c15sm14072566pfj.65.2016.06.09.22.34.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Jun 2016 22:34:49 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Dmitry Torokhov , Rob Herring , Lee Jones , Jorge Ramirez-Ortiz , Feng Chen , Wei Xu , Guodong Xu Subject: [PATCH 2/3] mfd: hi655x-pmic: Fixup issue with un-acked interrupts Date: Thu, 9 Jun 2016 22:34:36 -0700 Message-Id: <1465536877-18452-3-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1465536877-18452-1-git-send-email-john.stultz@linaro.org> References: <1465536877-18452-1-git-send-email-john.stultz@linaro.org> While trying to get the powerkey to function, I found when pressing the key, I would get infinitely repeating interrupts. After digging around a bit, it seems we didn't set the ack_base value for the regmap irqchip logic, so nothing was acking the interrupt. This patch adds the ack_base, which seems to make things work. Cc: Dmitry Torokhov Cc: Rob Herring Cc: Lee Jones Cc: Jorge Ramirez-Ortiz Cc: Feng Chen Cc: Wei Xu Cc: Guodong Xu Acked-by: Lee Jones Signed-off-by: John Stultz --- drivers/mfd/hi655x-pmic.c | 1 + 1 file changed, 1 insertion(+) -- 1.9.1 diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c index 05ddc78..68ab370 100644 --- a/drivers/mfd/hi655x-pmic.c +++ b/drivers/mfd/hi655x-pmic.c @@ -45,6 +45,7 @@ static const struct regmap_irq_chip hi655x_irq_chip = { .num_regs = 1, .num_irqs = ARRAY_SIZE(hi655x_irqs), .status_base = HI655X_IRQ_STAT_BASE, + .ack_base = HI655X_IRQ_STAT_BASE, .mask_base = HI655X_IRQ_MASK_BASE, };