From patchwork Fri Jun 3 22:11:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 69302 Delivered-To: patches@linaro.org Received: by 10.140.106.246 with SMTP id e109csp477137qgf; Fri, 3 Jun 2016 15:11:38 -0700 (PDT) X-Received: by 10.66.240.8 with SMTP id vw8mr7815130pac.62.1464991893518; Fri, 03 Jun 2016 15:11:33 -0700 (PDT) Return-Path: Received: from mail-pf0-x22a.google.com (mail-pf0-x22a.google.com. [2607:f8b0:400e:c00::22a]) by mx.google.com with ESMTPS id t8si8189698pay.32.2016.06.03.15.11.33 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Jun 2016 15:11:33 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 2607:f8b0:400e:c00::22a as permitted sender) client-ip=2607:f8b0:400e:c00::22a; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: domain of john.stultz@linaro.org designates 2607:f8b0:400e:c00::22a as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by mail-pf0-x22a.google.com with SMTP id f144so47536122pfa.3 for ; Fri, 03 Jun 2016 15:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pRhEbBld1yT/MHOYIQaYaraJgGqbMetzbcKEMBmmgAQ=; b=HqcljDjjvSMqiUaDkkySWvRoTI7DBvevJW4NzE7wJ8bmqP+nZT7v7b+aodiU5AhETf JJ0PGq7+4BSwDicDJn4eNSb7n5QDlA+Pi879eV8dY7suIs9rDvh2pHFr0uD/2kVQAfM8 bWANl+hE4VmT2P9r5UJaHV4binqUiQ/7gwy78= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pRhEbBld1yT/MHOYIQaYaraJgGqbMetzbcKEMBmmgAQ=; b=ZuFZyQ5AOR2H5mIhI1wmDP6yQ1sBiIpc23XuR/UgKha9wKx3KUV7i9BzLtFpmutxZs K2qNzLnoZLfXc+xv4BjssflwRxUVmNke3SXqwLSwQoClk96LYkre9e7KouEsBlRiVjv4 eFdTKS/rb9cS7OVEzgE1LOHjh6XQJeAzw9vCCky24owbHva8hPyuJFV4iIkHo5qsK6uX lSkRKNFtu9V9yAR3b/7nbk5sYy0GcVO7JC9zWiXEQrja0akgLJZXgih0x93DHVyD37sh r294lEZxqNDfSuXTwrF5JNv/D/em4hWgqvQe5O3upF/630wvSzeU4JgngEubFotNQ/md pONg== X-Gm-Message-State: ALyK8tI0S3w4AbAc5uBQLfMm/4Ut+gc1lO0UFyW98dMywVDolP1WgdmnTU/B5t28O6OCo6wcz+c= X-Received: by 10.98.103.7 with SMTP id b7mr8455182pfc.19.1464991893194; Fri, 03 Jun 2016 15:11:33 -0700 (PDT) Return-Path: Received: from localhost.localdomain (c-73-67-244-238.hsd1.or.comcast.net. [73.67.244.238]) by smtp.gmail.com with ESMTPSA id d184sm10596841pfc.56.2016.06.03.15.11.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 03 Jun 2016 15:11:32 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Dmitry Torokhov , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Lee Jones , Jorge Ramirez-Ortiz , Wei Xu , Guodong Xu Subject: [PATCH 3/5] hi655x-pmic: Fixup issue with un-acked interrupts Date: Fri, 3 Jun 2016 15:11:24 -0700 Message-Id: <1464991886-632-4-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1464991886-632-1-git-send-email-john.stultz@linaro.org> References: <1464991886-632-1-git-send-email-john.stultz@linaro.org> While trying to get the powerkey to function, I found when pressing the key, I would get infinitely repeating interrupts. After digging around a bit, it seems we didn't set the ack_base value for the regmap irqchip logic, so nothing was acking the interrupt. This patch adds the ack_base, which seems to make things work. Cc: Dmitry Torokhov Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: Lee Jones Cc: Jorge Ramirez-Ortiz Cc: Wei Xu Cc: Guodong Xu Signed-off-by: John Stultz --- drivers/mfd/hi655x-pmic.c | 1 + 1 file changed, 1 insertion(+) -- 1.9.1 diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c index 3511035..4a3fdbc 100644 --- a/drivers/mfd/hi655x-pmic.c +++ b/drivers/mfd/hi655x-pmic.c @@ -50,6 +50,7 @@ static const struct regmap_irq_chip hi655x_irq_chip = { .num_regs = 1, .num_irqs = ARRAY_SIZE(hi655x_irqs), .status_base = HI655X_IRQ_STAT_BASE, + .ack_base = HI655X_IRQ_STAT_BASE, .mask_base = HI655X_IRQ_MASK_BASE, };