From patchwork Wed Jun 1 21:27:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 69073 Delivered-To: patches@linaro.org Received: by 10.140.23.41 with SMTP id 38csp17143qgo; Wed, 1 Jun 2016 14:27:49 -0700 (PDT) X-Received: by 10.98.82.77 with SMTP id g74mr12956665pfb.113.1464816466034; Wed, 01 Jun 2016 14:27:46 -0700 (PDT) Return-Path: Received: from mail-pf0-x236.google.com (mail-pf0-x236.google.com. [2607:f8b0:400e:c00::236]) by mx.google.com with ESMTPS id qk1si12984253pac.100.2016.06.01.14.27.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Jun 2016 14:27:46 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 2607:f8b0:400e:c00::236 as permitted sender) client-ip=2607:f8b0:400e:c00::236; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: domain of john.stultz@linaro.org designates 2607:f8b0:400e:c00::236 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by mail-pf0-x236.google.com with SMTP id b124so22382801pfb.0 for ; Wed, 01 Jun 2016 14:27:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pRhEbBld1yT/MHOYIQaYaraJgGqbMetzbcKEMBmmgAQ=; b=V06eIjb3Dd6JGU+HwY/SYIPIIMX8ihBuNGES4LOiTJnv1cKTig/isIO6bXahvjZjDO MdO2nNPSWagIAaKs6OdqYThVcU4/S4jQCU4Oe2A1EHNLKan8QXd8vQ0upmAQ5c+/9NCS rXjDfhytNKRG6KlpDtB3aAdsm/XJ56Nb1sl/Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pRhEbBld1yT/MHOYIQaYaraJgGqbMetzbcKEMBmmgAQ=; b=nILk7OqYbgShAFiSY74VcN79cTZnMqabnHOutMtpRQ0k6Ky6NZh8OkUGMNdJLd5zdF CIpyLz3zBivJI58qkgLSGK9Kevv4/xTq9FWPxMd1Za2kiIeookXzS8w3qVDIqzTVuznS G1bGsyl+5SJcWKVt9vYBFBwI1rOec2dlMhfWQ7KV8Gnt002gymyidOarg2bw5hkPFpRX qdYxXvxfVlvf0Sotdl9mA4sdbfe4i/VFMKOlhv6aHcoNK/t9+Xw79DUwoOO6sx9+JDUH jiOxhUX1bXjKa7d+vub0BioKrWa8OBBsQgDSRbULIZqIux9Ga/so1nMuCxldbdJNvQuX iZEQ== X-Gm-Message-State: ALyK8tKL1AQlZgPRLqQFlb7k3MSqJnUZnvG+zgZZAmGliZ4EWp6yUapTqTJJR8Xakrq38+vY6UU= X-Received: by 10.98.54.194 with SMTP id d185mr13139954pfa.34.1464816465712; Wed, 01 Jun 2016 14:27:45 -0700 (PDT) Return-Path: Received: from localhost.localdomain (c-73-67-244-238.hsd1.or.comcast.net. [73.67.244.238]) by smtp.gmail.com with ESMTPSA id e79sm2115369pfd.20.2016.06.01.14.27.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 01 Jun 2016 14:27:45 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Dmitry Torokhov , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Lee Jones , Jorge Ramirez-Ortiz , Wei Xu , Guodong Xu Subject: [RFC][PATCH 3/5] hi655x-pmic: Fixup issue with un-acked interrupts Date: Wed, 1 Jun 2016 14:27:38 -0700 Message-Id: <1464816460-18750-4-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1464816460-18750-1-git-send-email-john.stultz@linaro.org> References: <1464816460-18750-1-git-send-email-john.stultz@linaro.org> While trying to get the powerkey to function, I found when pressing the key, I would get infinitely repeating interrupts. After digging around a bit, it seems we didn't set the ack_base value for the regmap irqchip logic, so nothing was acking the interrupt. This patch adds the ack_base, which seems to make things work. Cc: Dmitry Torokhov Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: Lee Jones Cc: Jorge Ramirez-Ortiz Cc: Wei Xu Cc: Guodong Xu Signed-off-by: John Stultz --- drivers/mfd/hi655x-pmic.c | 1 + 1 file changed, 1 insertion(+) -- 1.9.1 Acked-by: Lee Jones diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c index 3511035..4a3fdbc 100644 --- a/drivers/mfd/hi655x-pmic.c +++ b/drivers/mfd/hi655x-pmic.c @@ -50,6 +50,7 @@ static const struct regmap_irq_chip hi655x_irq_chip = { .num_regs = 1, .num_irqs = ARRAY_SIZE(hi655x_irqs), .status_base = HI655X_IRQ_STAT_BASE, + .ack_base = HI655X_IRQ_STAT_BASE, .mask_base = HI655X_IRQ_MASK_BASE, };