From patchwork Wed May 11 19:23:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jones X-Patchwork-Id: 67615 Delivered-To: patch@linaro.org Received: by 10.140.92.199 with SMTP id b65csp387112qge; Wed, 11 May 2016 12:23:24 -0700 (PDT) X-Received: by 10.98.98.69 with SMTP id w66mr7585679pfb.20.1462994604584; Wed, 11 May 2016 12:23:24 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q6si11754751paq.16.2016.05.11.12.23.24; Wed, 11 May 2016 12:23:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932129AbcEKTXW (ORCPT + 29 others); Wed, 11 May 2016 15:23:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59372 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751462AbcEKTXV (ORCPT ); Wed, 11 May 2016 15:23:21 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E55C57F6B0; Wed, 11 May 2016 19:23:20 +0000 (UTC) Received: from hawk.localdomain.com (ovpn-204-47.brq.redhat.com [10.40.204.47]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4BJNIvB022656; Wed, 11 May 2016 15:23:19 -0400 From: Andrew Jones To: linux-kernel@vger.kernel.org Cc: sudeep.holla@arm.com, marc.zyngier@arm.com Subject: [PATCH] irqchip/gic-v3: fix quiescence check in gic_enable_redist Date: Wed, 11 May 2016 21:23:17 +0200 Message-Id: <1462994597-6299-1-git-send-email-drjones@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 11 May 2016 19:23:20 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Andrew Jones --- I'm unaware of any problems this may have caused. I only just saw it while reading over the code. drivers/irqchip/irq-gic-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.4.11 diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index 5b7d3c2129d87..518bc1799b4dc 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -147,7 +147,7 @@ static void gic_enable_redist(bool enable) while (count--) { val = readl_relaxed(rbase + GICR_WAKER); - if (enable ^ (val & GICR_WAKER_ChildrenAsleep)) + if (enable ^ (bool)(val & GICR_WAKER_ChildrenAsleep)) break; cpu_relax(); udelay(1);