From patchwork Fri Apr 22 14:32:05 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yingjoe Chen X-Patchwork-Id: 66453 Delivered-To: patch@linaro.org Received: by 10.140.93.198 with SMTP id d64csp755874qge; Fri, 22 Apr 2016 07:32:22 -0700 (PDT) X-Received: by 10.98.12.154 with SMTP id 26mr28949742pfm.20.1461335542396; Fri, 22 Apr 2016 07:32:22 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gl9si7993610pac.111.2016.04.22.07.32.22; Fri, 22 Apr 2016 07:32:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754250AbcDVOcU (ORCPT + 29 others); Fri, 22 Apr 2016 10:32:20 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:47510 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753336AbcDVOcT (ORCPT ); Fri, 22 Apr 2016 10:32:19 -0400 Received: from mtkhts09.mediatek.inc [(172.21.101.70)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 76148047; Fri, 22 Apr 2016 22:32:14 +0800 Received: from mtksdtcf02.mediatek.inc (10.21.12.142) by mtkhts09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 14.3.266.1; Fri, 22 Apr 2016 22:32:13 +0800 From: Yingjoe Chen To: Andy Whitcroft , Joe Perches CC: , Andi Kleen , Paul Bolle , , Yingjoe Chen Subject: [PATCH v2 1/3] checkpatch: add Kconfig 'default n' test Date: Fri, 22 Apr 2016 22:32:05 +0800 Message-ID: <1461335527-19270-1-git-send-email-yingjoe.chen@mediatek.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If a Kconfig config option doesn't specify 'default', the default will be n. Adding 'default n' is unnecessary. Add a test to warn about this. Signed-off-by: Yingjoe Chen --- Change in v2: - Change according to Joe Perches' suggestion scripts/checkpatch.pl | 7 +++++++ 1 file changed, 7 insertions(+) -- 1.9.1 diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d574d13..3cb7c2d 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2600,6 +2600,13 @@ sub process { "Use of boolean is deprecated, please use bool instead.\n" . $herecurr); } +# discourage the use of default n + if ($realfile =~ /Kconfig/ && + $line =~ /^\+\s*default\s*n\s*(#.*|$)/i) { + WARN("CONFIG_DEFAULT_N", + "Use of default n is unnecessary, default is n when omitted.\n" . $herecurr); + } + if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) && ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) { my $flag = $1;