From patchwork Fri Apr 22 07:29:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 66416 Delivered-To: patch@linaro.org Received: by 10.140.93.198 with SMTP id d64csp567326qge; Fri, 22 Apr 2016 00:29:53 -0700 (PDT) X-Received: by 10.98.98.131 with SMTP id w125mr26316056pfb.112.1461310193392; Fri, 22 Apr 2016 00:29:53 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w10si5440108pfa.53.2016.04.22.00.29.53; Fri, 22 Apr 2016 00:29:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752245AbcDVH3v (ORCPT + 29 others); Fri, 22 Apr 2016 03:29:51 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:34841 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751681AbcDVH3u (ORCPT ); Fri, 22 Apr 2016 03:29:50 -0400 Received: by mail-wm0-f43.google.com with SMTP id e201so8565389wme.0 for ; Fri, 22 Apr 2016 00:29:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=N2G9dOSyTt5dbTgegepVg2Ov93VVISvhGK89jICtAhE=; b=dqjXLyxg7UQvbksOf6+ausCKuee31r6whUOwXDwUvoXiJ86SWYVMSfHoYld08KcyyW 4xuhagLTVrMsDS2k+13a/PXRHQzCPu41EANCAASdRfit7QgQ1W7iZz9FhQsh/TvFlube Qr1k23u/1BeTv4kFErLTywJ1cTuEIPvWmB2+8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=N2G9dOSyTt5dbTgegepVg2Ov93VVISvhGK89jICtAhE=; b=X0L6DlW2sXNLMSR4pAmWKxR6LkXldg+9OPIKu+p0ulaoDWc4x1d1deGsSOI0VB9eLh RiuxK7BxoSzqMIpIxTMujy0h0QZikfh0ee4fRKvBnSaa5g4TlyEKUKOB5NsCXXK53SPB +9g9O6StWXjMd0nLyP+3C+WIzJAZT6ZslCFsFd6NVEfXTsshiyvjdeIWYifvFayhF5Zc vzijZlz2b3vi5ehlQ3lWcsokBkc4bQN86sP3uFdWBmUsXLfIgk4nlc9qX/bOU23U5aqf QOA7CS9L9F3/c7UI5882HhCr3qcMJLzSwQeh3miOrBdZEoKq24dNyoYQnt/77Bkcf5UA 6RNQ== X-Gm-Message-State: AOPr4FXGzdvnJM/SHBLYlL95qEJw+CX10dikaYoVMgKRBOaOx/U3p0mlTZBIFv4KH+D+7T90 X-Received: by 10.28.139.129 with SMTP id n123mr2072274wmd.13.1461310188983; Fri, 22 Apr 2016 00:29:48 -0700 (PDT) Received: from localhost.localdomain (sju31-1-78-210-255-2.fbx.proxad.net. [78.210.255.2]) by smtp.gmail.com with ESMTPSA id ju3sm615019wjb.11.2016.04.22.00.29.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 22 Apr 2016 00:29:48 -0700 (PDT) From: Daniel Lezcano To: tglx@linutronix.de Cc: mingo@kernel.org, Marc Gonzalez , linux-kernel@vger.kernel.org (open list:CLOCKSOURCE, CLOC...) Subject: [PATCH] clocksource/drivers/tango-xtal: Fix boot hang due to incorrect test Date: Fri, 22 Apr 2016 09:29:22 +0200 Message-Id: <1461310162-14701-1-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <20160422072717.GB18670@linaro.org> References: <20160422072717.GB18670@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 0881841f7e78 introduced a regression by inverting a test check after calling clocksource_mmio_init(). That results on the system to hang at boot time. Fix it by inverting the test again. Fixes: 0881841f7e78 ("Replace code by clocksource_mmio_init") Reported-by: Marc Gonzalez Signed-off-by: Daniel Lezcano --- drivers/clocksource/tango_xtal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.9.1 diff --git a/drivers/clocksource/tango_xtal.c b/drivers/clocksource/tango_xtal.c index 2bcecaf..c407c47 100644 --- a/drivers/clocksource/tango_xtal.c +++ b/drivers/clocksource/tango_xtal.c @@ -42,7 +42,7 @@ static void __init tango_clocksource_init(struct device_node *np) ret = clocksource_mmio_init(xtal_in_cnt, "tango-xtal", xtal_freq, 350, 32, clocksource_mmio_readl_up); - if (!ret) { + if (ret) { pr_err("%s: registration failed\n", np->full_name); return; }