From patchwork Fri Apr 15 18:20:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Nan X-Patchwork-Id: 65962 Delivered-To: patch@linaro.org Received: by 10.140.93.198 with SMTP id d64csp76725qge; Fri, 15 Apr 2016 11:21:15 -0700 (PDT) X-Received: by 10.98.0.202 with SMTP id 193mr30874072pfa.120.1460744475418; Fri, 15 Apr 2016 11:21:15 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n72si8849582pfj.204.2016.04.15.11.21.15; Fri, 15 Apr 2016 11:21:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751587AbcDOSVL (ORCPT + 29 others); Fri, 15 Apr 2016 14:21:11 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:15434 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751147AbcDOSVI (ORCPT ); Fri, 15 Apr 2016 14:21:08 -0400 Received: from 172.24.1.48 (EHLO szxeml422-hub.china.huawei.com) ([172.24.1.48]) by szxrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DFJ76227; Sat, 16 Apr 2016 02:20:38 +0800 (CST) Received: from linux-4hy3.site (10.107.193.248) by szxeml422-hub.china.huawei.com (10.82.67.152) with Microsoft SMTP Server id 14.3.235.1; Sat, 16 Apr 2016 02:20:25 +0800 From: Wang Nan To: , CC: , , Wang Nan , Adrian Hunter , Jiri Olsa , Masami Hiramatsu , Namhyung Kim , Zefan Li , He Kuang , Arnaldo Carvalho de Melo Subject: [PATCH v3 2/6] perf record: Split output into multiple files via '--switch-output' Date: Fri, 15 Apr 2016 18:20:16 +0000 Message-ID: <1460744420-175165-3-git-send-email-wangnan0@huawei.com> X-Mailer: git-send-email 1.8.3.4 In-Reply-To: <1460744420-175165-1-git-send-email-wangnan0@huawei.com> References: <1460744420-175165-1-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.107.193.248] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.571130F7.0026, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 5c2877726413293cba09e972cb9808c8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Allow 'perf record' to split its output into multiple files. For example: # ~/perf record -a --timestamp-filename --switch-output & [1] 10763 # kill -s SIGUSR2 10763 [ perf record: dump data: Woken up 1 times ] # [ perf record: Dump perf.data.2015122622314468 ] # kill -s SIGUSR2 10763 [ perf record: dump data: Woken up 1 times ] # [ perf record: Dump perf.data.2015122622314762 ] # kill -s SIGUSR2 10763 [ perf record: dump data: Woken up 1 times ] #[ perf record: Dump perf.data.2015122622315171 ] # fg perf record -a --timestamp-filename --switch-output ^C[ perf record: Woken up 1 times to write data ] [ perf record: Dump perf.data.2015122622315513 ] [ perf record: Captured and wrote 0.014 MB perf.data. (296 samples) ] # ls -l total 920 -rw------- 1 root root 797692 Dec 26 22:31 perf.data.2015122622314468 -rw------- 1 root root 59960 Dec 26 22:31 perf.data.2015122622314762 -rw------- 1 root root 59912 Dec 26 22:31 perf.data.2015122622315171 -rw------- 1 root root 19220 Dec 26 22:31 perf.data.2015122622315513 Signed-off-by: Wang Nan Tested-by: Arnaldo Carvalho de Melo Cc: Adrian Hunter Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Namhyung Kim Cc: Zefan Li Cc: pi3orama@163.com Link: http://lkml.kernel.org/r/1460643725-167413-3-git-send-email-wangnan0@huawei.com Signed-off-by: He Kuang [ Added man page entry ] Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/Documentation/perf-record.txt | 8 ++++++ tools/perf/builtin-record.c | 44 +++++++++++++++++++++++++++----- 2 files changed, 45 insertions(+), 7 deletions(-) -- 1.8.3.4 diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt index 19aa175..a77a431 100644 --- a/tools/perf/Documentation/perf-record.txt +++ b/tools/perf/Documentation/perf-record.txt @@ -347,6 +347,14 @@ Configure all used events to run in kernel space. --all-user:: Configure all used events to run in user space. +--switch-output:: +Generate multiple perf.data files, timestamp prefixed, switching to a new one +when receiving a SIGUSR2. + +A possible use case is to, given an external event, slice the perf.data file +that gets then processed, possibly via a perf script, to decide if that +particular perf.data snapshot should be kept or not. + SEE ALSO -------- linkperf:perf-stat[1], linkperf:perf-list[1] diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index cfaa2df..5cb1e3d 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -58,6 +58,7 @@ struct record { bool no_buildid_cache_set; bool buildid_all; bool timestamp_filename; + bool switch_output; unsigned long long samples; }; @@ -130,6 +131,8 @@ static volatile int child_finished; static DEFINE_TRIGGER(auxtrace_snapshot, OFF); +static DEFINE_TRIGGER(switch_output, OFF); + static void sig_handler(int sig) { if (sig == SIGCHLD) @@ -649,9 +652,12 @@ static int __cmd_record(struct record *rec, int argc, const char **argv) signal(SIGINT, sig_handler); signal(SIGTERM, sig_handler); - if (rec->opts.auxtrace_snapshot_mode) { + if (rec->opts.auxtrace_snapshot_mode || rec->switch_output) { signal(SIGUSR2, snapshot_sig_handler); - auxtrace_snapshot_on(); + if (rec->opts.auxtrace_snapshot_mode) + auxtrace_snapshot_on(); + if (rec->switch_output) + switch_output_on(); } else { signal(SIGUSR2, SIG_IGN); } @@ -781,11 +787,13 @@ static int __cmd_record(struct record *rec, int argc, const char **argv) } auxtrace_snapshot_release(); + switch_output_release(); for (;;) { unsigned long long hits = rec->samples; if (record__mmap_read_all(rec) < 0) { auxtrace_snapshot_error(); + switch_output_error(); err = -1; goto out_child; } @@ -801,6 +809,22 @@ static int __cmd_record(struct record *rec, int argc, const char **argv) } } + if (switch_output_is_toggled()) { + switch_output_release(); + + if (!quiet) + fprintf(stderr, "[ perf record: dump data: Woken up %ld times ]\n", + waking); + waking = 0; + fd = record__switch_output(rec, false); + if (fd < 0) { + pr_err("Failed to switch to new file\n"); + switch_output_error(); + err = fd; + goto out_child; + } + } + if (hits == rec->samples) { if (done || draining) break; @@ -829,6 +853,7 @@ static int __cmd_record(struct record *rec, int argc, const char **argv) } } auxtrace_snapshot_off(); + switch_output_off(); if (forks && workload_exec_errno) { char msg[STRERR_BUFSIZE]; @@ -1259,6 +1284,8 @@ struct option __record_options[] = { "Record build-id of all DSOs regardless of hits"), OPT_BOOLEAN(0, "timestamp-filename", &record.timestamp_filename, "append timestamp to output filename"), + OPT_BOOLEAN(0, "switch-output", &record.switch_output, + "Switch output when receive SIGUSR2"), OPT_END() }; @@ -1407,9 +1434,12 @@ out_symbol_exit: static void snapshot_sig_handler(int sig __maybe_unused) { - if (!auxtrace_snapshot_is_released()) - return; - auxtrace_snapshot_toggle(); - if (auxtrace_record__snapshot_start(record.itr)) - auxtrace_snapshot_error(); + if (auxtrace_snapshot_is_released()) { + auxtrace_snapshot_toggle(); + if (auxtrace_record__snapshot_start(record.itr)) + auxtrace_snapshot_error(); + } + + if (switch_output_is_released()) + switch_output_toggle(); }