From patchwork Fri Apr 8 21:57:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeremy Linton X-Patchwork-Id: 65426 Delivered-To: patch@linaro.org Received: by 10.112.43.237 with SMTP id z13csp299599lbl; Fri, 8 Apr 2016 14:58:14 -0700 (PDT) X-Received: by 10.67.23.161 with SMTP id ib1mr15139571pad.156.1460152694617; Fri, 08 Apr 2016 14:58:14 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id yx1si3009185pab.52.2016.04.08.14.58.14; Fri, 08 Apr 2016 14:58:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932816AbcDHV6I (ORCPT + 29 others); Fri, 8 Apr 2016 17:58:08 -0400 Received: from foss.arm.com ([217.140.101.70]:41777 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759046AbcDHV5N (ORCPT ); Fri, 8 Apr 2016 17:57:13 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5D4DB254; Fri, 8 Apr 2016 14:56:01 -0700 (PDT) Received: from u200856.usa.arm.com (unknown [10.118.28.91]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7A2063F487; Fri, 8 Apr 2016 14:57:12 -0700 (PDT) From: Jeremy Linton To: linux-kernel@vger.kernel.org Cc: will.deacon@arm.com, mark.rutland@arm.com, peterz@infradead.org, mingo@redhat.com, catalin.marinas@arm.com, msalter@redhat.com, timur@codeaurora.org, nleeder@codeaurora.org, agustinv@codeaurora.org, sfr@canb.auug.org.au, Jeremy Linton Subject: [PATCH 1/4] arm: pmu: Fix non-devicetree probing Date: Fri, 8 Apr 2016 16:57:04 -0500 Message-Id: <1460152627-3248-2-git-send-email-jeremy.linton@arm.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1460152627-3248-1-git-send-email-jeremy.linton@arm.com> References: <1460152627-3248-1-git-send-email-jeremy.linton@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mark Salter There is a problem in the non-devicetree PMU probing where some probe functions may get the number of supported events through smp_call_function_any() using the arm_pmu supported_cpus mask. But at the time the probe function is called, the supported_cpus mask is empty so the call fails. This patch makes sure the mask is set before calling the init function rather than after. Signed-off-by: Mark Salter Signed-off-by: Jeremy Linton --- drivers/perf/arm_pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.4.3 diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c index 32346b5..49fa845 100644 --- a/drivers/perf/arm_pmu.c +++ b/drivers/perf/arm_pmu.c @@ -997,8 +997,8 @@ int arm_pmu_device_probe(struct platform_device *pdev, if (!ret) ret = init_fn(pmu); } else { - ret = probe_current_pmu(pmu, probe_table); cpumask_setall(&pmu->supported_cpus); + ret = probe_current_pmu(pmu, probe_table); } if (ret) {