From patchwork Tue Apr 5 22:56:18 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanimir Varbanov X-Patchwork-Id: 65144 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp730710lbc; Tue, 5 Apr 2016 15:57:27 -0700 (PDT) X-Received: by 10.98.14.68 with SMTP id w65mr33524655pfi.144.1459897046966; Tue, 05 Apr 2016 15:57:26 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 65si28709260pfk.202.2016.04.05.15.57.26; Tue, 05 Apr 2016 15:57:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760020AbcDEW5R (ORCPT + 29 others); Tue, 5 Apr 2016 18:57:17 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:37997 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753553AbcDEW5H (ORCPT ); Tue, 5 Apr 2016 18:57:07 -0400 Received: by mail-wm0-f48.google.com with SMTP id u206so22635084wme.1 for ; Tue, 05 Apr 2016 15:57:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=G5B5lOWQAKHV+tfsO71aBn5lrupbJjb4RD8WNUcEsmQ=; b=ElXe0Nnb1xlpwCfEzVMeROUoSgTViPwtpDfhOw09DPDkJLYgoRCIpTS+ZKZ/QVQ8v8 6GpKfOZGt0gWcOXTzN2OgDF5HiPXBBt+rjaXXeJVOqpH4B5YKoRsPwYTzH5EhpEqhSnm g3P4FHcr/9nAmlhdgQbhFAoKgXEcuSguYqMc8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=G5B5lOWQAKHV+tfsO71aBn5lrupbJjb4RD8WNUcEsmQ=; b=DVnB1kNlyMqtkG3EClvMLTiqoVZYyG0YeJdbXMFNz8iXy/+tav17IW8kKwbXvkeRCE V75kH7SObyJP87J9WARxKjc/gifX6oZJR8jcKWtTemO4WLy/Np5uEAgJkG2pvZK2b70j sPht/f3e0glG15oXfQbgacERzs9VI/MH0abFtI7yVzgNdmoL114DLk8fAr90t0OgrYk+ gf01xTOMNL1fmYk8Xt8VpOvcm42qi8e8IXdxrt2uQZM1KyIYt3thpbHHF6SqY8s0hXLN 6/Yvn37VRqPca8PRTklz8lReBgS84Yz+RZomY3tqxxqABHZkv/L8yi840X71tjpE3E1A oQCg== X-Gm-Message-State: AD7BkJLM7rr3gFuWSnujuEXcUdMO5K7cBZfSZ7T+mqN8BtTKOXSFLPkJ7SeiOjCLoUyMhEmP X-Received: by 10.194.9.201 with SMTP id c9mr16868068wjb.7.1459897026167; Tue, 05 Apr 2016 15:57:06 -0700 (PDT) Received: from localhost.localdomain (hst-221-11.medicom.bg. [84.238.221.11]) by smtp.gmail.com with ESMTPSA id n3sm21914wja.6.2016.04.05.15.57.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 05 Apr 2016 15:57:05 -0700 (PDT) From: Stanimir Varbanov To: Rob Herring , Mark Rutland , Vinod Koul , Andy Gross Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, Sinan Kaya , Pramod Gurav , Stanimir Varbanov Subject: [PATCH v2 1/5] dmaengine: qcom: bam_dma: fix dma free memory on remove Date: Wed, 6 Apr 2016 01:56:18 +0300 Message-Id: <1459896982-30171-2-git-send-email-stanimir.varbanov@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1459896982-30171-1-git-send-email-stanimir.varbanov@linaro.org> References: <1459896982-30171-1-git-send-email-stanimir.varbanov@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Building the driver as a module and when removing the already inserted module gives below: [ 1389.392788] Unable to handle kernel paging request at virtual address ffffffbdc000001c [ 1389.421321] pgd = ffffffc02fa87000 [ 1389.447899] [ffffffbdc000001c] *pgd=0000000000000000, *pud=0000000000000000 [ 1389.460142] Internal error: Oops: 96000006 [#1] PREEMPT SMP [ 1389.466963] Modules linked in: qcom_bam_dma(-) [ 1389.486608] CPU: 2 PID: 2442 Comm: rmmod Not tainted 4.2.0+ #407 [ 1389.493885] Hardware name: Qualcomm Technologies, Inc. APQ 8016 SBC (DT) [ 1389.501196] task: ffffffc035bae2c0 ti: ffffffc0368a8000 task.ti: ffffffc0368a8000 [ 1389.508566] PC is at __free_pages+0xc/0x40 [ 1389.515893] LR is at free_pages.part.93+0x30/0x38 [ 1389.523141] pc : [] lr : [] pstate: 80000145 [ 1389.530602] sp : ffffffc0368abc20 [ 1389.537931] x29: ffffffc0368abc20 x28: ffffffc0368a8000 [ 1389.549153] x27: 0000000000000000 x26: 0000000000000000 [ 1389.560412] x25: ffffffc000cb2000 x24: 0000000000000170 [ 1389.571530] x23: 0000000000000004 x22: ffffffc036bc5010 [ 1389.582721] x21: ffffffc036bc5010 x20: 0000000000000000 [ 1389.593981] x19: 0000000000000002 x18: 0000007fcbc8e8b0 [ 1389.605301] x17: 0000007f9b8226ec x16: ffffffc0002089e8 [ 1389.616647] x15: 0000007f9b8a0588 x14: 0ffffffffffffffc [ 1389.628039] x13: 0000000000000030 x12: 0000000000000000 [ 1389.639436] x11: 0000000000000008 x10: ffffffc000ecc000 [ 1389.650872] x9 : ffffffc035bae2c0 x8 : ffffffc035bae9a8 [ 1389.662367] x7 : ffffffc035bae9a0 x6 : 0000000000000000 [ 1389.673906] x5 : ffffffbdc000001c x4 : 0000000080000000 [ 1389.685475] x3 : ffffffbdc0000000 x2 : 0000004080000000 [ 1389.697049] x1 : 0000000000000003 x0 : ffffffbdc0000000 The memory has been already freed by bam_free_chan() so fix this by skiping already freed memory. Signed-off-by: Stanimir Varbanov --- drivers/dma/qcom/bam_dma.c | 3 +++ 1 file changed, 3 insertions(+) -- 1.9.1 diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c index d5e0a9c3ad5d..a486bc0f82e0 100644 --- a/drivers/dma/qcom/bam_dma.c +++ b/drivers/dma/qcom/bam_dma.c @@ -1234,6 +1234,9 @@ static int bam_dma_remove(struct platform_device *pdev) bam_dma_terminate_all(&bdev->channels[i].vc.chan); tasklet_kill(&bdev->channels[i].vc.task); + if (!bdev->channels[i].fifo_virt) + continue; + dma_free_wc(bdev->dev, BAM_DESC_FIFO_SIZE, bdev->channels[i].fifo_virt, bdev->channels[i].fifo_phys);