From patchwork Wed Mar 23 14:43:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 64238 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp74698lbc; Wed, 23 Mar 2016 07:46:52 -0700 (PDT) X-Received: by 10.98.10.136 with SMTP id 8mr4883428pfk.67.1458744412667; Wed, 23 Mar 2016 07:46:52 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s69si4808318pfi.105.2016.03.23.07.46.52; Wed, 23 Mar 2016 07:46:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755691AbcCWOqv (ORCPT + 29 others); Wed, 23 Mar 2016 10:46:51 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:36888 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755438AbcCWOpy (ORCPT ); Wed, 23 Mar 2016 10:45:54 -0400 Received: by mail-wm0-f53.google.com with SMTP id p65so27549724wmp.0 for ; Wed, 23 Mar 2016 07:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ezb/aqnkIRj+INKB2Idj1rPK6DPl4GzF/uIdHfGZtSo=; b=Gt8iIDwN4brQFlexhIvto7lIQTFkZ30SRH2ksRjFHSH4bjR/SsYNz5a0ED/RYFUFjS utY1gAN7veUTTvF2MOPPpjelKpTdxa+g99MEeiUWVO45p0EZvIgWpk6Kqb6mFeBoop8n tYLBnxNGhI1aNFHzEeb3JerafuWI6X+H0NDf0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ezb/aqnkIRj+INKB2Idj1rPK6DPl4GzF/uIdHfGZtSo=; b=KiWLUaPm981fguud/Jeb20cu57nwFeMt8sr5JQWPPYdBJajK0GqQdxjLjiqCjWFKm7 jEiH3AExOlqnTX7I86SH151grZpAZEHScA1X3SSnSAexqH4XbvXIykMcb1LUAtKqAGbP 4tyDn/zZ7COh5SkBAn4iwaBsy8HaqQtsNlXqlLDDDnVhpG24kU4dd/xy+sJ1HBq9O3P2 DwMlqEr8l9jD5DyZ/UXcrrEH0csdN7+vtgvFDJxDHzxTy9laP6QM2kYEhspEMuLIK+xy E/FmB2bQ39W7hf+Lr4PQq3eva8GuHYmyAsHAm2+dFt3u3CF6z+LRhDhODqBu3mEKZBoT p5EA== X-Gm-Message-State: AD7BkJK1YFjJGm5jABmjBoqW3btTLomoDpvsUdbCo8nmAXpP0LEHSCT9lqrsD6sVIarH+M06 X-Received: by 10.28.6.139 with SMTP id 133mr27590220wmg.84.1458744353066; Wed, 23 Mar 2016 07:45:53 -0700 (PDT) Received: from localhost.localdomain (host81-129-172-93.range81-129.btcentralplus.com. [81.129.172.93]) by smtp.gmail.com with ESMTPSA id 192sm3339980wmw.0.2016.03.23.07.45.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 23 Mar 2016 07:45:52 -0700 (PDT) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: kernel@stlinux.com, maxime.coquelin@st.com, jassisinghbrar@gmail.com, dan.carpenter@oracle.com, Lee Jones Subject: [PATCH v2 5/5] mailbox: Stop using ENOSYS for anything other than unimplemented syscalls Date: Wed, 23 Mar 2016 14:43:43 +0000 Message-Id: <1458744223-12164-6-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1458744223-12164-1-git-send-email-lee.jones@linaro.org> References: <1458744223-12164-1-git-send-email-lee.jones@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In accordance with e15f431fe2d5 ("errno.h: Improve ENOSYS's comment") and 91c9afaf97ee ("checkpatch.pl: new instances of ENOSYS are errors") we're converting from the old meaning of: ENOSYS "Function not implemented" to a more standard EINVAL. Reported-by: Seraphin Bonnaffe Signed-off-by: Lee Jones --- drivers/mailbox/mailbox.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 1.9.1 diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 6a4811f..4a36632 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -375,13 +375,13 @@ struct mbox_chan *mbox_request_channel_byname(struct mbox_client *cl, if (!np) { dev_err(cl->dev, "%s() currently only supports DT\n", __func__); - return ERR_PTR(-ENOSYS); + return ERR_PTR(-EINVAL); } if (!of_get_property(np, "mbox-names", NULL)) { dev_err(cl->dev, "%s() requires an \"mbox-names\" property\n", __func__); - return ERR_PTR(-ENOSYS); + return ERR_PTR(-EINVAL); } of_property_for_each_string(np, "mbox-names", prop, mbox_name) {