From patchwork Thu Mar 17 12:29:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102550 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp435158lbc; Thu, 17 Mar 2016 05:31:01 -0700 (PDT) X-Received: by 10.98.7.135 with SMTP id 7mr14375209pfh.124.1458217859610; Thu, 17 Mar 2016 05:30:59 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 69si6081025pfk.13.2016.03.17.05.30.59; Thu, 17 Mar 2016 05:30:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935862AbcCQMaz (ORCPT + 31 others); Thu, 17 Mar 2016 08:30:55 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:63441 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753008AbcCQMay (ORCPT ); Thu, 17 Mar 2016 08:30:54 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue003) with ESMTPA (Nemesis) id 0MAReI-1aUxHH1bRK-00Bboz; Thu, 17 Mar 2016 13:30:25 +0100 From: Arnd Bergmann To: Vinayak Holikatti , "James E.J. Bottomley" , "Martin K. Petersen" Cc: Arnd Bergmann , Yaniv Gardi , Stephen Boyd , James Bottomley , Hannes Reinecke , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi: ufs: select CONFIG_NLS Date: Thu, 17 Mar 2016 13:29:52 +0100 Message-Id: <1458217819-2802119-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:v3fxH5cODC+RuRDjIW7arKHyD78pAwSHHDxrr9HAOA/chy2CzPr lbvCQRu3ISlcq2GOWmyNSr8uJw0oAVDmteRfYJ/Uc8w1vq33yWnIviCqhSgKFP6F3+2HCHW vcGMt9+HOn1B54xBkLplt6FgRCMgZbl/FkQ1L/xe4WicwcQWMYHwB77I/43pw+c+NvRhkmF mRqVMsyePj/E/HBLu+6QA== X-UI-Out-Filterresults: notjunk:1; V01:K0:2mWbzA21Syw=:NPEeUEgLeYj255Vf9USYU6 yt0e/saytS0k8MjSr9o/vWKZzVKFK1Hon6UTibGITfPP6dtf+nwpFFVmBjdIiSy700Z7gvKuL F5m5aQR8qV8arTBfYHYhhynxj4Izz/hzaPZhXH4yFDygtDhHl8BCsFN/W+hJHPUxBlTnKRBAR bLxdwlAWC3MNABqaBpZ/MqoRmItiXN7bxWnKBCYn4O0+HZ+EHTRKPI9ot9KfgPM7KpPmxg1VF 6nSxWIJPp+gvuFBo8Wq/w4H6ve5YS3hJRXtWBvht+3lcNbrZgBCfp48HJ2MljIX32gmLOg9lT jzzx3esSAoj4IX8dTZZKgKdeuar+k/WkwDhyEkc9C0AkiV4J5C4hZm/075Cq9WNAbKZvwCKbv mdRZ77PDquzQ9zuoXAHzHmqlfPVO7MwLYDCUsnADXpKXI4g78LF7N2ql5C3iqy+mBpDtMHbXO r9hymwOcOtuFWqsCNwRk89iJgqUOrZRHQDIY+taqgVO8BrJ5S2fc3fVNGkaX5Wfb5Ucx7WR5B iSBP5gwo2mo0Lc8E+SdN4dVn8gM/SqzhDNruOk/rxiE6wl4nqOk+CbLg0G4m05MAodRe/GmBy wbwhHTBpsJRdHaLJlzDUgllIPDaBe2N0r4JwYETqlCjIaHa4KLfoWxL5/GcmjwMgCmIswaVlO l/BbsICL9YpiHC7+CSbfztZYXZ2fqpOHsSM720toO2ZmvD+Svojuxe5zY/eQTpoK/SjU= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A recent change to ufshcd introduced a call to utf16s_to_utf8s, a function that is provided by the NLS module, so we get a link error when that is not present: drivers/scsi/built-in.o: In function `ufshcd_read_string_desc': :(.text+0x124d0): undefined reference to `utf16s_to_utf8s' This adds a Kconfig 'select' statement to avoid the build error. Signed-off-by: Arnd Bergmann Fixes: b573d484e4ff ("scsi: ufs: add support to read device and string descriptors") --- drivers/scsi/ufs/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.7.0 diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig index 5f4530744e0a..097894a1fab5 100644 --- a/drivers/scsi/ufs/Kconfig +++ b/drivers/scsi/ufs/Kconfig @@ -37,6 +37,7 @@ config SCSI_UFSHCD depends on SCSI && SCSI_DMA select PM_DEVFREQ select DEVFREQ_GOV_SIMPLE_ONDEMAND + select NLS ---help--- This selects the support for UFS devices in Linux, say Y and make sure that you know the name of your UFS host adapter (the card