From patchwork Mon Mar 14 22:45:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102579 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp316463lbc; Mon, 14 Mar 2016 15:46:10 -0700 (PDT) X-Received: by 10.98.32.23 with SMTP id g23mr33735248pfg.74.1457995569965; Mon, 14 Mar 2016 15:46:09 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l80si21543312pfj.31.2016.03.14.15.46.09; Mon, 14 Mar 2016 15:46:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753527AbcCNWqI (ORCPT + 31 others); Mon, 14 Mar 2016 18:46:08 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:55755 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752005AbcCNWqG (ORCPT ); Mon, 14 Mar 2016 18:46:06 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue005) with ESMTPA (Nemesis) id 0MYrDT-1aIn4K1nZz-00VjBc; Mon, 14 Mar 2016 23:45:39 +0100 From: Arnd Bergmann To: Nicolas Pitre Cc: Arnd Bergmann , "David S. Miller" , Robert Jarzmik , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] smc91x: avoid self-comparison warning Date: Mon, 14 Mar 2016 23:45:12 +0100 Message-Id: <1457995535-1398186-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:Op+RkcZgKM+AvLwL5iO34ICxf03w88oelAibpg8uPJ7INQumNic HISnnMiRYYl4i8Fu9orUZidhXeSqshZ9YvpZ7YnxugAKTo6i9VerxS4mwdtRHnCErdBR/rf Ivav+8CL1d3fZRTHlHkTNhrNSHrBX1Ss0NKHsBF6Kqbamr2y20ucQQWmkmSo+EcJhuYvOF5 ob8T/Dg+2nGToQPPi6uEQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:Q6H63PTFTM8=:Rn8aCFLNUvKrkffl/Ru1F/ ZZqUcC1Vb+Gp8waM2FPj0CVlFRwhQ5B+ElGWULCH6qiD1B3OZHyjetAbdMIJI0SviDxHLBY/v 2/v3cE7SX+ZbciCQXd1QXbS1qkUs8H0GFfqrMvmodGzLoEuhDKQw5DhvGUX7SCHLSot44wa8x ZsHyQCA7Rb918eXyc0MxR6HK/JtY6yQybAiSl1K6pvoGtN7s1dWBXIG3QAkvmqqYBA++wk8ri PNR1LKxPIJlFkcrNMeMyYVQLbkhBRLL8qE6eWkbpYav+4x2L75lWKoql3s1RFLqeM+hh7i/pF 4o2jrYiETVwko5gwV7b5/Y0EuY2t/B7R8wQF5xqUV3nQd848E6rdhZeq4DA/7bYgJqMQykCxQ 87qLnNGn+kqQGWz0LFYv0MU0EY9DJ+N2VVPXN6vufn+j7DXGpR0ZaPAeuZzidc2FXANE/mvux BjTy7RtuxLpk/yHrndlsPsw85MaKWS+loqGP3oGdNaZu4kUgQdaCRHgGoJ0E+PHeCd/lxF1IX ZhwE3LenWpu4nnYWpj/BUPRXbz5cljVy98yQFGvv6iZew3qaJYp1rsyPOmYb7jG2Enqwv6lpP 8A0Y5nyn+q1iRrW58wjgEahCG2GwNGtKMoBu5EfhE38NviYOmV0qeJBVEa7+p6xOp92EzYJzp rN7Z7F6rfXYu11/3LUBuFbWb+tyKQqwGVwZNPQodICHGqVP1Z7q//6I9mPU37hi/eaOg= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The smc91x driver defines a macro that compares its argument to itself, apparently to get a true result while using its argument to avoid a warning about unused local variables. Unfortunately, this triggers a warning with gcc-6, as the comparison is obviously useless: drivers/net/ethernet/smsc/smc91x.c: In function 'smc_hardware_send_pkt': drivers/net/ethernet/smsc/smc91x.c:563:14: error: self-comparison always evaluates to true [-Werror=tautological-compare] if (!smc_special_trylock(&lp->lock, flags)) { This replaces the macro with another one that behaves similarly, with a cast to (void) to ensure the argument is used, and using a literal 'true' as its value. Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/smsc/smc91x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.0 diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c index db7db8ac4ca3..c5ed27c54724 100644 --- a/drivers/net/ethernet/smsc/smc91x.c +++ b/drivers/net/ethernet/smsc/smc91x.c @@ -540,7 +540,7 @@ static inline void smc_rcv(struct net_device *dev) #define smc_special_lock(lock, flags) spin_lock_irqsave(lock, flags) #define smc_special_unlock(lock, flags) spin_unlock_irqrestore(lock, flags) #else -#define smc_special_trylock(lock, flags) (flags == flags) +#define smc_special_trylock(lock, flags) ((void)flags, true) #define smc_special_lock(lock, flags) do { flags = 0; } while (0) #define smc_special_unlock(lock, flags) do { flags = 0; } while (0) #endif