From patchwork Mon Mar 14 14:49:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102586 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp80941lbc; Mon, 14 Mar 2016 07:50:50 -0700 (PDT) X-Received: by 10.66.141.76 with SMTP id rm12mr39180281pab.30.1457967050092; Mon, 14 Mar 2016 07:50:50 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v81si3737043pfi.169.2016.03.14.07.50.49; Mon, 14 Mar 2016 07:50:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965209AbcCNOur (ORCPT + 31 others); Mon, 14 Mar 2016 10:50:47 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:55837 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934381AbcCNOup (ORCPT ); Mon, 14 Mar 2016 10:50:45 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue005) with ESMTPA (Nemesis) id 0LyPw2-1ZiTLB09eY-015ucq; Mon, 14 Mar 2016 15:50:27 +0100 From: Arnd Bergmann To: Mark Brown Cc: Arnd Bergmann , Brian Austin , Paul Handrigan , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Axel Lin , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH v3] ASoC: cs35l32: avoid uninitialized variable access Date: Mon, 14 Mar 2016 15:49:54 +0100 Message-Id: <1457967019-3901380-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:AKb959CEoabO/7mFhYvSiEduUt0A/Dxu3Py4XXs1usWnW239b4r XRkW/Md5T66QgaYGlFLrBAE7Xja7d554BmYihfAM5d//Hq7JFa4o3Dnaql/d5sZchWBCJ5I i+GEPCShYLZ7jVN7y/x76X7Xuwk/8N/ScELLNikxSRh1VElvsI4kRaVd80t5y0PDDHBarBG /24eOQ1FSyr2q6VQ5stmw== X-UI-Out-Filterresults: notjunk:1; V01:K0:fE1pW0+X05k=:sRmX9riy6MzvbrokZYJUbh hnVqEpE8NJVSDop9WCHP289RCfmyJV7k9cvGmByUsjxrvuBa1SSCgd1tRYHQkZO+a2FgJk57L r4PgyKQnJkH668kEJxewL2ODegQJBUjDMCaqkc4JdZsOPy82brieKK5CzXXMZ6jIKb9F8P9T7 YjjJ1LXhaA4LUKuOq8EZApHQr6q6DigErwoqbltdjyDZkS+IqMShXi+yBf7TxCo+3x/FQ/ArW sqO7dhcJbvhJW09y8K3cLiLe1HkNZt+2Gz9lSgjE4No6M73SNartNJKtG4K68Cl52n3qAhXOW o+71xouMPSwt8aohPdEzYz8RbWtQ3dA0wNrM4F3I/4nWo2OCySKdwUzeWn2Pfae4m4EyjSeDU b3l2vGoDfGt0fIt3NWO8NC+GoksPcNS+psu72II8NS5lkKRCdYDgLkzvZ8MHO2QRWW9k3dPLa cvjcIebV/qMaDJgc9e5ScYDSRp14dVaYTmrV5B8VxCPfBsHK6IpR/dLywZHvyU0c0qhW0Z0Mo 8cpvA6vJcuK8DCZiA+pET31X1baq1OtLuimjFbwj9ogQAEuSLxT2QaGQUueuqxCN9huooQDx/ lLXeGN52zmjuza7NZN1PO+s6lARTAlkFgQuLJEfWUjKDONWrgIsnhU1VQMydKJl5HvY7nnSNe u8phiZOkXuVMHknx0Kjot+t08UGOKEVO+pBZpGwLlfP5jl9xt6XjLostIBktnqzh2TMo= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc warns about the possibilty of accessing a property read from devicetree in cs35l32_i2c_probe() when it has not been initialized because CONFIG_OF is disabled: sound/soc/codecs/cs35l32.c: In function 'cs35l32_i2c_probe': sound/soc/codecs/cs35l32.c:278:2: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized] The code is actually correct because it checks the dev->of_node variable first and we know this is NULL here when CONFIG_OF is disabled, but Russell King noticed that it's broken when we probe the device using DT, and the properties are absent. The code already has some checking for incorrect values, and I keep that checking unchanged here, but add an additional check for an error returned by the property accessor functions that now gets handled the same way as incorrect data in the properties. Signed-off-by: Arnd Bergmann --- v3: Restore a line that was accidentally removed, as pointed out by Brian Austin. v2: fix bug in case of CONFIG_OF and missing properties v1: only address warning for the !CONFIG_OF case sound/soc/codecs/cs35l32.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) -- 2.7.0 diff --git a/sound/soc/codecs/cs35l32.c b/sound/soc/codecs/cs35l32.c index 44c30fe3e315..287d13740be4 100644 --- a/sound/soc/codecs/cs35l32.c +++ b/sound/soc/codecs/cs35l32.c @@ -274,7 +274,9 @@ static int cs35l32_handle_of_data(struct i2c_client *i2c_client, if (of_property_read_u32(np, "cirrus,sdout-share", &val) >= 0) pdata->sdout_share = val; - of_property_read_u32(np, "cirrus,boost-manager", &val); + if (of_property_read_u32(np, "cirrus,boost-manager", &val)) + val = -1u; + switch (val) { case CS35L32_BOOST_MGR_AUTO: case CS35L32_BOOST_MGR_AUTO_AUDIO: @@ -282,13 +284,15 @@ static int cs35l32_handle_of_data(struct i2c_client *i2c_client, case CS35L32_BOOST_MGR_FIXED: pdata->boost_mng = val; break; + case -1u: default: dev_err(&i2c_client->dev, "Wrong cirrus,boost-manager DT value %d\n", val); pdata->boost_mng = CS35L32_BOOST_MGR_BYPASS; } - of_property_read_u32(np, "cirrus,sdout-datacfg", &val); + if (of_property_read_u32(np, "cirrus,sdout-datacfg", &val)) + val = -1u; switch (val) { case CS35L32_DATA_CFG_LR_VP: case CS35L32_DATA_CFG_LR_STAT: @@ -296,13 +300,15 @@ static int cs35l32_handle_of_data(struct i2c_client *i2c_client, case CS35L32_DATA_CFG_LR_VPSTAT: pdata->sdout_datacfg = val; break; + case -1u: default: dev_err(&i2c_client->dev, "Wrong cirrus,sdout-datacfg DT value %d\n", val); pdata->sdout_datacfg = CS35L32_DATA_CFG_LR; } - of_property_read_u32(np, "cirrus,battery-threshold", &val); + if (of_property_read_u32(np, "cirrus,battery-threshold", &val)) + val = -1u; switch (val) { case CS35L32_BATT_THRESH_3_1V: case CS35L32_BATT_THRESH_3_2V: @@ -310,13 +316,15 @@ static int cs35l32_handle_of_data(struct i2c_client *i2c_client, case CS35L32_BATT_THRESH_3_4V: pdata->batt_thresh = val; break; + case -1u: default: dev_err(&i2c_client->dev, "Wrong cirrus,battery-threshold DT value %d\n", val); pdata->batt_thresh = CS35L32_BATT_THRESH_3_3V; } - of_property_read_u32(np, "cirrus,battery-recovery", &val); + if (of_property_read_u32(np, "cirrus,battery-recovery", &val)) + val = -1u; switch (val) { case CS35L32_BATT_RECOV_3_1V: case CS35L32_BATT_RECOV_3_2V: @@ -326,6 +334,7 @@ static int cs35l32_handle_of_data(struct i2c_client *i2c_client, case CS35L32_BATT_RECOV_3_6V: pdata->batt_recov = val; break; + case -1u: default: dev_err(&i2c_client->dev, "Wrong cirrus,battery-recovery DT value %d\n", val);