From patchwork Mon Mar 14 14:18:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102591 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp66652lbc; Mon, 14 Mar 2016 07:24:16 -0700 (PDT) X-Received: by 10.66.255.39 with SMTP id an7mr38297629pad.2.1457965455920; Mon, 14 Mar 2016 07:24:15 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ey9si1274027pab.123.2016.03.14.07.24.15; Mon, 14 Mar 2016 07:24:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934415AbcCNOYN (ORCPT + 31 others); Mon, 14 Mar 2016 10:24:13 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:52549 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934376AbcCNOYK (ORCPT ); Mon, 14 Mar 2016 10:24:10 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue102) with ESMTPA (Nemesis) id 0Lud28-1ZfhkV3I6y-00zr7O; Mon, 14 Mar 2016 15:19:03 +0100 From: Arnd Bergmann To: "David S. Miller" Cc: netdev@vger.kernel.org, Arnd Bergmann , Dmitry Tarnyagin , linux-kernel@vger.kernel.org Subject: [PATCH 5/5] net: caif: fix misleading indentation Date: Mon, 14 Mar 2016 15:18:38 +0100 Message-Id: <1457965120-3155420-6-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1457965120-3155420-1-git-send-email-arnd@arndb.de> References: <1457965120-3155420-1-git-send-email-arnd@arndb.de> X-Provags-ID: V03:K0:fyRpTBThvSrKNYDSVTEVdRYyGD7IYqFLmSrgaM7JIrAK0hHX6p3 rTW7W/pWyG3zQk9PaU7IKPM9IOPVsQ7JK4Mse+YuLgGjbDW0AthDGXB4hubE4iYyI1RB/E7 7+0c6fygc63GxNyvY5DOwCadFVJzsTWJqKHgwIw6vjE/vc0lv0AiqwsRHIABxsw+DKEhtU0 raKDkTtsZE585iWZ/Eo5Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:CPVurz1wH/0=:7MOOnxxBywNWzxA6fa6jNY 27j2uAiRyJaa5Vj1a7ENXE1YmdquBPHwzx7Vi7nP27W25VogdSSh+HG2kC6UX0973fwA0Bn1E nDoMUAXjW5dB7M3/Yb15PJmHfCZA92JFMNqB7JAvuH38G6jcV6suK1Hf5PuLlP6dObJKYP0YR ewDVMYW9GQ6kc2LifJu105uw20vOxW+Cfr/GkB/vPMJaiNXAefXJCCtFG4Qyug8Jh/K89qMkh pbqnJIAE2T/afB1b8qlXbXNxYMayuUqyQXmn6eU6vhP9aPdJtdgdep54sl0tahl1atAUz5VbI XSo+yd8fgjDM1u0r0i9QruA5+CUtKXTciMRy2X8Aw+GBUNwWimceyn6QKgTRiq5tkv9ZNTEt5 OuOeuM9xnugqVei1cR/gy1ir/OnuWhVxI3Gfe+YuU8Si3kOAAWs53LshJzboFOS2yYtSvQtpB M0wOl7NOulrGWsD7nz51Nc5MhWiutlbpdPe4A/HISYPnbIIAxybE8m69LOs4cBFr3Ab13r1+e WXOcr1VYMpuH72RQHaiskzOiKjidRqIAw24w33AchFrLH6WEtovnnsOtgOLI/eCEANCY2SCxs IJmzYHio2QvODSHB2Cm3Y243DFlEjaJxxthh5VyNgLJvvOf2Egzt/a926EmIgajQ+jecoC/sA NauZWcohgV0JZptx6boKJnRMBGKIOocPewPdKg2Nliuv2y3Pli6EP4ffSiW/6oPbOW4s= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc points out code that is not indented the way it is interpreted: net/caif/cfpkt_skbuff.c: In function 'cfpkt_setlen': net/caif/cfpkt_skbuff.c:289:4: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation] return cfpkt_getlen(pkt); ^~~~~~ net/caif/cfpkt_skbuff.c:286:3: note: ...this 'else' clause, but it is not else ^~~~ It is clear from the context that not returning here would be a bug, as we'd end up passing a negative length into a function that takes a u16 length, so it is not missing curly braces here, and I'm assuming that the indentation is the only part that's wrong about it. Signed-off-by: Arnd Bergmann --- net/caif/cfpkt_skbuff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.0 diff --git a/net/caif/cfpkt_skbuff.c b/net/caif/cfpkt_skbuff.c index f6c3b2137eea..59ce1fcc220c 100644 --- a/net/caif/cfpkt_skbuff.c +++ b/net/caif/cfpkt_skbuff.c @@ -286,7 +286,7 @@ int cfpkt_setlen(struct cfpkt *pkt, u16 len) else skb_trim(skb, len); - return cfpkt_getlen(pkt); + return cfpkt_getlen(pkt); } /* Need to expand SKB */