From patchwork Mon Mar 14 14:07:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102599 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp57518lbc; Mon, 14 Mar 2016 07:08:27 -0700 (PDT) X-Received: by 10.98.80.22 with SMTP id e22mr30063520pfb.15.1457964506940; Mon, 14 Mar 2016 07:08:26 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g29si24892012pfj.135.2016.03.14.07.08.26; Mon, 14 Mar 2016 07:08:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755624AbcCNOIL (ORCPT + 31 others); Mon, 14 Mar 2016 10:08:11 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:63959 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932432AbcCNOIB (ORCPT ); Mon, 14 Mar 2016 10:08:01 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue103) with ESMTPA (Nemesis) id 0M4kN3-1ZuGGF11SP-00yzVt; Mon, 14 Mar 2016 15:07:30 +0100 From: Arnd Bergmann To: "David S. Miller" Cc: Arnd Bergmann , Felix Fietkau , John Crispin , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] net: mediatek: remove incorrect dma_mask assignment Date: Mon, 14 Mar 2016 15:07:11 +0100 Message-Id: <1457964435-2945038-2-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1457964435-2945038-1-git-send-email-arnd@arndb.de> References: <1457964435-2945038-1-git-send-email-arnd@arndb.de> X-Provags-ID: V03:K0:c+oOs4DQnn8zNXXBI173gbiySEyiymCwLtojUvmY/KKi2nJUk+R umGDRO7P5hwglx9/Wdr15lOQL8uF0fC8O360O2hPvKzZYFm1wzAxrnDsuPMkYm9kRTUiIA8 AP94Z8bGgFgdYuihja9KhPFmtPTe/9Ub3Bqh+9xnRfY7SCGpxbZsIXIuhrMqLTgxdQ14ANz FlZuQ9wVrPfjJ0T64FYcQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:J5dURJmAPKI=:WuzRkQMwY8C+W8b4qiNA5H x88B8QqCJHmGl7rf+q9n2Tz15CWpEQ4TzlZ1Kictr22JtincsXLDKrmRLDJVkFKgg8dGxOixz wfRgDNJpKVRsfB7yj2Ge6tXmK9mGg21kCT+XoXgW5GKeyelHu1rmC6Hinl1pl2Obu0INtcuf/ 03jygc5PkETBqgrPuxxaWUZcQD+1prqshL1r9FTNdytgnWXGEnIoJRRcfMqO7eng2WHTfH2+n wSX1cniRWNkhYoNzPxa2Rr8jSr2X1pOMcx6UZ1lMMUV0fkGEq5zw/cfiDlN9h/Q7J2KFgoUNj LfdLILpBJ3fKGF34EFu8kb32O7VhnCHSvI/SWPrEz8/tdmKTH0J7TUNq3weHzoCv13iI7DG2i aOW8nXBAvC/kquTegBBzrl+fLaud3pabwX5ekKl0AgPMNt/MEooaehIX3ASzUL2uGPe6xbdNA 3TNcmYMoCrQV8X1By1gXSe/044QEUKBvnu4AdpEkNAYb/ELWQbLEPfF7h5+2WOJcIEYYpNi2t tId5EPU48fL/tOltv2XZzffa57rER5Oyx6J9hKt9Ie3y3Lkx+syaclAQuBdVmJGzkhbsceaZt DVlPI3u2e2PHa+7nPwKVf1+oL9idZN6qQfI2x9aqL2GGKFt2i/2t5ByWh2EY4hQaX2/9vbr78 sCK2K3bvLGomPxxMYIu8jk+IVdYOQ1NosaO/FY4Tqyz37ql9jR7ebWi49cywIarawTIA= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Device drivers should not mess with the DMA mask directly, but instead call dma_set_mask() etc if needed. In case of the mtk_eth_soc driver, the mask already gets set correctly when the device is created, and setting it again is against the documented API. This removes the incorrect setting. Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 3 --- 1 file changed, 3 deletions(-) -- 2.7.0 diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index 3e42204adfe5..87f417712da0 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -1676,9 +1676,6 @@ static int mtk_probe(struct platform_device *pdev) struct mtk_eth *eth; int err; - pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32); - pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask; - device_reset(&pdev->dev); match = of_match_device(of_mtk_match, &pdev->dev);