From patchwork Thu Feb 18 00:51:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 62146 Delivered-To: patch@linaro.org Received: by 10.112.43.199 with SMTP id y7csp308770lbl; Wed, 17 Feb 2016 16:54:43 -0800 (PST) X-Received: by 10.98.93.1 with SMTP id r1mr6306598pfb.57.1455756883316; Wed, 17 Feb 2016 16:54:43 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t75si5435662pfa.9.2016.02.17.16.54.43; Wed, 17 Feb 2016 16:54:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dkim=pass header.i=@linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162068AbcBRAyk (ORCPT + 30 others); Wed, 17 Feb 2016 19:54:40 -0500 Received: from mail-ob0-f172.google.com ([209.85.214.172]:35605 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162010AbcBRAwW (ORCPT ); Wed, 17 Feb 2016 19:52:22 -0500 Received: by mail-ob0-f172.google.com with SMTP id xk3so42924451obc.2 for ; Wed, 17 Feb 2016 16:52:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jmB0sByZADXmLCUmcF+mG1fP5fgqFGFiQuczmzc/rsk=; b=D65J/UNVbJhBRtibDblmLPk6Um825I+hleiUsEL1W8ozx5/vIiJgtY4PdyC8dWcmVu rwgu6mLNWFMzNL6I5lrjS9OwyjuhXQU0aDGUmBukuTYW6lbgZc74aphqbprhVxrpLNaY 3R9EdEOYw9ZwcgDk9RHMHQGmG/e+13mmaKYhE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jmB0sByZADXmLCUmcF+mG1fP5fgqFGFiQuczmzc/rsk=; b=ayElDKwOrQz2ToS1Hq6Snf3jDTQBj8fwKwuxBcN4SLSoMY+RqO5dJ8nQGoPrVJ3ArF Hz1e11pONkfJWppLrgA6leUPB15a/4PfKWTFQWXTVJk835hbf7sK2VfJ/WEU5clWfAnP Rp6KYqWsPSM7KD+BjtzUN9iobLh6N6zLhosK/KYCwqwUpYOCCkf5rcbSRrlv5j3Fcm0s ibWf0phvD8AP8g2fecE5GA8c163+9eKqdntJC5NikSFm1M+IgM5Ylk17cMAcxQNeF/8A jwq7JAETUmtjJtn/sP1XtaTMeBFGgZCbOpUrm/8Te6s13H3Bms6tp7U9nn30sebQ7SuA VU+w== X-Gm-Message-State: AG10YOQkrgjiqx0yy0pqqUyjAc6KamgQg2AZvu5fVugKpKkSmRcsuJjj035HU2eEG6s5LI+O X-Received: by 10.202.48.8 with SMTP id w8mr3596695oiw.90.1455756741619; Wed, 17 Feb 2016 16:52:21 -0800 (PST) Received: from t430.globalsuite.net (h58.159.185.173.static.ip.windstream.net. [173.185.159.58]) by smtp.gmail.com with ESMTPSA id gi5sm2357650obb.6.2016.02.17.16.52.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 17 Feb 2016 16:52:21 -0800 (PST) From: Mathieu Poirier To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 16/21] coresight: etb10: moving to local atomic operations Date: Wed, 17 Feb 2016 17:51:58 -0700 Message-Id: <1455756723-8456-17-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1455756723-8456-1-git-send-email-mathieu.poirier@linaro.org> References: <1455756723-8456-1-git-send-email-mathieu.poirier@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Moving to use local atomic operations to take advantage of the lockless implementation, something that will come handy when the ETB is accessed from the Perf subsystem. Also changing the name of the variable to something more meaningful. Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-etb10.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) -- 2.1.4 diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c index 917562ecf82a..162c9ccc8c33 100644 --- a/drivers/hwtracing/coresight/coresight-etb10.c +++ b/drivers/hwtracing/coresight/coresight-etb10.c @@ -10,6 +10,7 @@ * GNU General Public License for more details. */ +#include #include #include #include @@ -71,7 +72,7 @@ * @csdev: component vitals needed by the framework. * @miscdev: specifics to handle "/dev/xyz.etb" entry. * @spinlock: only one at a time pls. - * @in_use: synchronise user space access to etb buffer. + * @reading: synchronise user space access to etb buffer. * @buf: area of memory where ETB buffer content gets sent. * @buffer_depth: size of @buf. * @enable: this ETB is being used. @@ -84,7 +85,7 @@ struct etb_drvdata { struct coresight_device *csdev; struct miscdevice miscdev; spinlock_t spinlock; - atomic_t in_use; + local_t reading; u8 *buf; u32 buffer_depth; bool enable; @@ -277,7 +278,7 @@ static int etb_open(struct inode *inode, struct file *file) struct etb_drvdata *drvdata = container_of(file->private_data, struct etb_drvdata, miscdev); - if (atomic_cmpxchg(&drvdata->in_use, 0, 1)) + if (local_cmpxchg(&drvdata->reading, 0, 1)) return -EBUSY; dev_dbg(drvdata->dev, "%s: successfully opened\n", __func__); @@ -313,7 +314,7 @@ static int etb_release(struct inode *inode, struct file *file) { struct etb_drvdata *drvdata = container_of(file->private_data, struct etb_drvdata, miscdev); - atomic_set(&drvdata->in_use, 0); + local_set(&drvdata->reading, 0); dev_dbg(drvdata->dev, "%s: released\n", __func__); return 0;