From patchwork Wed Feb 17 08:32:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102761 Delivered-To: patch@linaro.org Received: by 10.112.43.199 with SMTP id y7csp2148486lbl; Wed, 17 Feb 2016 00:34:28 -0800 (PST) X-Received: by 10.98.16.85 with SMTP id y82mr414252pfi.90.1455698068775; Wed, 17 Feb 2016 00:34:28 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 5si474956pfs.118.2016.02.17.00.34.28; Wed, 17 Feb 2016 00:34:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756937AbcBQIe0 (ORCPT + 30 others); Wed, 17 Feb 2016 03:34:26 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:53710 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756629AbcBQIeY (ORCPT ); Wed, 17 Feb 2016 03:34:24 -0500 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue002) with ESMTPA (Nemesis) id 0Li5LP-1aAsLP3oOp-00nOid; Wed, 17 Feb 2016 09:33:41 +0100 From: Arnd Bergmann To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Luis de Bethencourt , Joshua Clayton , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8712: reduce stack usage Date: Wed, 17 Feb 2016 09:32:58 +0100 Message-Id: <1455698012-814399-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:K1f28/qzQUtSxowUgY8RJn6Uza0t6TH0+Tr/9dfi18+fmMAKjlu vRuTrRzd4qvii0x2cijz2gnv/Dk51DMQHglZ8o3p9GEYLwMAPX4FsvHsx8U8mFrBkqP7Kso WsxX5bH8T0mSs3F3gg52aKaNJuA7aOuFUacyrQv/FU6GDu5CZSZho1K7ZSD6m1yxrtPIzZ+ axKBUO/ZuUGc0OU3wgiVA== X-UI-Out-Filterresults: notjunk:1; V01:K0:eIDbVmjW4Do=:aPnjBtcCCc53yP9ZM3/Jq1 s3dJGGl/m1MVCBzQj3id9c4uZYm0ffsG47YA4fmVP/loG8hAIbxyN7v/Gin0nsNfxtf6St3rS W4g+ouLEfME5YG6tuWYtGEwS5obW/d6/7cZjKlPnHA4GvmcBcLxNHj+1TPyCS1ySxE6zaQ0xp f2wNARg76WsOR7Lzgk909UxZ1GHP2gf9oLZdfxhNgOOnhyKLqEhfa7b4xooXW0mqnY0OimEGs H/ANklUQBKg/meHgoGlbPcQ+7g2G7tPaZnlD6kfefPo7N1kToaAkuvmGBqDAL/9eaLEk0ggsp /CdUq+N8HNvrAEe80noFcEPaxQHfPiHxtHjPN0YQQMLPE6FZq9jyAv7Jfefy471V7GDFnGYQq 3AW/p/EpTH2k0yYYPjDNl+Qv61L9Sup+jSVjaPQstMHLNUO76GMslXFaV56WelROX6QzbKSt0 nWBYFKIRLvvcY1pF/S0+5DiF+iMABi4mzRU47MXzjkETdrAsuoPaBsXXd5I34wkTQ5SH1YHy/ BoMN/rWGHnRefeF7apWOCvmyLr3E+rYADeE6TZnDTCP/UqR1vPzxJoPM4QnsHETL4EYw5Mh9K 0ajD6yBZcV4CtB482wIBuv19+qu1F57D+ejznUx8QwA94H8OtuilGr9EAcy1QeRbY1ahlyrq3 GtaFYvDy0ds3Q5dZD/FLjTb/eUrO9ub377epeSbYFdYrL7I69rR8fgkMkQ2pTqKhgR6A= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The "translate_scan" function in rtl8712 uses a lot of stack, and gets inlined into its single caller, r8711_wx_get_scan, which in some configurations now blows the 1024 byte stack warning limit: drivers/staging/rtl8712/rtl871x_ioctl_linux.c: In function 'r8711_wx_get_scan': drivers/staging/rtl8712/rtl871x_ioctl_linux.c:1227:1: error: the frame size of 1032 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] This somewhat reduces the stack usage by moving the translate_scan function out of line with the noinline_for_stack annotation. It might be possible to modify translate_scan() a little further to reduce the stack usage, but with this patch, we can build without the warning, the the call chain to get here is rather predictable (sys_ioctl->vfs_ioctl->sock_ioctl->dev_ioctl->wext_ioctl-> r8711_wx_get_scan). Signed-off-by: Arnd Bergmann --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.0 diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c index db2e31bcdd77..a15f3ce70223 100644 --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c @@ -137,7 +137,7 @@ static inline void handle_group_key(struct ieee_param *param, } } -static inline char *translate_scan(struct _adapter *padapter, +static noinline_for_stack char *translate_scan(struct _adapter *padapter, struct iw_request_info *info, struct wlan_network *pnetwork, char *start, char *stop)