From patchwork Mon Feb 1 22:06:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matt Fleming X-Patchwork-Id: 60974 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp351471lbb; Mon, 1 Feb 2016 14:10:10 -0800 (PST) X-Received: by 10.98.16.86 with SMTP id y83mr14215765pfi.45.1454364610215; Mon, 01 Feb 2016 14:10:10 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o12si28233752pfj.112.2016.02.01.14.10.09; Mon, 01 Feb 2016 14:10:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dkim=pass header.i=@codeblueprint-co-uk.20150623.gappssmtp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933047AbcBAWKG (ORCPT + 30 others); Mon, 1 Feb 2016 17:10:06 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:38307 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932248AbcBAWHV (ORCPT ); Mon, 1 Feb 2016 17:07:21 -0500 Received: by mail-wm0-f53.google.com with SMTP id p63so92248914wmp.1 for ; Mon, 01 Feb 2016 14:07:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeblueprint-co-uk.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=N8DJywaVhUVtq3kvrhKpp3hOyiI+zsPPOlMuLi9JLm4=; b=v15jRwEex4zEjlLXzdXGFrp0oSnOCJFRZn9+9iQa1veniEFPUkdrUc4g7pZGHZcZ4h OAp2f/xHnGTfZ5kEEhw5JEqLInlrMb+nUfGryXoz17ncUbKoKAQPdHrstMk9/rPhVVua MZ4ZqFtyXNdX/WrtZTIO1VGu4tRsCLDZkWyarHu0tiRXEMa32k9h8uVjRHrRfQKejw1e 9dRb232oMZzYSSNgWhk5ry/6+9C1ncKKbAUKlHVS06vMHoDDK+XztQ50xU5otUhA9Kjc nZsZ27gxbGmWeJaNzbd/nCc+kHP4qRH5reHJa1hY9ASizYKosCIkiVYTKTK2iRnS/aLr cYOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=N8DJywaVhUVtq3kvrhKpp3hOyiI+zsPPOlMuLi9JLm4=; b=SLJBRxaGkajZQQneir4e1Ehd83PlAiz6n+m2lygAs+KDFfA7wmFsZF69AaEMcL68BD sRvSgyH1/7yIwf89enL64MFVNGlPXYTP8ZWHMFe7rk6D6xrUcWvvidGLzi6uYQwT2a3y BEJPgOycLuv9dAB7/2woaKln2PAxd62kIoXUM0exr9L2XOJGzom+yJJALSJpxgrfkjlD Qp2vkn0Cx0jaEJJoBphq1MB+PFznGUUOhNtF/Xgl20ZpdKFNuMw5JzlE9f4hJ+1Es0Ct 82hydSMSJYT2gLBsDpO6X/+mXv01aX37jIFsZgygwpW1tTQQH15E+8+a7uU5bEXBT001 NGMw== X-Gm-Message-State: AG10YORxSkw5ENDMCa1iay9V2yR4+jOWZWHYjAorn+eLmir1B6nBD1779fjtZmvUCFyBFQ== X-Received: by 10.28.23.5 with SMTP id 5mr14582905wmx.82.1454364440612; Mon, 01 Feb 2016 14:07:20 -0800 (PST) Received: from localhost (5ec16434.skybroadband.com. [94.193.100.52]) by smtp.gmail.com with ESMTPSA id kb5sm31240489wjc.22.2016.02.01.14.07.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Feb 2016 14:07:19 -0800 (PST) From: Matt Fleming To: Ingo Molnar , "H . Peter Anvin" , Thomas Gleixner Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Ard Biesheuvel , Matt Fleming Subject: [PATCH 05/14] efi: runtime-wrappers: Remove out of date comment regarding in_nmi() Date: Mon, 1 Feb 2016 22:06:59 +0000 Message-Id: <1454364428-494-6-git-send-email-matt@codeblueprint.co.uk> X-Mailer: git-send-email 2.6.2 In-Reply-To: <1454364428-494-1-git-send-email-matt@codeblueprint.co.uk> References: <1454364428-494-1-git-send-email-matt@codeblueprint.co.uk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ard Biesheuvel This code is long gone, so remove the comment as well. Signed-off-by: Ard Biesheuvel Signed-off-by: Matt Fleming --- drivers/firmware/efi/runtime-wrappers.c | 26 -------------------------- 1 file changed, 26 deletions(-) -- 2.6.2 diff --git a/drivers/firmware/efi/runtime-wrappers.c b/drivers/firmware/efi/runtime-wrappers.c index e9f2867f0d91..311f415bff51 100644 --- a/drivers/firmware/efi/runtime-wrappers.c +++ b/drivers/firmware/efi/runtime-wrappers.c @@ -62,32 +62,6 @@ static DEFINE_SPINLOCK(efi_runtime_lock); /* - * Some runtime services calls can be reentrant under NMI, even if the table - * above says they are not. (source: UEFI Specification v2.4A) - * - * Table 32. Functions that may be called after Machine Check, INIT and NMI - * +----------------------------+------------------------------------------+ - * | Function | Called after Machine Check, INIT and NMI | - * +----------------------------+------------------------------------------+ - * | GetTime() | Yes, even if previously busy. | - * | GetVariable() | Yes, even if previously busy | - * | GetNextVariableName() | Yes, even if previously busy | - * | QueryVariableInfo() | Yes, even if previously busy | - * | SetVariable() | Yes, even if previously busy | - * | UpdateCapsule() | Yes, even if previously busy | - * | QueryCapsuleCapabilities() | Yes, even if previously busy | - * | ResetSystem() | Yes, even if previously busy | - * +----------------------------+------------------------------------------+ - * - * In order to prevent deadlocks under NMI, the wrappers for these functions - * may only grab the efi_runtime_lock or rtc_lock spinlocks if !efi_in_nmi(). - * However, not all of the services listed are reachable through NMI code paths, - * so the the special handling as suggested by the UEFI spec is only implemented - * for QueryVariableInfo() and SetVariable(), as these can be reached in NMI - * context through efi_pstore_write(). - */ - -/* * As per commit ef68c8f87ed1 ("x86: Serialize EFI time accesses on rtc_lock"), * the EFI specification requires that callers of the time related runtime * functions serialize with other CMOS accesses in the kernel, as the EFI time