From patchwork Mon Jan 25 16:02:49 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101107 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp1443024lbb; Mon, 25 Jan 2016 08:03:43 -0800 (PST) X-Received: by 10.98.72.132 with SMTP id q4mr26447898pfi.53.1453737822795; Mon, 25 Jan 2016 08:03:42 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p11si6754465par.72.2016.01.25.08.03.42; Mon, 25 Jan 2016 08:03:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933439AbcAYQDi (ORCPT + 30 others); Mon, 25 Jan 2016 11:03:38 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:57366 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932879AbcAYQDe (ORCPT ); Mon, 25 Jan 2016 11:03:34 -0500 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue101) with ESMTPA (Nemesis) id 0LqlM2-1ZsXVx0Koc-00eOWM; Mon, 25 Jan 2016 17:02:59 +0100 From: Arnd Bergmann To: Daniel Lezcano Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: [PATCH] clocksource: select CLKSRC_MMIO where needed Date: Mon, 25 Jan 2016 17:02:49 +0100 Message-Id: <1453737776-1960372-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:gbBJWStuO0tfNhpMJfyT/tGHc0yffHZrwuPL+sfVt97vFIIJhua 6t9skvFraqR5mr80jcBKx2sxcAnv/VkFvbdwmkO2J/fw8USiFgR+24F5tjCDvk+M7C8uUgu rcDeRYUeCNYatFuZ1cHBBkXR95gtgPvupnrrwcQQM2RCFFJy4HxAGZlYEdgGUEO77Qk++IY 7hOJgMkCNiYQU1FUGxuyg== X-UI-Out-Filterresults: notjunk:1; V01:K0:PhhpalJBCQw=:FlGqVzKy3Av5+hWmMAeEAQ FhvuRG+Vx448k3T76FLR/IV+9dDGzJ72VMVwTpCdMXVtww3l3sy5TZPxRDEfWgNw1T8gKZwNR wUtdmQOCsxVlAfXgbAXhBE4UrQmNYjI6APq9RDzI1J46PTcnKcTO3QzXwNQp1nl8g0aPSw69O aIMaTghcH3ezJevFIH3i5t4MLFuL9fVyi6IhcUU95p2wmetfmLw6Ui/Nvku/g4ihHDInqRQ6e dy5otzecZOG5/u8Jf3gdxDdcXRX3XERrWwvU01sD5PLsEVpZ28EBQ28uh4uKrhgcZPXrbZdhr 3xAXOuJl0mIua+qGWfKTtmCoq3TFps/qd1F9RnBXjyjuVAAG4Ki2/VkWqDOXj5frMFD2qN1q0 Xecur8+J30ep+EGYrOZfgTAs6qXLF7JSOXFBNS7Luaxcvv8Xo7hDtdU/gXw8V7Fe3cOTEPMKz 1bU2JWmEIuO4sskEtTuuLFWG6d8EkxQaombFjfURUG1X++WMum2Q5Uw+wqZcL2UdBl3YfnzK1 PVlQsSiMfnOIjtcUVO43ST5AsCYG5o2E45H1KQC5rK3JAl+DxUzO7dfnIoYozV5ZBUDW+EXbS AKlQDmAZ8pVLYionoiUBa80VvJmvO5JD4d3945arT+n1AVpMKQu0rSda2c69n+eNXe4MAby/0 KY9kfn2m0p5P3UqpQvf0ifuGrKC1F3yaPF01uiGx7xqUDvUw5z0kGNmFZcZdnwJZBjSU= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Tegra clocksource implementation uses the clocksource_mmio helper functions, but currently can be configured without them, which fails: drivers/clocksource/built-in.o: In function `tegra20_init_timer': :(.init.text+0xac): undefined reference to `clocksource_mmio_init' :(.init.text+0x140): undefined reference to `clocksource_mmio_readl_up' The same problem exists for Digicolor: drivers/clocksource/built-in.o: In function `digicolor_timer_init': :(.init.text+0xfa): undefined reference to `clocksource_mmio_init' :(.init.text+0x14c): undefined reference to `clocksource_mmio_readl_down' I've inspected the Kconfig file to look for other cases that I have not yet run into, and added an explicit 'select' to each one to ensure we can successfully link the drivers. Signed-off-by: Arnd Bergmann --- drivers/clocksource/Kconfig | 5 +++++ 1 file changed, 5 insertions(+) -- 2.7.0 diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index 56777f04d2d9..f70b4f3b4857 100644 --- a/drivers/clocksource/Kconfig +++ b/drivers/clocksource/Kconfig @@ -30,6 +30,7 @@ config CLKSRC_MMIO config DIGICOLOR_TIMER bool "Digicolor timer driver" if COMPILE_TEST depends on GENERIC_CLOCKEVENTS + select CLKSRC_MMIO help Enables the support for the digicolor timer driver. @@ -55,6 +56,7 @@ config ARMADA_370_XP_TIMER bool "Armada 370 and XP timer driver" if COMPILE_TEST depends on ARM select CLKSRC_OF + select CLKSRC_MMIO help Enables the support for the Armada 370 and XP timer driver. @@ -89,6 +91,7 @@ config SUN5I_HSTIMER config TEGRA_TIMER bool "Tegra timer driver" if COMPILE_TEST + select CLKSRC_MMIO depends on ARM help Enables support for the Tegra driver. @@ -263,6 +266,7 @@ config FSL_FTM_TIMER config VF_PIT_TIMER bool + select CLKSRC_MMIO help Support for Period Interrupt Timer on Freescale Vybrid Family SoCs. @@ -394,6 +398,7 @@ config CLKSRC_ST_LPC bool "Low power clocksource found in the LPC" if COMPILE_TEST select CLKSRC_OF if OF depends on HAS_IOMEM + select CLKSRC_MMIO help Enable this option to use the Low Power controller timer as clocksource.